aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrussell <russell@f38db490-d61c-443f-a65b-d21fe96a405b>2008-07-07 22:42:30 +0000
committerrussell <russell@f38db490-d61c-443f-a65b-d21fe96a405b>2008-07-07 22:42:30 +0000
commit715a24e685f4dceab228e865875c4d15b2c12c31 (patch)
tree5daeaa2864bb23b357e548c7e2b20d3e36aa889e
parent539f7a260ebff87fd489047086c8784a8bee3b17 (diff)
Merged revisions 128795 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r128795 | russell | 2008-07-07 17:41:48 -0500 (Mon, 07 Jul 2008) | 8 lines Fix handling of when a pvt disappears. Properly return the pvt locked and don't hold the pvt lock while destroying the ast_channel. (closes issue #13014) Reported by: jpgrayson Patches: chan_iax2_ast_iax2_new2.patch uploaded by jpgrayson (license 492) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@128796 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r--channels/chan_iax2.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/channels/chan_iax2.c b/channels/chan_iax2.c
index 831d6f62c..1a749b644 100644
--- a/channels/chan_iax2.c
+++ b/channels/chan_iax2.c
@@ -4091,11 +4091,13 @@ static struct ast_channel *ast_iax2_new(int callno, int state, int capability)
ast_mutex_unlock(&iaxsl[callno]);
tmp = ast_channel_alloc(1, state, i->cid_num, i->cid_name, i->accountcode, i->exten, i->context, i->amaflags, "IAX2/%s-%d", i->host, i->callno);
ast_mutex_lock(&iaxsl[callno]);
- if (!iaxs[callno]) {
+ if (i != iaxs[callno]) {
if (tmp) {
+ /* unlock and relock iaxsl[callno] to preserve locking order */
+ ast_mutex_unlock(&iaxsl[callno]);
ast_channel_free(tmp);
+ ast_mutex_lock(&iaxsl[callno]);
}
- ast_mutex_unlock(&iaxsl[callno]);
return NULL;
}
iax2_ami_channelupdate(i);