diff options
| author | rmudgett <rmudgett@f38db490-d61c-443f-a65b-d21fe96a405b> | 2010-04-27 22:46:44 +0000 |
|---|---|---|
| committer | rmudgett <rmudgett@f38db490-d61c-443f-a65b-d21fe96a405b> | 2010-04-27 22:46:44 +0000 |
| commit | 455235be9e03ef44454358996155e8e2b8e82822 (patch) | |
| tree | 45a5a69cb398f85b22dd82fc7ff8adc302a47129 | |
| parent | c91e47606fd02da6f325921ec1ee83377d2f586c (diff) | |
Merged revisions 259538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
................
r259538 | rmudgett | 2010-04-27 17:18:09 -0500 (Tue, 27 Apr 2010) | 18 lines
Merged revisions 259531 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r259531 | rmudgett | 2010-04-27 16:53:07 -0500 (Tue, 27 Apr 2010) | 11 lines
DAHDI "WARNING" message is confusing and vague
"WARNING[28406]: chan_dahdi.c:6873 ss_thread: CallerID feed failed: Success"
Changed the warning to "Failed to decode CallerID on channel 'name'". The
message before it is likely more specific about why the CallerID decode
failed.
SWP-501
AST-283
........
................
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@259616 f38db490-d61c-443f-a65b-d21fe96a405b
| -rw-r--r-- | channels/chan_dahdi.c | 23 |
1 files changed, 19 insertions, 4 deletions
diff --git a/channels/chan_dahdi.c b/channels/chan_dahdi.c index 84edbf27d..c5105b46d 100644 --- a/channels/chan_dahdi.c +++ b/channels/chan_dahdi.c @@ -8473,9 +8473,14 @@ static void *ss_thread(void *data) } else { res = callerid_feed(cs, buf, res, AST_LAW(p)); } - if (res < 0) { - ast_log(LOG_WARNING, "CallerID feed failed on channel '%s'\n", chan->name); + /* + * The previous diagnostic message output likely + * explains why it failed. + */ + ast_log(LOG_WARNING, + "Failed to decode CallerID on channel '%s'\n", + chan->name); break; } else if (res) break; @@ -8740,7 +8745,13 @@ static void *ss_thread(void *data) samples += res; res = callerid_feed(cs, buf, res, AST_LAW(p)); if (res < 0) { - ast_log(LOG_WARNING, "CallerID feed failed: %s\n", strerror(errno)); + /* + * The previous diagnostic message output likely + * explains why it failed. + */ + ast_log(LOG_WARNING, + "Failed to decode CallerID on channel '%s'\n", + chan->name); break; } else if (res) break; @@ -9017,7 +9028,11 @@ static void *mwi_thread(void *data) samples += res; if (!spill_done) { if ((spill_result = callerid_feed(cs, mtd->buf, res, AST_LAW(mtd->pvt))) < 0) { - ast_log(LOG_WARNING, "CallerID feed failed: %s\n", strerror(errno)); + /* + * The previous diagnostic message output likely + * explains why it failed. + */ + ast_log(LOG_WARNING, "Failed to decode CallerID\n"); break; } else if (spill_result) { spill_done = 1; |