diff options
author | markster <markster@f38db490-d61c-443f-a65b-d21fe96a405b> | 2005-01-09 09:42:54 +0000 |
---|---|---|
committer | markster <markster@f38db490-d61c-443f-a65b-d21fe96a405b> | 2005-01-09 09:42:54 +0000 |
commit | c6a8c87fbba54ed82e192b735e4f7cffa5cab036 (patch) | |
tree | b4105f856737cd2e5a4aa7c92eb99bcb34fe7d08 | |
parent | a985c15efe6b830411599a30b834bc6a5a8430ee (diff) |
Don't allow masquerading into oneself (bug #3040)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@4726 f38db490-d61c-443f-a65b-d21fe96a405b
-rwxr-xr-x | channel.c | 4 | ||||
-rwxr-xr-x | channels/chan_sip.c | 10 |
2 files changed, 11 insertions, 3 deletions
@@ -2208,6 +2208,10 @@ int ast_channel_masquerade(struct ast_channel *original, struct ast_channel *clo { struct ast_frame null = { AST_FRAME_NULL, }; int res = -1; + if (original == clone) { + ast_log(LOG_WARNING, "Can't masquerade channel '%s' into itself!\n", original->name); + return -1; + } ast_mutex_lock(&original->lock); while(ast_mutex_trylock(&clone->lock)) { ast_mutex_unlock(&original->lock); diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 173a62ce5..ec9ccda9c 100755 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -5335,9 +5335,13 @@ static int get_refer_info(struct sip_pvt *p, struct sip_request *oreq) p2 = p2->next; } ast_mutex_unlock(&iflock); - if (p->refer_call) - return 0; - else + if (p->refer_call) { + if (p->refer_call == p) { + ast_log(LOG_NOTICE, "Supervised transfer attempted to transfer into same call id (%s == %s)!\n", tmp5, p->callid); + p->refer_call = NULL; + } else + return 0; + } else ast_log(LOG_NOTICE, "Supervised transfer requested, but unable to find callid '%s'\n", tmp5); } else if (ast_exists_extension(NULL, p->context, c, 1, NULL) || !strcmp(c, ast_parking_ext())) { /* This is an unsupervised transfer */ |