diff options
| author | mmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2009-03-24 22:42:26 +0000 |
|---|---|---|
| committer | mmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2009-03-24 22:42:26 +0000 |
| commit | 6e3f3974e1bc405508906a198e4704ad534857a2 (patch) | |
| tree | 487b091ede793c6ea0e19767ff8a98f65f4e022d | |
| parent | f335611bc83d3c896da346bedcf2371da889b854 (diff) | |
Merged revisions 184079 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
................
r184079 | mmichelson | 2009-03-24 17:40:39 -0500 (Tue, 24 Mar 2009) | 15 lines
Merged revisions 184078 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r184078 | mmichelson | 2009-03-24 17:34:45 -0500 (Tue, 24 Mar 2009) | 9 lines
Change NULL pointer check to be ast_strlen_zero.
The 'digit' variable is guaranteed to be non-NULL, so the if
statement could never evaluate true. Changing to ast_strlen_zero
makes the logic correct.
This was found while reviewing ast_channel_ao2 code review.
........
................
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@184082 f38db490-d61c-443f-a65b-d21fe96a405b
| -rw-r--r-- | apps/app_senddtmf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/app_senddtmf.c b/apps/app_senddtmf.c index 05faf2221..9842c412e 100644 --- a/apps/app_senddtmf.c +++ b/apps/app_senddtmf.c @@ -106,7 +106,7 @@ static int manager_play_dtmf(struct mansession *s, const struct message *m) astman_send_error(s, m, "Channel not specified"); return 0; } - if (!digit) { + if (ast_strlen_zero(digit)) { astman_send_error(s, m, "No digit specified"); ast_channel_unlock(chan); return 0; |