aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b>2008-12-16 23:07:06 +0000
committermmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b>2008-12-16 23:07:06 +0000
commitf1ac24791061eb3588aa8d1f93b7b6f41822ecf6 (patch)
treed5859d3fa209e04f6465ec580be8313aa9c44b25
parenta3577cdd761e0a42070f317c9e78fef178a5c204 (diff)
Merged revisions 164978 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk ................ r164978 | mmichelson | 2008-12-16 17:06:04 -0600 (Tue, 16 Dec 2008) | 15 lines Merged revisions 164977 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164977 | mmichelson | 2008-12-16 17:04:27 -0600 (Tue, 16 Dec 2008) | 7 lines After looking through SIP registration code most of the day, this is one of the few things I could find that was just plain wrong. Even though it probably isn't possible for it to happen, it seems weird to have code that checks if a pointer is NULL and then immediately dereferences that pointer if it was NULL. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@164979 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r--channels/chan_sip.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 32bac3518..e0f719615 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -9386,7 +9386,9 @@ static int transmit_register(struct sip_registry *r, int sipmethod, const char *
/* exit if we are already in process with this registrar ?*/
if ( r == NULL || ((auth==NULL) && (r->regstate==REG_STATE_REGSENT || r->regstate==REG_STATE_AUTHSENT))) {
- ast_log(LOG_NOTICE, "Strange, trying to register %s@%s when registration already pending\n", r->username, r->hostname);
+ if (r) {
+ ast_log(LOG_NOTICE, "Strange, trying to register %s@%s when registration already pending\n", r->username, r->hostname);
+ }
return 0;
}