aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortilghman <tilghman@f38db490-d61c-443f-a65b-d21fe96a405b>2009-08-28 20:15:51 +0000
committertilghman <tilghman@f38db490-d61c-443f-a65b-d21fe96a405b>2009-08-28 20:15:51 +0000
commit155861d87229dd22044538416d0be9c156c319a1 (patch)
treef15938293128ad34df0374567c629651280653a5
parent6d234c5dca64a4b673bd05fcccc71cb4f5fc88dc (diff)
Merged revisions 214702 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk ................ r214702 | tilghman | 2009-08-28 15:14:39 -0500 (Fri, 28 Aug 2009) | 15 lines Merged revisions 214701 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214701 | tilghman | 2009-08-28 15:13:32 -0500 (Fri, 28 Aug 2009) | 8 lines Modify comment to be a bit more accurate. We have kept this comment around long enough, that it's pretty clear that we're keeping the code, because changing the code would require a pretty fundamental architectural shift. We've also taken criticism in some quarters, because it was believed that it was referring to the code being nasty. No, the code isn't nasty, just the operation itself is rather odd. Fixed for eternity (probably not). ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@214703 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r--main/channel.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/main/channel.c b/main/channel.c
index a02b6c073..39a47545b 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -4320,10 +4320,10 @@ int ast_do_masquerade(struct ast_channel *original)
manager_event(EVENT_FLAG_CALL, "Masquerade", "Clone: %s\r\nCloneState: %s\r\nOriginal: %s\r\nOriginalState: %s\r\n",
clone->name, ast_state2str(clone->_state), original->name, ast_state2str(original->_state));
- /* XXX This is a seriously wacked out operation. We're essentially putting the guts of
- the clone channel into the original channel. Start by killing off the original
- channel's backend. I'm not sure we're going to keep this function, because
- while the features are nice, the cost is very high in terms of pure nastiness. XXX */
+ /* XXX This operation is a bit odd. We're essentially putting the guts of
+ * the clone channel into the original channel. Start by killing off the
+ * original channel's backend. While the features are nice, which is the
+ * reason we're keeping it, it's still awesomely weird. XXX */
/* We need the clone's lock, too */
ast_channel_lock(clone);