diff options
author | tilghman <tilghman@f38db490-d61c-443f-a65b-d21fe96a405b> | 2011-02-14 20:16:55 +0000 |
---|---|---|
committer | tilghman <tilghman@f38db490-d61c-443f-a65b-d21fe96a405b> | 2011-02-14 20:16:55 +0000 |
commit | 02560104b4aa6aa16f9603b496c6cbfee6a80126 (patch) | |
tree | 8b84a77681fb7f9ceba974eaeabf118e145b15c7 | |
parent | 505429d5c21a93a257dc3c74180b5927b6e5062a (diff) |
Merged revisions 307792 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r307792 | tilghman | 2011-02-14 14:10:28 -0600 (Mon, 14 Feb 2011) | 8 lines
Increment usage count at first reference, to avoid a race condition with many threads creating connections all at once.
(issue #18156)
Reported by: asgaroth
Patches:
20110214__issue18156.diff.txt uploaded by tilghman (license 14)
Tested by: tilghman
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.8@307793 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r-- | res/res_odbc.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/res/res_odbc.c b/res/res_odbc.c index 67ba3111d..340ee712d 100644 --- a/res/res_odbc.c +++ b/res/res_odbc.c @@ -1218,13 +1218,14 @@ struct odbc_obj *_ast_odbc_request_obj2(const char *name, struct ast_flags flags if (obj) { ast_assert(ao2_ref(obj, 0) > 1); } - if (!obj && (class->count < class->limit) && + if (!obj && (ast_atomic_fetchadd_int(&class->count, +1) < class->limit) && (time(NULL) > class->last_negative_connect.tv_sec + class->negative_connection_cache.tv_sec)) { obj = ao2_alloc(sizeof(*obj), odbc_obj_destructor); if (!obj) { class->count--; ao2_ref(class, -1); ast_debug(3, "Unable to allocate object\n"); + ast_atomic_fetchadd_int(&class->count, -1); return NULL; } ast_assert(ao2_ref(obj, 0) == 1); @@ -1235,14 +1236,18 @@ struct odbc_obj *_ast_odbc_request_obj2(const char *name, struct ast_flags flags if (odbc_obj_connect(obj) == ODBC_FAIL) { ast_log(LOG_WARNING, "Failed to connect to %s\n", name); ao2_ref(obj, -1); - ast_assert(ao2_ref(class, 0) > 0); obj = NULL; + ast_assert(ao2_ref(class, 0) > 0); + ast_atomic_fetchadd_int(&class->count, -1); } else { obj->used = 1; ao2_link(obj->parent->obj_container, obj); - ast_atomic_fetchadd_int(&obj->parent->count, +1); } } else { + /* If construction fails due to the limit (or negative timecache), reverse our increment. */ + if (!obj) { + ast_atomic_fetchadd_int(&class->count, -1); + } /* Object is not constructed, so delete outstanding reference to class. */ ao2_ref(class, -1); class = NULL; |