aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b>2008-06-17 15:58:21 +0000
committermmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b>2008-06-17 15:58:21 +0000
commit2ee27fd87f55632e832d749c5fe6739a68aeb913 (patch)
treebe42f6405ad88a2495c8ce7abad279430fe90a0d
parent839a3fcefbd42419498caae41c91b1d2bd4f9778 (diff)
Merged revisions 123275 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk ................ r123275 | mmichelson | 2008-06-17 10:57:43 -0500 (Tue, 17 Jun 2008) | 20 lines Merged revisions 123274 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r123274 | mmichelson | 2008-06-17 10:56:55 -0500 (Tue, 17 Jun 2008) | 12 lines davidw pointed out that the holdtime calculation used by app_queue does not use "boxcar" filtering as the comments say. The term "boxcar" means that the number of samples used to calculate stays constant, with new samples replacing the oldest ones. The queue holdtime calculation uses all holdtime samples collected since the queue was loaded, so the comment has been changed to be accurate. (closes issue #12781) Reported by: davidw ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@123276 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r--apps/app_queue.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/app_queue.c b/apps/app_queue.c
index 901043d82..bf020331d 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -467,7 +467,7 @@ struct call_queue {
int minannouncefrequency; /*!< The minimum number of seconds between position announcements (def. 15) */
int periodicannouncefrequency; /*!< How often to play periodic announcement */
int roundingseconds; /*!< How many seconds do we round to? */
- int holdtime; /*!< Current avg holdtime, based on recursive boxcar filter */
+ int holdtime; /*!< Current avg holdtime, based on an exponential average */
int callscompleted; /*!< Number of queue calls completed */
int callsabandoned; /*!< Number of queue calls abandoned */
int servicelevel; /*!< seconds setting for servicelevel*/
@@ -1910,7 +1910,7 @@ static void recalc_holdtime(struct queue_ent *qe, int newholdtime)
{
int oldvalue;
- /* Calculate holdtime using a recursive boxcar filter */
+ /* Calculate holdtime using an exponential average */
/* Thanks to SRT for this contribution */
/* 2^2 (4) is the filter coefficient; a higher exponent would give old entries more weight */