aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsruffell <sruffell@f38db490-d61c-443f-a65b-d21fe96a405b>2010-11-05 00:02:53 +0000
committersruffell <sruffell@f38db490-d61c-443f-a65b-d21fe96a405b>2010-11-05 00:02:53 +0000
commit859dac960e02e1d313bc47f9781001f1add7e95d (patch)
treeb7c63e86e585caf779effc1e0c259b101c3ff1b6
parent44d53b8aa71e52681dc897c30d8725dbaa32ca3a (diff)
codecs/codec_dahdi: Prevent "choppy" audio when receiving unexpected frame sizes.
dahdi-linux 2.4.0 (specifically commit 9034) added the capability for the wctc4xxp to return more than a single packet of data in response to a read. However, when decoding packets, codec_dahdi was still assuming that the default number of samples was in each read. In other words, each packet your provider sent you, regardless of size, would result in 20 ms of decoded data (30 ms if decoding G723). If your provider was sending 60 ms packets then codec_dahdi would end up stripping 40 ms of data from each transcoded frame resulting in "choppy" audio. This would only affect systems where G729 packets are arriving in sizes greater than 20ms or G723 packets arriving in sizes greater than 30ms. DAHDI-744. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@293968 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r--codecs/codec_dahdi.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/codecs/codec_dahdi.c b/codecs/codec_dahdi.c
index 5577272db..fcea27d4c 100644
--- a/codecs/codec_dahdi.c
+++ b/codecs/codec_dahdi.c
@@ -120,10 +120,10 @@ struct codec_dahdi_pvt {
};
/* Only used by a decoder */
-static int ulawtolin(struct ast_trans_pvt *pvt)
+static int ulawtolin(struct ast_trans_pvt *pvt, int samples)
{
struct codec_dahdi_pvt *ztp = pvt->pvt;
- int i = ztp->required_samples;
+ int i = samples;
uint8_t *src = &ztp->ulaw_buffer[0];
int16_t *dst = (int16_t *)pvt->outbuf + pvt->datalen;
@@ -345,7 +345,7 @@ static struct ast_frame *dahdi_decoder_frameout(struct ast_trans_pvt *pvt)
}
} else {
if (ztp->softslin) {
- ulawtolin(pvt);
+ ulawtolin(pvt, res);
pvt->f.datalen = res * 2;
} else {
pvt->f.datalen = res;
@@ -357,7 +357,7 @@ static struct ast_frame *dahdi_decoder_frameout(struct ast_trans_pvt *pvt)
pvt->f.offset = AST_FRIENDLY_OFFSET;
pvt->f.src = pvt->t->name;
pvt->f.data = pvt->outbuf;
- pvt->f.samples = ztp->required_samples;
+ pvt->f.samples = res;
pvt->samples = 0;
return ast_frisolate(&pvt->f);