diff options
| author | mnicholson <mnicholson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2010-09-17 13:34:34 +0000 |
|---|---|---|
| committer | mnicholson <mnicholson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2010-09-17 13:34:34 +0000 |
| commit | 5003ce4525a3cab697c8ab118a2b26c4b666c14a (patch) | |
| tree | 5383f131da50b57888789c17002f663000c35384 | |
| parent | 3b42411d3ba32316bb4fb7f20e2064dd1daa9fe9 (diff) | |
Use ast_strdup() instead of ast_strdupa() while processing in ast_hint_state_changed().
(related to issue #17928)
Reported by: mdu113
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@287307 f38db490-d61c-443f-a65b-d21fe96a405b
| -rw-r--r-- | main/pbx.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/main/pbx.c b/main/pbx.c index 67d4ac71a..c232b9bb2 100644 --- a/main/pbx.c +++ b/main/pbx.c @@ -2017,14 +2017,19 @@ void ast_hint_state_changed(const char *device) AST_LIST_TRAVERSE(&hints, hint, list) { struct ast_state_cb *cblist; - char *parse = ast_strdupa(ast_get_extension_app(hint->exten)); - char *cur; + /* can't use ast_strdupa() here because we may run out of stack + * space while looping over a large number of large strings */ + char *dup = ast_strdup(ast_get_extension_app(hint->exten)); + char *cur, *parse = dup; int state; while ( (cur = strsep(&parse, "&")) ) { if (!strcasecmp(cur, device)) break; } + + ast_free(dup); + if (!cur) continue; |