diff options
| author | tilghman <tilghman@f38db490-d61c-443f-a65b-d21fe96a405b> | 2006-05-13 04:08:29 +0000 |
|---|---|---|
| committer | tilghman <tilghman@f38db490-d61c-443f-a65b-d21fe96a405b> | 2006-05-13 04:08:29 +0000 |
| commit | bc26e515b0dba5424028d5352c565298fe5767b7 (patch) | |
| tree | ab35d5cb36817db5a86005559304cbbe12a9eb2c | |
| parent | 48176894529ec0aabe5c98866c935c394d809cd0 (diff) | |
Bug 7134 - File descriptor leak with ODBC storage of voicemail
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.2@27093 f38db490-d61c-443f-a65b-d21fe96a405b
| -rw-r--r-- | apps/app_voicemail.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c index 8486ec10c..017c75c38 100644 --- a/apps/app_voicemail.c +++ b/apps/app_voicemail.c @@ -898,7 +898,7 @@ static int retrieve_file(char *dir, int msgnum) SQLFreeHandle (SQL_HANDLE_STMT, stmt); goto yuck; } - fd = open(full_fn, O_RDWR | O_CREAT | O_TRUNC); + fd = open(full_fn, O_RDWR | O_CREAT | O_TRUNC, 0770); if (fd < 0) { ast_log(LOG_WARNING, "Failed to write '%s': %s\n", full_fn, strerror(errno)); SQLFreeHandle (SQL_HANDLE_STMT, stmt); @@ -925,13 +925,13 @@ static int retrieve_file(char *dir, int msgnum) if (!strcasecmp(coltitle, "recording")) { res = SQLGetData(stmt, x + 1, SQL_BINARY, NULL, 0, &colsize); fdlen = colsize; - fd = open(full_fn, O_RDWR | O_TRUNC | O_CREAT, 0770); if (fd > -1) { char tmp[1]=""; lseek(fd, fdlen - 1, SEEK_SET); if (write(fd, tmp, 1) != 1) { close(fd); fd = -1; + continue; } if (fd > -1) fdm = mmap(NULL, fdlen, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); |