aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkpfleming <kpfleming@f38db490-d61c-443f-a65b-d21fe96a405b>2006-05-11 08:52:46 +0000
committerkpfleming <kpfleming@f38db490-d61c-443f-a65b-d21fe96a405b>2006-05-11 08:52:46 +0000
commitbb1705d6b39bdd76108f7006810f006a4ab831b1 (patch)
treefcbb2bf3fda4f914773898f4772f21daea00e251
parent5aa27282129e3fde069e34c08d3a1a677abe56ca (diff)
ensure that we send a response to REGISTER requests that are successfully authenticated but contain invalid Contact URIs
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.2@26760 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r--channels/chan_sip.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 4a4d841bf..aa651015d 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -6415,6 +6415,9 @@ static int register_verify(struct sip_pvt *p, struct sockaddr_in *sin, struct si
switch (parse_register_contact(p, peer, req)) {
case PARSE_REGISTER_FAILED:
ast_log(LOG_WARNING, "Failed to parse contact info\n");
+ transmit_response_with_date(p, "400 Bad Request", req);
+ peer->lastmsgssent = -1;
+ res = 0;
break;
case PARSE_REGISTER_QUERY:
transmit_response_with_date(p, "200 OK", req);
@@ -6437,11 +6440,13 @@ static int register_verify(struct sip_pvt *p, struct sockaddr_in *sin, struct si
peer = temp_peer(name);
if (peer) {
ASTOBJ_CONTAINER_LINK(&peerl, peer);
- peer->lastmsgssent = -1;
sip_cancel_destroy(p);
switch (parse_register_contact(p, peer, req)) {
case PARSE_REGISTER_FAILED:
ast_log(LOG_WARNING, "Failed to parse contact info\n");
+ transmit_response_with_date(p, "400 Bad Request", req);
+ peer->lastmsgssent = -1;
+ res = 0;
break;
case PARSE_REGISTER_QUERY:
transmit_response_with_date(p, "200 OK", req);