diff options
author | mnicholson <mnicholson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2010-09-20 15:48:14 +0000 |
---|---|---|
committer | mnicholson <mnicholson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2010-09-20 15:48:14 +0000 |
commit | f7cf272e9e04857b6300eb7b33807500f96363b3 (patch) | |
tree | a5b8b7579172b5955c7a79d8d908253d48b154f8 | |
parent | 80adcdf61ea4f17c2f5e60035d5fde2d5f7f90ce (diff) |
Use ast_dynamic_str when processing hint state changes
(related to issue #17928)
Reported by: mdu113
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@287555 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r-- | main/pbx.c | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/main/pbx.c b/main/pbx.c index c232b9bb2..ed0a3e529 100644 --- a/main/pbx.c +++ b/main/pbx.c @@ -2011,25 +2011,28 @@ int ast_extension_state(struct ast_channel *c, const char *context, const char * void ast_hint_state_changed(const char *device) { struct ast_hint *hint; + struct ast_dynamic_str *str; + + if (!(str = ast_dynamic_str_create(1024))) { + return; + } ast_rdlock_contexts(); AST_LIST_LOCK(&hints); AST_LIST_TRAVERSE(&hints, hint, list) { struct ast_state_cb *cblist; - /* can't use ast_strdupa() here because we may run out of stack - * space while looping over a large number of large strings */ - char *dup = ast_strdup(ast_get_extension_app(hint->exten)); - char *cur, *parse = dup; + char *cur, *parse; int state; + ast_dynamic_str_set(&str, 0, "%s", ast_get_extension_app(hint->exten)); + parse = str->str; + while ( (cur = strsep(&parse, "&")) ) { if (!strcasecmp(cur, device)) break; } - ast_free(dup); - if (!cur) continue; @@ -2054,6 +2057,7 @@ void ast_hint_state_changed(const char *device) AST_LIST_UNLOCK(&hints); ast_unlock_contexts(); + ast_free(str); } /*! \brief ast_extension_state_add: Add watcher for extension states */ |