aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkpfleming <kpfleming@f38db490-d61c-443f-a65b-d21fe96a405b>2006-10-17 17:57:36 +0000
committerkpfleming <kpfleming@f38db490-d61c-443f-a65b-d21fe96a405b>2006-10-17 17:57:36 +0000
commit6fff8a4cfd822c1ac5e3992ea965bddc97648970 (patch)
treea55619e28a2a97ea63f6ac85ae630a674cc8916e
parent6758935c4049539e9af7dfbdeb7a9ea84fa6978c (diff)
properly handle signed integer input
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.0@45336 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r--channels/chan_skinny.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/channels/chan_skinny.c b/channels/chan_skinny.c
index 98d9d86d8..9de3faea6 100644
--- a/channels/chan_skinny.c
+++ b/channels/chan_skinny.c
@@ -2305,6 +2305,10 @@ static int get_input(struct skinnysession *s)
return -1;
}
dlen = *(int *)s->inbuf;
+ if (dlen < 0) {
+ ast_log(LOG_WARNING, "Skinny Client sent invalid data.\n");
+ return -1;
+ }
if (dlen+8 > sizeof(s->inbuf))
dlen = sizeof(s->inbuf) - 8;
res = read(s->fd, s->inbuf+4, dlen+4);