diff options
author | mmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-11-18 21:59:24 +0000 |
---|---|---|
committer | mmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-11-18 21:59:24 +0000 |
commit | 8c3fa3762b55d5930262eef85e221fb35c9b6df3 (patch) | |
tree | 336e3202eb2a6f73a95e8dc00dd51a1eb36f57ac | |
parent | be51c79720ca05c7a8cfc8c2081a6ea5e963a715 (diff) |
Based on Russell's advice on the asterisk-dev list, I have
changed from using a global lock in update_call_counter to
using the locks within the sip_pvt and sip_peer structures
instead.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157496 f38db490-d61c-443f-a65b-d21fe96a405b
-rw-r--r-- | channels/chan_sip.c | 42 |
1 files changed, 26 insertions, 16 deletions
diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 9683330a1..1ae379397 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -2118,9 +2118,6 @@ enum t38_action_flag { SDP_T38_ACCEPT, /*!< Remote side accepted our T38 request */ }; -/*! \brief Protect the callcounters inuse,inringing and the corresponding flags */ -AST_MUTEX_DEFINE_STATIC(callctrlock); - /*---------------------------- Forward declarations of functions in chan_sip.c */ /* Note: This is added to help splitting up chan_sip.c into several files in coming releases. */ @@ -5099,36 +5096,43 @@ static int update_call_counter(struct sip_pvt *fup, int event) case DEC_CALL_LIMIT: /* Decrement inuse count if applicable */ if (inuse) { - ast_mutex_lock(&callctrlock); + sip_pvt_lock(fup); + ao2_lock(p); if ((*inuse > 0) && ast_test_flag(&fup->flags[0], SIP_INC_COUNT)) { (*inuse)--; ast_clear_flag(&fup->flags[0], SIP_INC_COUNT); } else { *inuse = 0; } - ast_mutex_unlock(&callctrlock); + ao2_unlock(p); + sip_pvt_unlock(fup); } /* Decrement ringing count if applicable */ if (inringing) { - ast_mutex_lock(&callctrlock); + sip_pvt_lock(fup); + ao2_lock(p); if ((*inringing > 0)&& ast_test_flag(&fup->flags[0], SIP_INC_RINGING)) { (*inringing)--; ast_clear_flag(&fup->flags[0], SIP_INC_RINGING); } else { *inringing = 0; } - ast_mutex_unlock(&callctrlock); + ao2_unlock(p); + sip_pvt_unlock(fup); } /* Decrement onhold count if applicable */ - ast_mutex_lock(&callctrlock); + sip_pvt_lock(fup); + ao2_lock(p); if (ast_test_flag(&fup->flags[1], SIP_PAGE2_CALL_ONHOLD) && global_notifyhold) { ast_clear_flag(&fup->flags[1], SIP_PAGE2_CALL_ONHOLD); - ast_mutex_unlock(&callctrlock); + ao2_unlock(p); + sip_pvt_unlock(fup); sip_peer_hold(fup, FALSE); } else { - ast_mutex_unlock(&callctrlock); + ao2_unlock(p); + sip_pvt_unlock(fup); } if (sipdebug) ast_debug(2, "Call %s %s '%s' removed from call limit %d\n", outgoing ? "to" : "from", "peer", name, *call_limit); @@ -5145,20 +5149,24 @@ static int update_call_counter(struct sip_pvt *fup, int event) } } if (inringing && (event == INC_CALL_RINGING)) { - ast_mutex_lock(&callctrlock); + sip_pvt_lock(fup); + ao2_lock(p); if (!ast_test_flag(&fup->flags[0], SIP_INC_RINGING)) { (*inringing)++; ast_set_flag(&fup->flags[0], SIP_INC_RINGING); } - ast_mutex_unlock(&callctrlock); + ao2_unlock(p); + sip_pvt_unlock(fup); } if (inuse) { - ast_mutex_lock(&callctrlock); + sip_pvt_lock(fup); + ao2_lock(p); if (!ast_test_flag(&fup->flags[0], SIP_INC_COUNT)) { (*inuse)++; ast_set_flag(&fup->flags[0], SIP_INC_COUNT); } - ast_mutex_unlock(&callctrlock); + ao2_unlock(p); + sip_pvt_unlock(fup); } if (sipdebug) { ast_debug(2, "Call %s %s '%s' is %d out of %d\n", outgoing ? "to" : "from", "peer", name, *inuse, *call_limit); @@ -5167,12 +5175,14 @@ static int update_call_counter(struct sip_pvt *fup, int event) case DEC_CALL_RINGING: if (inringing) { - ast_mutex_lock(&callctrlock); + sip_pvt_lock(fup); + ao2_lock(p); if (ast_test_flag(&fup->flags[0], SIP_INC_RINGING)) { (*inringing)--; ast_clear_flag(&fup->flags[0], SIP_INC_RINGING); } - ast_mutex_unlock(&callctrlock); + ao2_unlock(p); + sip_pvt_unlock(fup); } break; |