diff options
| author | Holger Hans Peter Freyther <zecke@selfish.org> | 2012-12-16 13:07:45 +0100 |
|---|---|---|
| committer | Holger Hans Peter Freyther <zecke@selfish.org> | 2012-12-16 13:23:11 +0100 |
| commit | 5d04481455205b781278db00825426177823b331 (patch) | |
| tree | a7e40233a99e2230187f7d25df10da6a41787c1e | |
| parent | e833478898850aad99fe5b9b1efee34e6ec1ca64 (diff) | |
mgcp: Fix the vary large jump detection in the code
GCC 3.x on PowerPC correctly highlights that the code is fishy.
Re-reading the RFC 3550 shows that we should subtract it and then
we are in the 16bit range. The probation and re-sync code is still
missing.
GCC:
mgcp/mgcp_network.c:200: warning: comparison is always true due to limited range of data type
| -rw-r--r-- | src/mgcp/mgcp_network.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mgcp/mgcp_network.c b/src/mgcp/mgcp_network.c index 3bbc600..36ef932 100644 --- a/src/mgcp/mgcp_network.c +++ b/src/mgcp/mgcp_network.c @@ -197,7 +197,7 @@ static void patch_and_count(struct mgcp_endpoint *endp, struct mgcp_rtp_state *s if (udelta < RTP_MAX_DROPOUT) { if (seq < state->max_seq) state->cycles += RTP_SEQ_MOD; - } else if (udelta <= RTP_SEQ_MOD + RTP_MAX_MISORDER) { + } else if (udelta <= RTP_SEQ_MOD - RTP_MAX_MISORDER) { LOGP(DMGCP, LOGL_NOTICE, "RTP seqno made a very large jump on 0x%x delta: %u\n", ENDPOINT_NUMBER(endp), udelta); |