aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-icmp.c
blob: bcddcc9828de1658ec4403a968e7d36f057d6744 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
/* packet-icmp.c
 * Routines for ICMP - Internet Control Message Protocol
 *
 * $Id$
 *
 * Wireshark - Network traffic analyzer
 * By Gerald Combs <gerald@wireshark.org>
 * Copyright 1998 Gerald Combs
 *
 * Monday, June 27, 2005
 * Support for the ICMP extensions for MPLS
 * (http://www.ietf.org/proceedings/01aug/I-D/draft-ietf-mpls-icmp-02.txt)
 * by   Maria-Luiza Crivat <luizacri@gmail.com>
 * &    Brice Augustin <bricecotte@gmail.com>
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 *
 * Added support for ICMP extensions RFC 4884 and RFC 5837
 * (c) 2011 Gaurav Tungatkar <gstungat@ncsu.edu>
 */

#ifdef HAVE_CONFIG_H
# include "config.h"
#endif

#include <glib.h>
#include <time.h>

#include <epan/packet.h>
#include <epan/ipproto.h>
#include <epan/prefs.h>
#include <epan/in_cksum.h>

#include "packet-ip.h"
#include "packet-icmp.h"
#include <epan/conversation.h>
#include <epan/emem.h>
#include <epan/tap.h>

static int icmp_tap = -1;

/* Conversation related data */
static int hf_icmp_resp_in = -1;
static int hf_icmp_resp_to = -1;
static int hf_icmp_resptime = -1;
static int hf_icmp_data_time = -1;
static int hf_icmp_data_time_relative = -1;

typedef struct _icmp_conv_info_t {
    emem_tree_t *pdus;
} icmp_conv_info_t;

static icmp_transaction_t *transaction_start(packet_info *pinfo, proto_tree *tree, guint32 *key);
static icmp_transaction_t *transaction_end(packet_info *pinfo, proto_tree *tree, guint32 *key);

/* Decode the end of the ICMP payload as ICMP MPLS extensions
if the packet in the payload has more than 128 bytes */
static gboolean favor_icmp_mpls_ext = FALSE;

static int proto_icmp = -1;
static int hf_icmp_type = -1;
static int hf_icmp_code = -1;
static int hf_icmp_checksum = -1;
static int hf_icmp_checksum_bad = -1;
static int hf_icmp_ident = -1;
static int hf_icmp_ident_le = -1;
static int hf_icmp_seq_num = -1;
static int hf_icmp_seq_num_le = -1;
static int hf_icmp_mtu = -1;
static int hf_icmp_redir_gw = -1;
static int hf_icmp_length = -1;

/* Mobile ip */
static int hf_icmp_mip_type = -1;
static int hf_icmp_mip_length = -1;
static int hf_icmp_mip_prefix_length = -1;
static int hf_icmp_mip_seq = -1;
static int hf_icmp_mip_life = -1;
static int hf_icmp_mip_flags = -1;
static int hf_icmp_mip_r = -1;
static int hf_icmp_mip_b = -1;
static int hf_icmp_mip_h = -1;
static int hf_icmp_mip_f = -1;
static int hf_icmp_mip_m = -1;
static int hf_icmp_mip_g = -1;
static int hf_icmp_mip_v = -1;
static int hf_icmp_mip_rt = -1;
static int hf_icmp_mip_u = -1;
static int hf_icmp_mip_x = -1;
static int hf_icmp_mip_reserved = -1;
static int hf_icmp_mip_coa = -1;
static int hf_icmp_mip_challenge = -1;

/* extensions RFC 4884*/
static int hf_icmp_ext = -1;
static int hf_icmp_ext_version = -1;
static int hf_icmp_ext_reserved = -1;
static int hf_icmp_ext_checksum = -1;
static int hf_icmp_ext_checksum_bad = -1;
static int hf_icmp_ext_length = -1;
static int hf_icmp_ext_class = -1;
static int hf_icmp_ext_c_type = -1;

/* Interface information extension RFC 5837 */
static int hf_icmp_int_info_ifindex = -1;
static int hf_icmp_int_info_ipaddr = -1;
static int hf_icmp_int_info_name = -1;
static int hf_icmp_int_info_mtu = -1;
static int hf_icmp_int_info_afi = -1;
static int hf_icmp_int_info_ipv4 = -1;
static int hf_icmp_int_info_ipv6 = -1;
static int hf_icmp_int_info_role = -1;
static int hf_icmp_int_info_reserved = -1;
static gint ett_icmp_interface_info_object = -1;
static gint ett_icmp_interface_ipaddr = -1;
static gint ett_icmp_interface_name = -1;
/* MPLS extension object*/
static int hf_icmp_mpls_label = -1;
static int hf_icmp_mpls_exp = -1;
static int hf_icmp_mpls_s = -1;
static int hf_icmp_mpls_ttl = -1;

static gint ett_icmp = -1;
static gint ett_icmp_mip = -1;
static gint ett_icmp_mip_flags = -1;

/* extensions */
static gint ett_icmp_ext = -1;
static gint ett_icmp_ext_object = -1;

/* MPLS extensions */
static gint ett_icmp_mpls_stack_object = -1;

/* ICMP definitions */

#define ICMP_ECHOREPLY     0
#define ICMP_UNREACH       3
#define ICMP_SOURCEQUENCH  4
#define ICMP_REDIRECT      5
#define ICMP_ALTHOST       6
#define ICMP_ECHO          8
#define ICMP_RTRADVERT     9
#define ICMP_RTRSOLICIT   10
#define ICMP_TIMXCEED     11
#define ICMP_PARAMPROB    12
#define ICMP_TSTAMP       13
#define ICMP_TSTAMPREPLY  14
#define ICMP_IREQ         15
#define ICMP_IREQREPLY    16
#define ICMP_MASKREQ      17
#define ICMP_MASKREPLY    18
#define ICMP_PHOTURIS     40

/* ICMP UNREACHABLE */

#define ICMP_NET_UNREACH        0       /* Network Unreachable */
#define ICMP_HOST_UNREACH       1       /* Host Unreachable */
#define ICMP_PROT_UNREACH       2       /* Protocol Unreachable */
#define ICMP_PORT_UNREACH       3       /* Port Unreachable */
#define ICMP_FRAG_NEEDED        4       /* Fragmentation Needed/DF set */
#define ICMP_SR_FAILED          5       /* Source Route failed */
#define ICMP_NET_UNKNOWN        6
#define ICMP_HOST_UNKNOWN       7
#define ICMP_HOST_ISOLATED      8
#define ICMP_NET_ANO            9
#define ICMP_HOST_ANO           10
#define ICMP_NET_UNR_TOS        11
#define ICMP_HOST_UNR_TOS       12
#define ICMP_PKT_FILTERED       13      /* Packet filtered */
#define ICMP_PREC_VIOLATION     14      /* Precedence violation */
#define ICMP_PREC_CUTOFF        15      /* Precedence cut off */

#define ICMP_MIP_EXTENSION_PAD	0
#define ICMP_MIP_MOB_AGENT_ADV	16
#define ICMP_MIP_PREFIX_LENGTHS	19
#define ICMP_MIP_CHALLENGE	24

static dissector_handle_t ip_handle;
static dissector_handle_t data_handle;

static const value_string icmp_type_str[] = {
  { ICMP_ECHOREPLY,    "Echo (ping) reply" },
  { 1,                 "Reserved" },
  { 2,                 "Reserved" },
  { ICMP_UNREACH,      "Destination unreachable" },
  { ICMP_SOURCEQUENCH, "Source quench (flow control)" },
  { ICMP_REDIRECT,     "Redirect" },
  { ICMP_ALTHOST,      "Alternate host address" },
  { ICMP_ECHO,         "Echo (ping) request" },
  { ICMP_RTRADVERT,    "Router advertisement" },
  { ICMP_RTRSOLICIT,   "Router solicitation" },
  { ICMP_TIMXCEED,     "Time-to-live exceeded" },
  { ICMP_PARAMPROB,    "Parameter problem" },
  { ICMP_TSTAMP,       "Timestamp request" },
  { ICMP_TSTAMPREPLY,  "Timestamp reply" },
  { ICMP_IREQ,         "Information request" },
  { ICMP_IREQREPLY,    "Information reply" },
  { ICMP_MASKREQ,      "Address mask request" },
  { ICMP_MASKREPLY,    "Address mask reply" },
  { 19,                "Reserved (for security)" },
  { 30,                "Traceroute" },
  { 31,                "Datagram Conversion Error" },
  { 32,                "Mobile Host Redirect" },
  { 33,                "IPv6 Where-Are-You" },
  { 34,                "IPv6 I-Am-Here" },
  { 35,                "Mobile Registration Request" },
  { 36,                "Mobile Registration Reply" },
  { 37,                "Domain Name Request" },
  { 38,                "Domain Name Reply" },
  { 39,                "SKIP" },
  { ICMP_PHOTURIS,     "Photuris" },
  { 41,                "Experimental mobility protocols" },
  { 0, NULL }
};

static const value_string unreach_code_str[] = {
  { ICMP_NET_UNREACH,    "Network unreachable" },
  { ICMP_HOST_UNREACH,   "Host unreachable" },
  { ICMP_PROT_UNREACH,   "Protocol unreachable" },
  { ICMP_PORT_UNREACH,   "Port unreachable" },
  { ICMP_FRAG_NEEDED,    "Fragmentation needed" },
  { ICMP_SR_FAILED,      "Source route failed" },
  { ICMP_NET_UNKNOWN,    "Destination network unknown" },
  { ICMP_HOST_UNKNOWN,   "Destination host unknown" },
  { ICMP_HOST_ISOLATED,  "Source host isolated" },
  { ICMP_NET_ANO,        "Network administratively prohibited" },
  { ICMP_HOST_ANO,       "Host administratively prohibited" },
  { ICMP_NET_UNR_TOS,    "Network unreachable for TOS" },
  { ICMP_HOST_UNR_TOS,   "Host unreachable for TOS" },
  { ICMP_PKT_FILTERED,   "Communication administratively filtered" },
  { ICMP_PREC_VIOLATION, "Host precedence violation" },
  { ICMP_PREC_CUTOFF,    "Precedence cutoff in effect" },
  { 0, NULL }
};

static const value_string redir_code_str[] = {
  { 0, "Redirect for network" },
  { 1, "Redirect for host" },
  { 2, "Redirect for TOS and network" },
  { 3, "Redirect for TOS and host"},
  { 0, NULL }
};

static const value_string alt_host_code_str[] = {
  { 0, "Alternate address for host" },
  { 0, NULL }
};

static const value_string rtradvert_code_str[] = {
  { 0,  "Normal router advertisement" },
  { 16, "Does not route common traffic" },
  { 0, NULL }
};

static const value_string ttl_code_str[] = {
  { 0, "Time to live exceeded in transit" },
  { 1, "Fragment reassembly time exceeded" },
  { 0, NULL }
};

static const value_string par_code_str[] = {
  { 0, "Pointer indicates the error" },
  { 1, "Required option missing" },
  { 2, "Bad length" },
  { 0, NULL }
};

static const value_string photuris_code_str[] = {
  { 0, "Bad SPI" },
  { 1, "Authentication Failed" },
  { 2, "Decompression Failed" },
  { 3, "Decryption Failed" },
  { 4, "Need Authentication" },
  { 5, "Need Authorization" },
  { 0, NULL }
};

static const value_string mip_extensions[] = {
  { ICMP_MIP_EXTENSION_PAD, "One byte padding extension"},  /* RFC 2002 */
  { ICMP_MIP_MOB_AGENT_ADV, "Mobility Agent Advertisement Extension"},
							    /* RFC 2002 */
  { ICMP_MIP_PREFIX_LENGTHS, "Prefix Lengths Extension"},   /* RFC 2002 */
  { ICMP_MIP_CHALLENGE, "Challenge Extension"},             /* RFC 3012 */
  { 0, NULL}
};

/* RFC 5837 ICMP extension - Interface Information Object
 * Interface Role
 * */
static const value_string interface_role_str[] = {
  { 0, "IP interface upon which datagram arrived"},
  { 1, "sub-IP component of an IP interface upon which datagram arrived"},
  { 2, "IP interface through which datagram would be forwarded"},
  { 3, "IP next-hop to which datagram would be forwarded"},
  { 0, NULL}
};

#define INT_INFO_INTERFACE_ROLE                 0xc0
#define INT_INFO_RESERVED                       0x30
#define INT_INFO_IFINDEX                        0x08
#define INT_INFO_IPADDR                         0x04
#define INT_INFO_NAME                           0x02
#define INT_INFO_MTU                            0x01

#define INTERFACE_INFORMATION_OBJECT_CLASS      2

#define MPLS_STACK_ENTRY_OBJECT_CLASS           1
#define MPLS_EXTENDED_PAYLOAD_OBJECT_CLASS      0   /* */

#define MPLS_STACK_ENTRY_C_TYPE                 1
#define MPLS_EXTENDED_PAYLOAD_C_TYPE            1

#define INET6_ADDRLEN                           16

static conversation_t *
_find_or_create_conversation(packet_info *pinfo)
{
    conversation_t *conv = NULL;

    /* Have we seen this conversation before? */
    conv = find_conversation(pinfo->fd->num, &pinfo->src, &pinfo->dst,
        pinfo->ptype, 0, 0, 0);
    if ( conv == NULL )
    {
        /* No, this is a new conversation. */
        conv = conversation_new(pinfo->fd->num, &pinfo->src, &pinfo->dst,
            pinfo->ptype, 0, 0, 0);
    }
    return (conv);
}

/*
 * Dissect the mobile ip advertisement extensions.
 */
static void
dissect_mip_extensions(tvbuff_t *tvb, int offset, proto_tree *tree)
{
  guint8       type;
  guint8       length;
  guint16      flags;
  proto_item   *ti;
  proto_tree   *mip_tree=NULL;
  proto_tree   *flags_tree=NULL;
  gint         numCOAs;
  gint         i;

  /* Not much to do if we're not parsing everything */
  if (!tree) return;

  while (tvb_reported_length_remaining(tvb, offset) > 0) {

	type = tvb_get_guint8(tvb, offset + 0);
	if (type)
	  length = tvb_get_guint8(tvb, offset + 1);
	else
	  length=0;

	ti = proto_tree_add_text(tree, tvb, offset,
							 type?(length + 2):1,
							 "Ext: %s",
							 val_to_str(type, mip_extensions,
										"Unknown ext %u"));
	mip_tree = proto_item_add_subtree(ti, ett_icmp_mip);


	switch (type) {
	case ICMP_MIP_EXTENSION_PAD:
	  /* One byte padding extension */
	  /* Add our fields */
	  /* type */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;
	  break;
	case ICMP_MIP_MOB_AGENT_ADV:
	  /* Mobility Agent Advertisement Extension (RFC 2002)*/
	  /* Add our fields */
	  /* type */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;
	  /* length */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_length, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;
	  /* sequence number */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_seq, tvb, offset,
						  2, ENC_BIG_ENDIAN);
	  offset+=2;
	  /* Registration Lifetime */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_life, tvb, offset,
						  2, ENC_BIG_ENDIAN);
	  offset+=2;
	  /* flags */
	  flags = tvb_get_ntohs(tvb, offset);
	  ti = proto_tree_add_uint(mip_tree, hf_icmp_mip_flags, tvb, offset, 2, flags);
	  flags_tree = proto_item_add_subtree(ti, ett_icmp_mip_flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_r, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_b, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_h, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_f, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_m, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_g, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_v, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_rt, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_u, tvb, offset, 2, flags);
	  proto_tree_add_boolean(flags_tree, hf_icmp_mip_x, tvb, offset, 2, flags);

	  /* Reserved */
	  proto_tree_add_uint(flags_tree, hf_icmp_mip_reserved, tvb, offset, 2, flags);
	  offset+=2;

	  /* COAs */
	  numCOAs = (length - 6) / 4;
	  for (i=0; i<numCOAs; i++) {
		proto_tree_add_item(mip_tree, hf_icmp_mip_coa, tvb, offset,
							4, ENC_BIG_ENDIAN);
		offset+=4;
	  }
	  break;
	case ICMP_MIP_PREFIX_LENGTHS:
	  /* Prefix-Lengths Extension  (RFC 2002)*/
	  /* Add our fields */
	  /* type */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;
	  /* length */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_length, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;

	  /* prefix lengths */
	  for(i=0; i<length; i++) {
		proto_tree_add_item(mip_tree, hf_icmp_mip_prefix_length, tvb, offset,
							1, ENC_BIG_ENDIAN);
		offset++;
	  }
	  break;
	case ICMP_MIP_CHALLENGE:
	  /* Challenge Extension  (RFC 3012)*/
	  /* type */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;
	  /* length */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_length, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;
	  /* challenge */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_challenge, tvb, offset,
						  length, ENC_NA);
	  offset+=length;

	  break;
	default:
	  /* type */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;
	  /* length */
	  proto_tree_add_item(mip_tree, hf_icmp_mip_length, tvb, offset,
						  1, ENC_BIG_ENDIAN);
	  offset++;
	  /* data, if any */
	  if (length != 0) {
	    proto_tree_add_text(mip_tree, tvb, offset, length, "Contents");
	    offset+=length;
	  }

	  break;
	} /* switch type */
  } /* end while */

} /* dissect_mip_extensions */

static gboolean
dissect_mpls_extended_payload_object(tvbuff_t *tvb, gint offset, proto_tree *ext_object_tree,
        proto_item *tf_object)
{

    guint16         obj_length, obj_trunc_length;
    gboolean        unknown_object;
    guint8          c_type;
    unknown_object  = FALSE;
    /* Object length */
    obj_length = tvb_get_ntohs(tvb, offset);

    obj_trunc_length =  MIN(obj_length, tvb_reported_length_remaining(tvb, offset));

    /* C-Type */
    c_type = tvb_get_guint8(tvb, offset + 3);
    proto_tree_add_uint(ext_object_tree, hf_icmp_ext_c_type, tvb, offset + 3, 1, c_type);

    /* skip the object header */
    offset += 4;

    switch (c_type)
    {
        case MPLS_EXTENDED_PAYLOAD_C_TYPE:
            proto_item_set_text(tf_object, "Extended Payload");

            /* This object contains some portion of the original packet
               that could not fit in the 128 bytes of the ICMP payload */
            if (obj_trunc_length > 4)
                proto_tree_add_text(ext_object_tree, tvb,
                        offset, obj_trunc_length - 4,
                        "Data (%d bytes)", obj_trunc_length - 4);

            break;
        default:

            unknown_object = TRUE;

            break;
    } /* end switch c_type */
    return unknown_object;
}
static gboolean
dissect_mpls_stack_entry_object(tvbuff_t *tvb, gint offset, proto_tree *ext_object_tree,
                proto_item *tf_object)
{

    proto_item      *tf_entry;
    proto_tree      *mpls_stack_object_tree;
    guint16         obj_length, obj_trunc_length;
    gint            obj_end_offset;
    guint           label;
    guint8          ttl;
    guint8          tmp;
    gboolean        unknown_object;
    guint8          c_type;
    unknown_object  = FALSE;
    /* Object length */
    obj_length = tvb_get_ntohs(tvb, offset);

    obj_trunc_length =  MIN(obj_length, tvb_reported_length_remaining(tvb, offset));
    obj_end_offset = offset + obj_trunc_length;
    /* C-Type */
    c_type = tvb_get_guint8(tvb, offset + 3);
    proto_tree_add_uint(ext_object_tree, hf_icmp_ext_c_type, tvb, offset + 3, 1, c_type);

    /* skip the object header */
    offset += 4;

    switch (c_type)
    {
        case MPLS_STACK_ENTRY_C_TYPE:

            proto_item_set_text(tf_object, "MPLS Stack Entry");
            /* For each entry */
            while (offset + 4 <= obj_end_offset)
            {
                if (tvb_reported_length_remaining(tvb, offset) < 4)
                {
                    /* Not enough room in the packet ! */
                    break;
                }

                /* Create a subtree for each entry (the text will be set later) */
                tf_entry = proto_tree_add_text(ext_object_tree,
                        tvb, offset, 4, " ");
                mpls_stack_object_tree = proto_item_add_subtree(tf_entry,
                        ett_icmp_mpls_stack_object);

                /* Label */
                label =  (guint)tvb_get_ntohs(tvb, offset);
                tmp = tvb_get_guint8(tvb, offset + 2);
                label = (label << 4) + (tmp >> 4);

                proto_tree_add_uint(mpls_stack_object_tree,
                        hf_icmp_mpls_label,
                        tvb,
                        offset,
                        3,
                        label << 4);

                proto_item_set_text(tf_entry, "Label: %u", label);

                /* Experimental field (also called "CoS") */
                proto_tree_add_uint(mpls_stack_object_tree,
                        hf_icmp_mpls_exp,
                        tvb,
                        offset + 2,
                        1,
                        tmp);

                proto_item_append_text(tf_entry, ", Exp: %u", (tmp >> 1) & 0x07);

                /* Stack bit */
                proto_tree_add_boolean(mpls_stack_object_tree,
                        hf_icmp_mpls_s,
                        tvb,
                        offset + 2,
                        1,
                        tmp);

                proto_item_append_text(tf_entry, ", S: %u", tmp  & 0x01);

                /* TTL */
                ttl = tvb_get_guint8(tvb, offset + 3);

                proto_tree_add_item(mpls_stack_object_tree,
                        hf_icmp_mpls_ttl,
                        tvb,
                        offset + 3,
                        1,
                        ENC_BIG_ENDIAN);

                proto_item_append_text(tf_entry, ", TTL: %u", ttl);

                /* Skip the entry */
                offset += 4;

            } /* end while */

            if (offset < obj_end_offset)
                proto_tree_add_text(ext_object_tree, tvb,
                        offset,
                        obj_end_offset - offset,
                        "%d junk bytes",
                        obj_end_offset - offset);
            break;

        default:

            unknown_object = TRUE;

            break;
    } /* end switch c_type */
    return unknown_object;

} /* end dissect_mpls_stack_entry_object*/

/* Dissect Interface Information Object RFC 5837*/
static gboolean
dissect_interface_information_object(tvbuff_t *tvb, gint offset, proto_tree *ext_object_tree,
        proto_item *tf_object)
{
    proto_item      *ti;
    proto_tree      *int_name_object_tree = NULL;
    proto_tree      *int_ipaddr_object_tree;
    guint16         obj_length, obj_trunc_length;
    gint            obj_end_offset;
    guint8          c_type;
    gboolean        unknown_object;
    guint8          if_index_flag;
    guint8          ipaddr_flag;
    guint8          name_flag;
    guint32         if_index;
    guint16         afi;
    struct e_in6_addr ipaddr_v6;
    guint8          int_name_length = 0;

    unknown_object  = FALSE;
    /* Object length */
    obj_length = tvb_get_ntohs(tvb, offset);

    obj_trunc_length =  MIN(obj_length, tvb_reported_length_remaining(tvb, offset));
    obj_end_offset = offset + obj_trunc_length;

    /* C-Type */
    c_type = tvb_get_guint8(tvb, offset + 3);

    proto_item_set_text(tf_object, "Interface Information Object");
    if (tvb_reported_length_remaining(tvb, offset) < 4)
    {
        /* Not enough room in the packet ! return unknown_object = TRUE*/
        return TRUE;
    }

    if_index_flag  = (c_type & INT_INFO_IFINDEX) >> 3;
    ipaddr_flag    = (c_type & INT_INFO_IPADDR) >> 2;
    name_flag      = (c_type & INT_INFO_NAME) >> 1;

    {
        static const gint *c_type_fields[] = {
            &hf_icmp_int_info_role,
            &hf_icmp_int_info_reserved,
            &hf_icmp_int_info_ifindex,
            &hf_icmp_int_info_ipaddr,
            &hf_icmp_int_info_name,
            &hf_icmp_int_info_mtu,
            NULL
        };
        proto_tree_add_bitmask(ext_object_tree, tvb, offset + 3,  hf_icmp_ext_c_type,
             ett_icmp_interface_info_object, c_type_fields, ENC_BIG_ENDIAN);
    }

    /* skip header */
    offset += 4;

    /*if ifIndex is set, next 32 bits are ifIndex */
    if(if_index_flag)
    {
        if(obj_end_offset >= offset + 4)
        {
            if_index = tvb_get_ntohl(tvb, offset);
            proto_tree_add_text(ext_object_tree,
                    tvb, offset, 4, "Interface Index: %u", if_index);
            offset += 4;
        }
        else
        {
            proto_tree_add_text(ext_object_tree,
                    tvb, offset, 4, "Interface Index:(truncated)");
            return FALSE;
        }
    }

    /* IP Address Sub Object */
    if(ipaddr_flag && (obj_end_offset >= offset + 2))
    {
        /* Address Family Identifier*/
        afi = tvb_get_ntohs(tvb, offset);

        /*
         * if afi = 1, IPv4 address, 2 bytes afi, 2 bytes rsvd, 4 bytes IP addr
         * if afi = 2, IPv6 address, 2 bytes afi, 2 bytes rsvd, 6 bytes IP addr
         */
        ti = proto_tree_add_text(ext_object_tree, tvb, offset,
                                        afi==1?8:10,
                                        "IP Address Sub-Object");

        int_ipaddr_object_tree = proto_item_add_subtree(ti, ett_icmp_interface_ipaddr);

        proto_tree_add_uint(int_ipaddr_object_tree, hf_icmp_int_info_afi,
            tvb, offset, 2, afi);

        /* skip reserved*/
        offset += 4;
        if(afi == 1 && (obj_end_offset >= offset + 4))
        {
            proto_tree_add_ipv4(int_ipaddr_object_tree, hf_icmp_int_info_ipv4, tvb, offset, 4, tvb_get_ntohl(tvb,offset));
            offset += 4;
        }
        else if (afi == 2 && (obj_end_offset >= offset + INET6_ADDRLEN))
        {
             tvb_get_ipv6(tvb, offset, &ipaddr_v6);
             proto_tree_add_ipv6(int_ipaddr_object_tree, hf_icmp_int_info_ipv6, tvb, offset,
                 INET6_ADDRLEN, (guint8 *)&ipaddr_v6);
             offset += INET6_ADDRLEN;
        }
        else
        {
            proto_tree_add_text(int_ipaddr_object_tree, tvb, offset, offset - obj_end_offset, "Bad IP Address");
            return FALSE;
        }

    }

    /* Interface Name Sub Object*/
    if(name_flag)
    {
        if(obj_end_offset >= offset + 1)
        {
            int_name_length = tvb_get_guint8(tvb, offset);
            ti = proto_tree_add_text(ext_object_tree, tvb, offset,
                    int_name_length,
                    "Interface Name Sub-Object");

            int_name_object_tree = proto_item_add_subtree(ti, ett_icmp_interface_name);
            proto_tree_add_text(int_name_object_tree, tvb, offset, 1, "Length: %u", int_name_length);
        }
        if(obj_end_offset >= offset + 1 + int_name_length)
        {

            proto_tree_add_text(int_name_object_tree, tvb, offset + 1, int_name_length,  "Interface Name: %s",
                    (const guchar *)tvb_get_ptr(tvb, offset+1, int_name_length));
        }
    }


    return unknown_object;

} /*end dissect_interface_information_object*/

static void
dissect_extensions(tvbuff_t *tvb, gint offset, proto_tree *tree)
{
    guint8          version;
    guint8          class_num;
    guint8          c_type;
    guint16         reserved;
    guint16         cksum, computed_cksum;
    guint16         obj_length, obj_trunc_length;
    proto_item      *ti, *tf_object,*hidden_item;
    proto_tree      *ext_tree, *ext_object_tree;
    gint            obj_end_offset;
    guint           reported_length;
    gboolean        unknown_object;
    guint8          int_info_obj_count;
    if (!tree)
        return;

    ext_tree = NULL;
    int_info_obj_count = 0;

    reported_length = tvb_reported_length_remaining(tvb, offset);

    if (reported_length < 4 /* Common header */)
    {
        proto_tree_add_text(tree, tvb, offset,
                            reported_length,
                            "ICMP Multi-Part Extensions (truncated)");
        return;
    }

    /* Add a tree for multi-part extensions RFC 4884*/
    ti = proto_tree_add_none_format(tree, hf_icmp_ext, tvb,
                                            offset, reported_length, "ICMP Multi-Part Extensions");

    ext_tree = proto_item_add_subtree(ti, ett_icmp_ext);

    /* Version */
    version = hi_nibble(tvb_get_guint8(tvb, offset));
    proto_tree_add_uint(ext_tree, hf_icmp_ext_version, tvb, offset, 1, version);

    /* Reserved */
    reserved = tvb_get_ntohs(tvb, offset) & 0x0fff;
    proto_tree_add_uint_format(ext_tree, hf_icmp_ext_reserved,
                                tvb, offset, 2, reserved,
                                "Reserved: 0x%03x", reserved);

    /* Checksum */
    cksum = tvb_get_ntohs(tvb, offset + 2);

    computed_cksum = ip_checksum(tvb_get_ptr(tvb, offset, reported_length),
                                    reported_length);

    if (computed_cksum == 0)
    {
        proto_tree_add_uint_format(ext_tree, hf_icmp_ext_checksum, tvb, offset + 2, 2,
                                    cksum, "Checksum: 0x%04x [correct]", cksum);
    }
    else
    {
        hidden_item = proto_tree_add_boolean(ext_tree, hf_icmp_ext_checksum_bad, tvb,
                                            offset + 2, 2, TRUE);
        PROTO_ITEM_SET_HIDDEN(hidden_item);

        proto_tree_add_uint_format(ext_tree, hf_icmp_ext_checksum, tvb, offset + 2, 2,
                                    cksum,
                                    "Checksum: 0x%04x [incorrect, should be 0x%04x]",
                                    cksum, in_cksum_shouldbe(cksum, computed_cksum));
    }

    if (version != 1 && version != 2)
    {
        /* Unsupported version */
        proto_item_append_text(ti, " (unsupported version)");
        return;
    }

    /* Skip the common header */
    offset += 4;

    /* While there is enough room to read an object */
    while (tvb_reported_length_remaining(tvb, offset) >= 4 /* Object header */)
    {
        /* Object length */
        obj_length = tvb_get_ntohs(tvb, offset);

        obj_trunc_length =  MIN(obj_length, tvb_reported_length_remaining(tvb, offset));

        obj_end_offset = offset + obj_trunc_length;

        /* Add a subtree for this object (the text will be reset later) */
        tf_object = proto_tree_add_text(ext_tree, tvb, offset,
                                        MAX(obj_trunc_length, 4),
                                        "Unknown object");

        ext_object_tree = proto_item_add_subtree(tf_object, ett_icmp_ext_object);

        proto_tree_add_uint(ext_object_tree, hf_icmp_ext_length, tvb, offset, 2, obj_length);

        /* Class */
        class_num = tvb_get_guint8(tvb, offset + 2);
        proto_tree_add_uint(ext_object_tree, hf_icmp_ext_class, tvb, offset + 2, 1, class_num);

        /* C-Type */
        c_type = tvb_get_guint8(tvb, offset + 3);

        if (obj_length < 4 /* Object header */)
        {
            /* Thanks doc/README.developer :)) */
            proto_item_set_text(tf_object, "Object with bad length");
            break;
        }


        switch (class_num)
        {
            case MPLS_STACK_ENTRY_OBJECT_CLASS:
                unknown_object = dissect_mpls_stack_entry_object(tvb, offset, ext_object_tree, tf_object);
                break;
            case INTERFACE_INFORMATION_OBJECT_CLASS:
                unknown_object = dissect_interface_information_object(tvb, offset, ext_object_tree, tf_object);
                int_info_obj_count++;
                if(int_info_obj_count > 4)
                {
                    proto_item_set_text(tf_object, "More than 4 Interface Information Objects");
                }
                break;
            case MPLS_EXTENDED_PAYLOAD_OBJECT_CLASS:
                unknown_object = dissect_mpls_extended_payload_object(tvb, offset, ext_object_tree, tf_object);
                break;
            default:

                unknown_object = TRUE;

                break;
        } /* end switch class_num */

        /* Skip the object header */
        offset += 4;

        /* The switches couldn't decode the object */
        if (unknown_object == TRUE)
        {
            proto_item_set_text(tf_object, "Unknown object (%d/%d)", class_num, c_type);

            if (obj_trunc_length > 4)
                proto_tree_add_text(ext_object_tree, tvb,
                                    offset, obj_trunc_length - 4,
                                    "Data (%d bytes)", obj_trunc_length - 4);
        }

        /* */
        if (obj_trunc_length < obj_length)
            proto_item_append_text(tf_object, " (truncated)");

        /* Go to the end of the object */
        offset = obj_end_offset;

    } /* end while */
} /* end dissect_extensions */
/* ======================================================================= */
static icmp_transaction_t *transaction_start(packet_info *pinfo, proto_tree *tree, guint32 *key)
{
    conversation_t *conversation;
    icmp_conv_info_t *icmp_info;
    icmp_transaction_t *icmp_trans;
    emem_tree_key_t icmp_key[2];
    proto_item *it;

    /* Handle the conversation tracking */
    conversation = _find_or_create_conversation(pinfo);
    icmp_info = conversation_get_proto_data(conversation, proto_icmp);
    if ( icmp_info == NULL )
    {
        icmp_info = se_alloc(sizeof(icmp_conv_info_t));
        icmp_info->pdus = se_tree_create_non_persistent(
            EMEM_TREE_TYPE_RED_BLACK, "icmp_pdus");
        conversation_add_proto_data(conversation, proto_icmp, icmp_info);
    }

    icmp_key[0].length = 2;
    icmp_key[0].key = key;
    icmp_key[1].length = 0;
    icmp_key[1].key = NULL;
    if ( !PINFO_FD_VISITED(pinfo) )
    {
        icmp_trans = se_alloc(sizeof(icmp_transaction_t));
        icmp_trans->rqst_frame = PINFO_FD_NUM(pinfo);
        icmp_trans->resp_frame = 0;
        icmp_trans->rqst_time = pinfo->fd->abs_ts;
        nstime_set_zero(&icmp_trans->resp_time);
        se_tree_insert32_array(icmp_info->pdus, icmp_key, (void *)icmp_trans);
    }
    else /* Already visited this frame */
        icmp_trans = se_tree_lookup32_array(icmp_info->pdus, icmp_key);

    if ( icmp_trans == NULL )
        return (NULL);

    /* Print state tracking in the tree */
    if ( icmp_trans->resp_frame &&
        (icmp_trans->rqst_frame == PINFO_FD_NUM(pinfo)) )
    {
        it = proto_tree_add_uint(tree, hf_icmp_resp_in, NULL, 0, 0,
            icmp_trans->resp_frame);
        PROTO_ITEM_SET_GENERATED(it);
    }

    return (icmp_trans);

} /* transaction_start() */

/* ======================================================================= */
static icmp_transaction_t *transaction_end(packet_info *pinfo, proto_tree *tree, guint32 *key)
{
    conversation_t *conversation;
    icmp_conv_info_t *icmp_info;
    icmp_transaction_t *icmp_trans;
    emem_tree_key_t icmp_key[2];
    proto_item *it;
    nstime_t ns;
    double resp_time;

    conversation = find_conversation(pinfo->fd->num, &pinfo->src, &pinfo->dst,
        pinfo->ptype, 0, 0, 0);
    if ( conversation == NULL )
        return (NULL);

    icmp_info = conversation_get_proto_data(conversation, proto_icmp);
    if ( icmp_info == NULL )
        return (NULL);

    icmp_key[0].length = 2;
    icmp_key[0].key = key;
    icmp_key[1].length = 0;
    icmp_key[1].key = NULL;
    icmp_trans = se_tree_lookup32_array(icmp_info->pdus, icmp_key);
    if ( icmp_trans == NULL )
        return (NULL);

    /* Print state tracking in the tree */
    if ( icmp_trans->rqst_frame &&
        (icmp_trans->rqst_frame < PINFO_FD_NUM(pinfo)) &&
        ((icmp_trans->resp_frame == 0) ||
        (icmp_trans->resp_frame == PINFO_FD_NUM(pinfo))) )
    {
        icmp_trans->resp_frame = PINFO_FD_NUM(pinfo);
        it = proto_tree_add_uint(tree, hf_icmp_resp_to, NULL, 0, 0,
            icmp_trans->rqst_frame);
        PROTO_ITEM_SET_GENERATED(it);

        nstime_delta(&ns, &pinfo->fd->abs_ts, &icmp_trans->rqst_time);
        icmp_trans->resp_time = ns;
        resp_time = nstime_to_msec(&ns);
        it = proto_tree_add_double_format_value(tree, hf_icmp_resptime, NULL,
            0, 0, resp_time, "%.3f ms", resp_time);
        PROTO_ITEM_SET_GENERATED(it);
    }

    return (icmp_trans);

} /* transaction_end() */

#define MSPERDAY            86400000

/* ======================================================================= */
static guint32 get_best_guess_mstimeofday(tvbuff_t *tvb, gint offset, guint32 comp_ts)
{
    guint32 be_ts, le_ts;

    /* Account for the special case from RFC 792 as best we can by clearing
     * the msb.  Ref: [Page 16] of http://tools.ietf.org/html/rfc792:

        If the time is not available in milliseconds or cannot be provided
        with respect to midnight UT then any time can be inserted in a
        timestamp provided the high order bit of the timestamp is also set
        to indicate this non-standard value.
     */
    be_ts = tvb_get_ntohl(tvb, offset) & 0x7fffffff;
    le_ts = tvb_get_letohl(tvb, offset) & 0x7fffffff;

    if (be_ts < MSPERDAY && le_ts >= MSPERDAY)
        return (be_ts);

    if (le_ts < MSPERDAY && be_ts >= MSPERDAY)
        return (le_ts);

    if (be_ts < MSPERDAY && le_ts < MSPERDAY) {
        guint32 saved_be_ts = be_ts;
        guint32 saved_le_ts = le_ts;

        /* Is this a rollover to a new day, clocks not synchronized, different
         * timezones between originate and receive/transmit, .. what??? */
        if (be_ts < comp_ts && be_ts <= (MSPERDAY / 4) && comp_ts >= (MSPERDAY - (MSPERDAY / 4)))
            be_ts += MSPERDAY;  /* Assume a rollover to a new day */
        if (le_ts < comp_ts && le_ts <= (MSPERDAY / 4) && comp_ts >= (MSPERDAY - (MSPERDAY / 4)))
            le_ts += MSPERDAY;  /* Assume a rollover to a new day */
        if (abs(be_ts - comp_ts) < abs(le_ts - comp_ts))
            return (saved_be_ts);
        return (saved_le_ts);
    }

    /* Both are bigger than MSPERDAY, but neither one's msb's are set.  This
     * is clearly invalid, but now what TODO?  For now, take the one closest to
     * the comparative timestamp, which is another way of saying, "let's
     * return a deterministic wild guess. */
    if (abs(be_ts - comp_ts) < abs(le_ts - comp_ts))
        return (be_ts);
    return (le_ts);
} /* get_best_guess_mstimeofday() */

/*
 * RFC 792 for basic ICMP.
 * RFC 1191 for ICMP_FRAG_NEEDED (with MTU of next hop).
 * RFC 1256 for router discovery messages.
 * RFC 2002 and 3012 for Mobile IP stuff.
 */
static void
dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
{
  proto_tree *icmp_tree = NULL;
  proto_item *ti;
  guint8     icmp_type;
  guint8     icmp_code;
  guint8     icmp_original_dgram_length;
  guint      length, reported_length;
  guint16    cksum, computed_cksum;
  const gchar *type_str, *code_str;
  guint8     num_addrs = 0;
  guint8     addr_entry_size = 0;
  int        i;
  gboolean   save_in_error_pkt;
  tvbuff_t   *next_tvb;
  proto_item *item;
  guint32 conv_key[2];
  icmp_transaction_t *trans = NULL;
  nstime_t   ts,time_relative;

  col_set_str(pinfo->cinfo, COL_PROTOCOL, "ICMP");
  col_clear(pinfo->cinfo, COL_INFO);

  /* To do: check for runts, errs, etc. */
  icmp_type = tvb_get_guint8(tvb, 0);
  icmp_code = tvb_get_guint8(tvb, 1);
  cksum = tvb_get_ntohs(tvb, 2);
  /*length of original datagram carried in the ICMP payload. In terms of 32 bit
   * words.*/
  icmp_original_dgram_length = tvb_get_guint8(tvb, 5);

  type_str = val_to_str_const (icmp_type, icmp_type_str, "Unknown ICMP (obsolete or malformed?)");

  switch (icmp_type) {
    case ICMP_UNREACH:
      code_str = val_to_str (icmp_code, unreach_code_str, "Unknown code: %u");
      break;
    case ICMP_REDIRECT:
      code_str = val_to_str (icmp_code, redir_code_str, "Unknown code: %u");
      break;
    case ICMP_ALTHOST:
      code_str = val_to_str (icmp_code, alt_host_code_str, "Unknown code: %u");
      break;
    case ICMP_RTRADVERT:
      switch (icmp_code) {
      case 0: /* Mobile-Ip */
      case 16: /* Mobile-Ip */
        type_str = "Mobile IP Advertisement";
        break;
      } /* switch icmp_code */
      code_str = val_to_str (icmp_code, rtradvert_code_str, "Unknown code: %u");
      break;
    case ICMP_TIMXCEED:
      code_str = val_to_str (icmp_code, ttl_code_str, "Unknown code: %u");
      break;
    case ICMP_PARAMPROB:
      code_str = val_to_str (icmp_code, par_code_str, "Unknown code: %u");
      break;
    case ICMP_PHOTURIS:
      code_str = val_to_str (icmp_code, photuris_code_str, "Unknown code: %u");
      break;
    default:
      code_str = NULL;
      break;
  }

  col_add_fstr(pinfo->cinfo, COL_INFO, "%-20s", type_str);
  if (code_str)
    col_append_fstr(pinfo->cinfo, COL_INFO, " (%s)", code_str);

  length = tvb_length(tvb);
  reported_length = tvb_reported_length(tvb);

  ti = proto_tree_add_item(tree, proto_icmp, tvb, 0, length, ENC_NA);
  icmp_tree = proto_item_add_subtree(ti, ett_icmp);

  ti = proto_tree_add_item(icmp_tree, hf_icmp_type, tvb, 0, 1, ENC_BIG_ENDIAN);
  proto_item_append_text (ti, " (%s)", type_str);

  ti = proto_tree_add_item(icmp_tree, hf_icmp_code, tvb, 1, 1, ENC_BIG_ENDIAN);
  if (code_str)
    proto_item_append_text (ti, " (%s)", code_str);

  if (!pinfo->fragmented && length >= reported_length && !pinfo->flags.in_error_pkt) {
    /* The packet isn't part of a fragmented datagram, isn't
       truncated, and isn't the payload of an error packet, so we can checksum
       it. */

    computed_cksum = ip_checksum(tvb_get_ptr(tvb, 0, reported_length),
				 reported_length);
    if (computed_cksum == 0) {
      proto_tree_add_uint_format(icmp_tree, hf_icmp_checksum, tvb, 2, 2,
				 cksum,
				 "Checksum: 0x%04x [correct]", cksum);
    } else {
      item = proto_tree_add_boolean(icmp_tree, hf_icmp_checksum_bad,
				    tvb, 2, 2, TRUE);
      PROTO_ITEM_SET_HIDDEN(item);
      proto_tree_add_uint_format(icmp_tree, hf_icmp_checksum, tvb, 2, 2,
				 cksum,
				 "Checksum: 0x%04x [incorrect, should be 0x%04x]",
				 cksum, in_cksum_shouldbe(cksum, computed_cksum));
    }
  } else {
    proto_tree_add_uint(icmp_tree, hf_icmp_checksum, tvb, 2, 2, cksum);
  }

  /* Decode the second 4 bytes of the packet. */
  switch (icmp_type) {
      case ICMP_ECHOREPLY:
      case ICMP_ECHO:
      case ICMP_TSTAMP:
      case ICMP_TSTAMPREPLY:
      case ICMP_IREQ:
      case ICMP_IREQREPLY:
      case ICMP_MASKREQ:
      case ICMP_MASKREPLY:
        proto_tree_add_item(icmp_tree, hf_icmp_ident, tvb, 4, 2,
			    ENC_BIG_ENDIAN);
        proto_tree_add_item(icmp_tree, hf_icmp_ident_le, tvb, 4, 2,
			    ENC_LITTLE_ENDIAN);
        proto_tree_add_item(icmp_tree, hf_icmp_seq_num, tvb, 6, 2,
			    ENC_BIG_ENDIAN);
        proto_tree_add_item(icmp_tree, hf_icmp_seq_num_le, tvb, 6, 2,
			    ENC_LITTLE_ENDIAN);
        col_append_fstr(pinfo->cinfo, COL_INFO,
            " id=0x%04x, seq=%u/%u, ttl=%u", tvb_get_ntohs(tvb, 4),
            tvb_get_ntohs(tvb, 6), tvb_get_letohs(tvb, 6), pinfo->ip_ttl);
	break;

      case ICMP_UNREACH:

        /* If icmp_original_dgram_length > 0, then this packet is compliant with RFC 4884 and
         * interpret the 6th octet as length of the original datagram
         */
        if(icmp_original_dgram_length > 0){
          ti = proto_tree_add_item(icmp_tree, hf_icmp_length, tvb, 5, 1, ENC_BIG_ENDIAN);
          proto_item_append_text (ti, "Length of original datagram: %u", icmp_original_dgram_length*4);
        }


        switch (icmp_code) {
          case ICMP_FRAG_NEEDED:
            proto_tree_add_item(icmp_tree, hf_icmp_mtu, tvb, 6, 2, ENC_BIG_ENDIAN);
            break;
	}
        break;

      case ICMP_RTRADVERT:
        num_addrs = tvb_get_guint8(tvb, 4);
	proto_tree_add_text(icmp_tree, tvb, 4, 1, "Number of addresses: %u",
	  num_addrs);
	addr_entry_size = tvb_get_guint8(tvb, 5);
	proto_tree_add_text(icmp_tree, tvb, 5, 1, "Address entry size: %u",
	  addr_entry_size);
	proto_tree_add_text(icmp_tree, tvb, 6, 2, "Lifetime: %s",
	  time_secs_to_str(tvb_get_ntohs(tvb, 6)));
	break;

      case ICMP_PARAMPROB:
	proto_tree_add_text(icmp_tree, tvb, 4, 1, "Pointer: %u",
	  tvb_get_guint8(tvb, 4));
        if(icmp_original_dgram_length > 0){
          ti = proto_tree_add_item(icmp_tree, hf_icmp_length, tvb, 5, 1, ENC_BIG_ENDIAN);
          proto_item_append_text (ti, " Length of original datagram: %u", icmp_original_dgram_length*4);
        }
	break;

      case ICMP_REDIRECT:
        proto_tree_add_item(icmp_tree, hf_icmp_redir_gw, tvb, 4, 4, ENC_BIG_ENDIAN);
	break;

      case ICMP_TIMXCEED:
        if(icmp_original_dgram_length > 0){
          ti = proto_tree_add_item(icmp_tree, hf_icmp_length, tvb, 5, 1, ENC_BIG_ENDIAN);
          proto_item_append_text (ti, " Length of original datagram: %u", icmp_original_dgram_length*4);
        }
  }

  /* Decode the additional information in the packet.  */
  switch (icmp_type) {
      case ICMP_UNREACH:
      case ICMP_TIMXCEED:
      case ICMP_PARAMPROB:
      case ICMP_SOURCEQUENCH:
      case ICMP_REDIRECT:
	/* Save the current value of the "we're inside an error packet"
	   flag, and set that flag; subdissectors may treat packets
	   that are the payload of error packets differently from
	   "real" packets. */
	save_in_error_pkt = pinfo->flags.in_error_pkt;
	pinfo->flags.in_error_pkt = TRUE;

	/* Decode the IP header and first 64 bits of data from the
	   original datagram. */
	next_tvb = tvb_new_subset_remaining(tvb, 8);

    /* If the packet is compliant with RFC 4884, then it has
     * icmp_original_dgram_length*4 bytes of original IP packet that needs
     * to be decoded, followed by extension objects.
     */
    if (icmp_original_dgram_length && (tvb_reported_length(tvb) > (guint)( 8 +
                icmp_original_dgram_length*4)) && (tvb_get_ntohs(tvb, 8 + 2) >
                    (guint)icmp_original_dgram_length*4))
        set_actual_length(next_tvb, icmp_original_dgram_length*4);

    else
        /* There is a collision between RFC 1812 and draft-ietf-mpls-icmp-02.
           We don't know how to decode the 128th and following bytes of the ICMP payload.
           According to draft-ietf-mpls-icmp-02, these bytes should be decoded as MPLS extensions
           whereas RFC 1812 tells us to decode them as a portion of the original packet.
           Let the user decide.

           Here the user decided to favor MPLS extensions.
           Force the IP dissector to decode only the first 128 bytes. */
        if ((tvb_reported_length(tvb) > 8 + 128) &&
                favor_icmp_mpls_ext && (tvb_get_ntohs(tvb, 8 + 2) > 128))
            set_actual_length(next_tvb, 128);


	call_dissector(ip_handle, next_tvb, pinfo, icmp_tree);

	/* Restore the "we're inside an error packet" flag. */
	pinfo->flags.in_error_pkt = save_in_error_pkt;

	/* Decode MPLS extensions if the payload has at least 128 bytes, and
		- the original packet in the ICMP payload has less than 128 bytes, or
		- the user favors the MPLS extensions analysis */
	if ((tvb_reported_length(tvb) > 8 + 128)
			&& (tvb_get_ntohs(tvb, 8 + 2) <= 128 || favor_icmp_mpls_ext))
		dissect_extensions(tvb, 8 + 128, icmp_tree);

	break;

      case ICMP_ECHOREPLY:
      case ICMP_ECHO:
          if ( icmp_type == ICMP_ECHOREPLY ) {
            if ( !pinfo->flags.in_error_pkt ) {
              conv_key[0] = (guint32)tvb_get_ntohs(tvb, 2);
              if (pinfo->flags.in_gre_pkt)
                conv_key[0] |= 0x00010000; /* set a bit for "in GRE" */
              conv_key[1] = (guint32)((tvb_get_ntohs(tvb, 4) << 16) |
                tvb_get_ntohs(tvb, 6));
              trans = transaction_end(pinfo, icmp_tree, conv_key);
            }
          } else {
            if ( !pinfo->flags.in_error_pkt ) {
              guint16 tmp[2];

              tmp[0] = ~tvb_get_ntohs(tvb, 2);
              tmp[1] = ~0x0800; /* The difference between echo request & reply */
              conv_key[0] = ip_checksum((guint8 *)&tmp, sizeof(tmp));
              if (pinfo->flags.in_gre_pkt)
                conv_key[0] |= 0x00010000; /* set a bit for "in GRE" */
              conv_key[1] = (guint32)((tvb_get_ntohs(tvb, 4) << 16) |
                tvb_get_ntohs(tvb, 6));
              trans = transaction_start(pinfo, icmp_tree, conv_key);
            }
          }

          /* Make sure we have enough bytes in the payload before trying to
           * see if the data looks like a timestamp; otherwise we'll get
           * malformed packets as we try to access data that isn't there. */
          if (tvb_length_remaining(tvb, 8) < 8) {
            call_dissector(data_handle, tvb_new_subset_remaining(tvb, 8),
              pinfo, icmp_tree);
            break;
          }

          /* Interpret the first 8 bytes of the icmp data as a timestamp
           * But only if it does look like it's a timestamp.
           *
           * FIXME:
           *    Timestamps could be in different formats depending on the OS
           */
          ts.secs  = tvb_get_ntohl(tvb,8);
          ts.nsecs = tvb_get_ntohl(tvb,8+4); /* Leave at microsec resolution for now */
          if (abs((guint32)(ts.secs - pinfo->fd->abs_ts.secs))>=3600*24 ||
              ts.nsecs >= 1000000) {
            /* Timestamp does not look right in BE, try LE representation */
            ts.secs  = tvb_get_letohl(tvb,8);
            ts.nsecs = tvb_get_letohl(tvb,8+4); /* Leave at microsec resolution for now */
          }
          if (abs((guint32)(ts.secs - pinfo->fd->abs_ts.secs))<3600*24 &&
              ts.nsecs < 1000000) {
            ts.nsecs *= 1000; /* Convert to nanosec resolution */
            proto_tree_add_time(icmp_tree, hf_icmp_data_time, tvb, 8, 8, &ts);
            nstime_delta(&time_relative, &pinfo->fd->abs_ts, &ts);
            ti = proto_tree_add_time(icmp_tree, hf_icmp_data_time_relative, tvb,
                                     8, 8, &time_relative);
            PROTO_ITEM_SET_GENERATED(ti);
            call_dissector(data_handle, tvb_new_subset_remaining(tvb, 8+8), pinfo,
              icmp_tree);
          } else {
            call_dissector(data_handle, tvb_new_subset_remaining(tvb, 8), pinfo,
              icmp_tree);
          }
        break;

      case ICMP_RTRADVERT:
        if (addr_entry_size == 2) {
	  for (i = 0; i < num_addrs; i++) {
	    proto_tree_add_text(icmp_tree, tvb, 8 + (i*8), 4,
	      "Router address: %s", tvb_ip_to_str(tvb, 8 + (i*8)));
	    proto_tree_add_text(icmp_tree, tvb, 12 + (i*8), 4,
	      "Preference level: %d", tvb_get_ntohl(tvb, 12 + (i*8)));
	  }
	  if ((icmp_code == 0) || (icmp_code == 16)) {
		/* Mobile-Ip */
		dissect_mip_extensions(tvb, 8 + i*8, icmp_tree);
	  }
	} else
	  call_dissector(data_handle, tvb_new_subset_remaining(tvb, 8), pinfo,
	                 icmp_tree);
	break;

      case ICMP_TSTAMP:
      case ICMP_TSTAMPREPLY:
      {
        guint32 frame_ts, orig_ts;

        frame_ts = ((pinfo->fd->abs_ts.secs * 1000) +
          (pinfo->fd->abs_ts.nsecs / 1000000)) % 86400000;

        orig_ts = get_best_guess_mstimeofday(tvb, 8, frame_ts);
        proto_tree_add_text(icmp_tree, tvb, 8, 4,
          "Originate timestamp: %s after midnight UTC",
          time_msecs_to_str(orig_ts));

        proto_tree_add_text(icmp_tree, tvb, 12, 4,
          "Receive timestamp: %s after midnight UTC",
          time_msecs_to_str(get_best_guess_mstimeofday(tvb, 12, orig_ts)));
        proto_tree_add_text(icmp_tree, tvb, 16, 4,
          "Transmit timestamp: %s after midnight UTC",
          time_msecs_to_str(get_best_guess_mstimeofday(tvb, 16, orig_ts)));
    }
    break;

    case ICMP_MASKREQ:
    case ICMP_MASKREPLY:
	proto_tree_add_text(icmp_tree, tvb, 8, 4, "Address mask: %s (0x%08x)",
	  tvb_ip_to_str(tvb, 8), tvb_get_ntohl(tvb, 8));
	break;
  }

  if (trans)
    tap_queue_packet(icmp_tap, pinfo, trans);
}

void
proto_register_icmp(void)
{
  static hf_register_info hf[] = {
    { &hf_icmp_type,
      { "Type",         "icmp.type",            FT_UINT8, BASE_DEC,     NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_code,
      { "Code",         "icmp.code",            FT_UINT8, BASE_DEC,     NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_checksum,
      { "Checksum",     "icmp.checksum",        FT_UINT16, BASE_HEX,    NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_checksum_bad,
      { "Bad Checksum", "icmp.checksum_bad",    FT_BOOLEAN, BASE_NONE,  NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_ident,
      { "Identifier (BE)", "icmp.ident",              FT_UINT16, BASE_DEC_HEX,    NULL, 0x0,
        "Identifier (big endian representation)", HFILL }},

    { &hf_icmp_ident_le,
      { "Identifier (LE)", "icmp.ident",              FT_UINT16, BASE_DEC_HEX,    NULL, 0x0,
        "Identifier (little endian representation)", HFILL }},

    { &hf_icmp_seq_num,
      { "Sequence number (BE)", "icmp.seq",           FT_UINT16, BASE_DEC_HEX,    NULL, 0x0, "Sequence number (big endian representation)", HFILL }},

    { &hf_icmp_seq_num_le,
      {"Sequence number (LE)", "icmp.seq_le",   FT_UINT16, BASE_DEC_HEX,    NULL, 0x0,  "Sequence number (little endian representation)", HFILL }},

    { &hf_icmp_mtu,
      { "MTU of next hop", "icmp.mtu",           FT_UINT16, BASE_DEC,    NULL, 0x0,
        NULL, HFILL}},

    { &hf_icmp_redir_gw,
      { "Gateway address", "icmp.redir_gw",      FT_IPv4, BASE_NONE,     NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_mip_type,
      { "Extension Type", "icmp.mip.type",      FT_UINT8, BASE_DEC,
        VALS(mip_extensions), 0x0,NULL, HFILL}},

    { &hf_icmp_mip_length,
      { "Length", "icmp.mip.length",            FT_UINT8, BASE_DEC, NULL, 0x0,
        NULL, HFILL}},

    { &hf_icmp_mip_prefix_length,
      { "Prefix Length", "icmp.mip.prefixlength",  FT_UINT8, BASE_DEC, NULL, 0x0,
        NULL, HFILL}},

    { &hf_icmp_mip_seq,
      { "Sequence Number", "icmp.mip.seq",      FT_UINT16, BASE_DEC, NULL, 0x0,
        NULL, HFILL}},

    { &hf_icmp_mip_life,
      { "Registration Lifetime", "icmp.mip.life",  FT_UINT16, BASE_DEC, NULL, 0x0,
        NULL, HFILL}},

    { &hf_icmp_mip_flags,
      { "Flags", "icmp.mip.flags",            FT_UINT16, BASE_HEX, NULL, 0x0,
        NULL, HFILL}},

    { &hf_icmp_mip_r,
      { "Registration Required", "icmp.mip.r", FT_BOOLEAN, 16, NULL, 0x8000,
        "Registration with this FA is required", HFILL }},

    { &hf_icmp_mip_b,
      { "Busy", "icmp.mip.b", FT_BOOLEAN, 16, NULL, 0x4000,
        "This FA will not accept requests at this time", HFILL }},

    { &hf_icmp_mip_h,
      { "Home Agent", "icmp.mip.h", FT_BOOLEAN, 16, NULL, 0x2000,
        "Home Agent Services Offered", HFILL }},

    { &hf_icmp_mip_f,
      { "Foreign Agent", "icmp.mip.f", FT_BOOLEAN, 16, NULL, 0x1000,
        "Foreign Agent Services Offered", HFILL }},

    { &hf_icmp_mip_m,
      { "Minimal Encapsulation", "icmp.mip.m", FT_BOOLEAN, 16, NULL, 0x0800,
        "Minimal encapsulation tunneled datagram support", HFILL }},

    { &hf_icmp_mip_g,
      { "GRE", "icmp.mip.g", FT_BOOLEAN, 16, NULL, 0x0400,
        "GRE encapsulated tunneled datagram support", HFILL }},

    { &hf_icmp_mip_v,
      { "VJ Comp", "icmp.mip.v", FT_BOOLEAN, 16, NULL, 0x0200,
        "Van Jacobson Header Compression Support", HFILL }},

    { &hf_icmp_mip_rt,
      { "Reverse tunneling", "icmp.mip.rt", FT_BOOLEAN, 16, NULL, 0x0100,
       "Reverse tunneling support", HFILL }},

    { &hf_icmp_mip_u,
      { "UDP tunneling", "icmp.mip.u", FT_BOOLEAN, 16, NULL, 0x0080,
       "UDP tunneling support", HFILL }},

    { &hf_icmp_mip_x,
      { "Revocation support", "icmp.mip.x", FT_BOOLEAN, 16, NULL, 0x0040,
       "Registration revocation support", HFILL }},

    { &hf_icmp_mip_reserved,
      { "Reserved", "icmp.mip.reserved",     FT_UINT16, BASE_HEX, NULL, 0x003f,
        NULL, HFILL}},

    { &hf_icmp_mip_coa,
      { "Care-Of-Address", "icmp.mip.coa",    FT_IPv4, BASE_NONE, NULL, 0x0,
        NULL, HFILL}},

    { &hf_icmp_mip_challenge,
      { "Challenge", "icmp.mip.challenge",    FT_BYTES, BASE_NONE, NULL, 0x0,
        NULL, HFILL}},

    { &hf_icmp_ext,
      { "ICMP Extensions",     "icmp.ext",    FT_NONE, BASE_NONE,     NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_ext_version,
      { "Version",              "icmp.ext.version", FT_UINT8, BASE_DEC, NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_ext_reserved,
      { "Reserved",     "icmp.ext.res",        FT_UINT16, BASE_HEX,    NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_ext_checksum,
      { "Checksum",     "icmp.ext.checksum",   FT_UINT16, BASE_HEX,    NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_ext_checksum_bad,
      { "Bad Checksum", "icmp.ext.checksum_bad",       FT_BOOLEAN, BASE_NONE,  NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_ext_length,
      { "Length","icmp.ext.length", FT_UINT16, BASE_DEC, NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_ext_class,
      { "Class",        "icmp.ext.class", FT_UINT8, BASE_DEC, NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_ext_c_type,
      { "C-Type",       "icmp.ext.ctype", FT_UINT8, BASE_DEC, NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_mpls_label,
      { "Label",        "icmp.mpls.label", FT_UINT24, BASE_DEC, NULL, 0x00fffff0,
        NULL, HFILL }},

    { &hf_icmp_mpls_exp,
      { "Experimental", "icmp.mpls.exp", FT_UINT24, BASE_DEC, NULL, 0x0e,
        NULL, HFILL }},

    { &hf_icmp_mpls_s,
      { "Stack bit",    "icmp.mpls.s", FT_BOOLEAN, 24, TFS(&tfs_set_notset), 0x01,
        NULL, HFILL }},

    { &hf_icmp_mpls_ttl,
      { "Time to live", "icmp.mpls.ttl", FT_UINT8, BASE_DEC, NULL, 0x0,
        NULL, HFILL }},

    { &hf_icmp_resp_in,
      { "Response In", "icmp.resp_in", FT_FRAMENUM, BASE_NONE, NULL, 0x0,
        "The response to this request is in this frame", HFILL }},

    { &hf_icmp_resp_to,
      { "Response To", "icmp.resp_to", FT_FRAMENUM, BASE_NONE, NULL, 0x0,
        "This is the response to the request in this frame", HFILL }},

    { &hf_icmp_resptime,
      { "Response Time", "icmp.resptime", FT_DOUBLE, BASE_NONE, NULL, 0x0,
        "The time between the request and the response, in ms.", HFILL }},

    { &hf_icmp_data_time,
      { "Timestamp from icmp data", "icmp.data_time", FT_ABSOLUTE_TIME, ABSOLUTE_TIME_LOCAL, NULL, 0x0,
        "The timestamp in the first 8 bytes of the icmp data", HFILL }},

    { &hf_icmp_data_time_relative,
      { "Timestamp from icmp data (relative)", "icmp.data_time_relative", FT_RELATIVE_TIME, BASE_NONE, NULL, 0x0,
        "The timestamp of the packet, relative to the timestamp in the first 8 bytes of the icmp data", HFILL }},

    { &hf_icmp_length,
      { "Length of original datagram",         "icmp.length",            FT_UINT8, BASE_DEC,     NULL, 0x0,
        "The length of the original datagram", HFILL }},
    {&hf_icmp_int_info_role,
        {"Interface Role", "icmp.int_info.role",
            FT_UINT8, BASE_DEC, VALS(interface_role_str), INT_INFO_INTERFACE_ROLE,
            NULL, HFILL }},
    {&hf_icmp_int_info_reserved,
        {"Reserved", "icmp.int_info.reserved",
            FT_UINT8, BASE_DEC, NULL, INT_INFO_RESERVED,
            NULL, HFILL }},
    { &hf_icmp_int_info_ifindex,
      { "ifIndex", "icmp.int_info.ifindex", FT_BOOLEAN, 8, NULL, INT_INFO_IFINDEX, 
        "True: ifIndex of the interface included; False: ifIndex of the interface not included ", HFILL }},
    { &hf_icmp_int_info_ipaddr,
      { "IP Address", "icmp.int_info.ipaddr", FT_BOOLEAN, 8, NULL, INT_INFO_IPADDR, 
        "True: IP Address Sub-Object present; False: IP Address Sub-Object not present", HFILL }},
    { &hf_icmp_int_info_name,
      { "Interface Name", "icmp.int_info.name", FT_BOOLEAN, 8, NULL, INT_INFO_NAME, 
        "True: Interface Name Sub-Object present; False: Interface Name Sub-Object not present", HFILL }},
    { &hf_icmp_int_info_mtu,
      { "MTU", "icmp.int_info.mtu", FT_BOOLEAN, 8, NULL, INT_INFO_MTU, 
        "True: MTU present; False: MTU not present", HFILL }},
    { &hf_icmp_int_info_afi,
      { "Address Family Identifier", "icmp.int_info.afi", FT_UINT16, BASE_DEC, NULL, 0x0, 
        "Address Family of the interface address", HFILL }},
    { &hf_icmp_int_info_ipv4,
		{ "Source",		"icmp.int_info.ipv4", FT_IPv4, BASE_NONE, NULL, 0x0,
			NULL, HFILL }},
    { &hf_icmp_int_info_ipv6,
		{ "Source",		"icmp.int_info.ipv6", FT_IPv6, BASE_NONE, NULL, 0x0,
			NULL, HFILL }}
  };

  static gint *ett[] = {
    &ett_icmp,
    &ett_icmp_mip,
    &ett_icmp_mip_flags,
    /* MPLS extensions */
    &ett_icmp_ext,
    &ett_icmp_ext_object,
    &ett_icmp_mpls_stack_object,
    /* Interface Information Object RFC 5837*/
    &ett_icmp_interface_info_object,
    &ett_icmp_interface_ipaddr,
    &ett_icmp_interface_name
  };

  module_t *icmp_module;

  proto_icmp = proto_register_protocol("Internet Control Message Protocol",
				       "ICMP", "icmp");
  proto_register_field_array(proto_icmp, hf, array_length(hf));
  proto_register_subtree_array(ett, array_length(ett));

  icmp_module = prefs_register_protocol(proto_icmp, NULL);

  prefs_register_bool_preference(icmp_module, "favor_icmp_mpls",
	    "Favor ICMP extensions for MPLS",
	    "Whether the 128th and following bytes of the ICMP payload should be decoded as MPLS extensions or as a portion of the original packet",
	    &favor_icmp_mpls_ext);

  register_dissector("icmp", dissect_icmp, proto_icmp);
  icmp_tap = register_tap("icmp");
}

void
proto_reg_handoff_icmp(void)
{
  dissector_handle_t icmp_handle;

  /*
   * Get handle for the IP dissector.
   */
  ip_handle = find_dissector("ip");
  icmp_handle = find_dissector("icmp");
  data_handle = find_dissector("data");

  dissector_add_uint("ip.proto", IP_PROTO_ICMP, icmp_handle);
}