From be69761c78d0c285f88ea6b2da0399fcecf9d782 Mon Sep 17 00:00:00 2001 From: Ahmad Fatoum Date: Tue, 22 Aug 2017 11:00:28 +0200 Subject: Fix requesting hardware timestamps without -k The interface_options struct passed to dumpcap is populated differently when running Wireshark with and without -k. Previously, only with -k was there a valid pointer in interface_opts.timestamp_type Fixes: aca55a2 ("Add hardware timestamping support") Signed-off-by: Ahmad Fatoum Change-Id: Ic7ecc5a1190c28197d6a7271f1b353f74d43ca61 Reviewed-on: https://code.wireshark.org/review/23160 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann --- ui/gtk/capture_dlg.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'ui/gtk') diff --git a/ui/gtk/capture_dlg.c b/ui/gtk/capture_dlg.c index c79ff4d4d0..363746d2a3 100644 --- a/ui/gtk/capture_dlg.c +++ b/ui/gtk/capture_dlg.c @@ -1302,6 +1302,7 @@ insert_new_rows(GList *rlist) device.snaplen = global_capture_opts.default_options.snaplen; } device.cfilter = g_strdup(global_capture_opts.default_options.cfilter); + device.timestamp_type = g_strdup(global_capture_opts.default_options.timestamp_type); monitor_mode = prefs_capture_device_monitor_mode(if_string); if (roptions->remote_host_opts.auth_type == CAPTURE_AUTH_PWD) { auth_str = g_strdup_printf("%s:%s", roptions->remote_host_opts.auth_username, @@ -2656,6 +2657,7 @@ void options_interface_cb(GtkTreeView *view, GtkTreePath *path, GtkTreeViewColum device.has_snaplen = FALSE; device.snaplen = WTAP_MAX_PACKET_SIZE_STANDARD; device.cfilter = NULL; + device.timestamp_type = NULL; #ifdef CAN_SET_CAPTURE_BUFFER_SIZE device.buffer = DEFAULT_CAPTURE_BUFFER_SIZE; #endif @@ -3507,6 +3509,7 @@ add_pipe_cb(gpointer w _U_) device.has_snaplen = global_capture_opts.default_options.has_snaplen; device.snaplen = global_capture_opts.default_options.snaplen; device.cfilter = g_strdup(global_capture_opts.default_options.cfilter); + device.timestamp_type = g_strdup(global_capture_opts.default_options.timestamp_type); device.addresses = NULL; device.no_addresses = 0; device.last_packets = 0; -- cgit v1.2.3