From 62b342443ddf2e5089c9cbaf137dc6a81b0b4678 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Sat, 8 Apr 2017 20:02:53 -0700 Subject: Pull the error-reporting code for preference files into read_prefs(). No need to duplicate it in N different programs. Update comments while we're at it. Change-Id: I3096cbe5448a19363eff6303bdd54e522dae9336 Reviewed-on: https://code.wireshark.org/review/20973 Reviewed-by: Guy Harris --- tfshark.c | 31 ++----------------------------- 1 file changed, 2 insertions(+), 29 deletions(-) (limited to 'tfshark.c') diff --git a/tfshark.c b/tfshark.c index 0993b6181e..e72645aedb 100644 --- a/tfshark.c +++ b/tfshark.c @@ -334,9 +334,6 @@ main(int argc, char *argv[]) }; gboolean arg_error = FALSE; - char *gpf_path, *pf_path; - int gpf_open_errno, gpf_read_errno; - int pf_open_errno, pf_read_errno; int err; volatile int exit_status = 0; gboolean quiet = FALSE; @@ -560,8 +557,7 @@ main(int argc, char *argv[]) if (strcmp(argv[2], "column-formats") == 0) column_dump_column_formats(); else if (strcmp(argv[2], "currentprefs") == 0) { - read_prefs(&gpf_open_errno, &gpf_read_errno, &gpf_path, - &pf_open_errno, &pf_read_errno, &pf_path); + read_prefs(); write_prefs(NULL); } else if (strcmp(argv[2], "decodes") == 0) @@ -601,30 +597,7 @@ main(int argc, char *argv[]) goto clean_exit; } - prefs_p = read_prefs(&gpf_open_errno, &gpf_read_errno, &gpf_path, - &pf_open_errno, &pf_read_errno, &pf_path); - if (gpf_path != NULL) { - if (gpf_open_errno != 0) { - cmdarg_err("Can't open global preferences file \"%s\": %s.", - pf_path, g_strerror(gpf_open_errno)); - } - if (gpf_read_errno != 0) { - cmdarg_err("I/O error reading global preferences file \"%s\": %s.", - pf_path, g_strerror(gpf_read_errno)); - } - } - if (pf_path != NULL) { - if (pf_open_errno != 0) { - cmdarg_err("Can't open your preferences file \"%s\": %s.", pf_path, - g_strerror(pf_open_errno)); - } - if (pf_read_errno != 0) { - cmdarg_err("I/O error reading your preferences file \"%s\": %s.", - pf_path, g_strerror(pf_read_errno)); - } - g_free(pf_path); - pf_path = NULL; - } + prefs_p = read_prefs(); /* * Read the files that enable and disable protocols and heuristic -- cgit v1.2.3