From c2ebb62e7e2adca72b932276102ee0a293b9a4ff Mon Sep 17 00:00:00 2001 From: Michael Mann Date: Sat, 8 Jul 2017 22:46:52 -0400 Subject: Don't use uint_to_str_back when you need guint32_to_str_buf. It will end up eventually crashing column buffers because memory behind the address is trounced. Change-Id: Id6b5a42effc503e4b8bf5e1deb2135241e2893f3 Reviewed-on: https://code.wireshark.org/review/22563 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann --- plugins/irda/packet-irda.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'plugins') diff --git a/plugins/irda/packet-irda.c b/plugins/irda/packet-irda.c index 52b28812df..7fff28544f 100644 --- a/plugins/irda/packet-irda.c +++ b/plugins/irda/packet-irda.c @@ -1853,11 +1853,9 @@ static int dissect_irda(tvbuff_t* tvb, packet_info* pinfo, proto_tree* root, voi static int irda_addr_to_str(const address* addr, gchar *buf, int buf_len _U_) { const guint8 *addrdata = (const guint8 *)addr->data; - gchar *start_buf = buf; - buf = uint_to_str_back(buf, *addrdata); - *buf = '\0'; - return (int)(buf-start_buf+1); + guint32_to_str_buf(*addrdata, buf, buf_len); + return (int)strlen(buf); } static int irda_addr_str_len(const address* addr _U_) -- cgit v1.2.3