From d2197e36dfd63ce5d1235ecabd02d616028ac6b7 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Mon, 26 Nov 2001 10:05:27 +0000 Subject: Add some comments. svn path=/trunk/; revision=4273 --- packet-smb.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'packet-smb.c') diff --git a/packet-smb.c b/packet-smb.c index d6fd37ac74..a1907910da 100644 --- a/packet-smb.c +++ b/packet-smb.c @@ -2,7 +2,7 @@ * Routines for smb packet dissection * Copyright 1999, Richard Sharpe * - * $Id: packet-smb.c,v 1.168 2001/11/26 09:58:38 guy Exp $ + * $Id: packet-smb.c,v 1.169 2001/11/26 10:05:27 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs @@ -10732,6 +10732,14 @@ dissect_transaction_response(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree COUNT_BYTES(padcnt); } if(dc){ + /* + * XXX - should we just take the minimum of "bc" and + * "dc", and use that, at least if this is the final + * transaction? I've seen packets where the byte count + * doesn't seem to include all the data that the data + * count claims should be there, although the extra + * byte might be padding. + */ CHECK_BYTE_COUNT(dc); /*qqq*/ @@ -10741,6 +10749,9 @@ dissect_transaction_response(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree If someone ever finds an Transaction command which needs reassembly of parameters as well, then we will have to add that here. + + XXX - is this done even if we don't have all the data + for this SMB (e.g., if we have a short frame)? */ if(smb_trans_reassembly){ if( (dd>0 || (dd+dc)