From 9f2c88966a252520a4bafaa5fee36cf39c1eb85a Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Mon, 22 Jan 2001 03:33:45 +0000 Subject: Remove more "CHECK_DISPLAY_AS_DATA()" calls and "pinfo->current_proto =" statements. Move the setting of the Protocol column in various dissectors before anything is fetched from the packet, and also clear the Info column at that point in those and some other dissectors, so that if an exception is thrown, the columns don't reflect the previous protocol. Make the IP dissector static, as it's called only via dissector tables or dissector handles. Also make the "dissect the TOS field as the DiffServ DS field" flag static, as it's not referred to outside of "packet-ip.c". In the NCP dissector, refer to the port type through "pinfo" rather than through the global "pi", as it's a tvbuffified dissector. svn path=/trunk/; revision=2929 --- packet-pim.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'packet-pim.c') diff --git a/packet-pim.c b/packet-pim.c index d472003082..448ab0640d 100644 --- a/packet-pim.c +++ b/packet-pim.c @@ -2,7 +2,7 @@ * Routines for PIM disassembly * (c) Copyright Jun-ichiro itojun Hagino * - * $Id: packet-pim.c,v 1.22 2001/01/13 06:34:32 guy Exp $ + * $Id: packet-pim.c,v 1.23 2001/01/22 03:33:45 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs @@ -219,10 +219,6 @@ dissect_pim(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) { proto_tree *pimopt_tree = NULL; proto_item *tiopt; - CHECK_DISPLAY_AS_DATA(proto_pim, tvb, pinfo, tree); - - pinfo->current_proto = "PIM"; - if (check_col(pinfo->fd, COL_PROTOCOL)) col_set_str(pinfo->fd, COL_PROTOCOL, "PIM"); if (check_col(pinfo->fd, COL_INFO)) -- cgit v1.2.3