From cc36f0b9312fc36778bf227cbaaf02c89baf09b3 Mon Sep 17 00:00:00 2001 From: Laurent Deniel Date: Sun, 13 Aug 2000 14:09:15 +0000 Subject: Add the "Edit:Protocols..." feature which currently only implements the following: It is now possible to enable/disable a particular protocol decoding (i.e. the protocol dissector is void or not). When a protocol is disabled, it is displayed as Data and of course, all linked sub-protocols are disabled as well. Disabling a protocol could be interesting: - in case of buggy dissectors - in case of wrong heuristics - for performance reasons - to decode the data as another protocol (TODO) Currently (if I am not wrong), all dissectors but NFS can be disabled (and dissectors that do not register protocols :-) I do not like the way the RPC sub-dissectors are disabled (in the sub-dissectors) since this could be done in the RPC dissector itself, knowing the sub-protocol hfinfo entry (this is why, I've not modified the NFS one yet). Two functions are added in proto.c : gboolean proto_is_protocol_enabled(int n); void proto_set_decoding(int n, gboolean enabled); and two MACROs which can be used in dissectors: OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree) CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree) See also the XXX in proto_dlg.c and proto.c around the new functions. svn path=/trunk/; revision=2267 --- packet-nbns.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'packet-nbns.c') diff --git a/packet-nbns.c b/packet-nbns.c index d342502d5d..1c593fdb6c 100644 --- a/packet-nbns.c +++ b/packet-nbns.c @@ -4,7 +4,7 @@ * Gilbert Ramirez * Much stuff added by Guy Harris * - * $Id: packet-nbns.c,v 1.44 2000/08/07 03:20:53 guy Exp $ + * $Id: packet-nbns.c,v 1.45 2000/08/13 14:08:30 deniel Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs @@ -1133,6 +1133,8 @@ dissect_nbns(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) guint16 id, flags, quest, ans, auth, add; int cur_off; + OLD_CHECK_DISPLAY_AS_DATA(proto_nbns, pd, offset, fd, tree); + nbns_data_offset = offset; if (check_col(fd, COL_PROTOCOL)) @@ -1293,6 +1295,8 @@ dissect_nbdgm(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) int name_type; int len; + OLD_CHECK_DISPLAY_AS_DATA(proto_nbdgm, pd, offset, fd, tree); + header.msg_type = pd[offset]; flags = pd[offset+1]; @@ -1586,6 +1590,8 @@ dissect_nbss(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) int max_data; int is_cifs; + OLD_CHECK_DISPLAY_AS_DATA(proto_nbss, pd, offset, fd, tree); + msg_type = pd[offset]; if (pi.match_port == TCP_PORT_CIFS) { -- cgit v1.2.1