From cc36f0b9312fc36778bf227cbaaf02c89baf09b3 Mon Sep 17 00:00:00 2001 From: Laurent Deniel Date: Sun, 13 Aug 2000 14:09:15 +0000 Subject: Add the "Edit:Protocols..." feature which currently only implements the following: It is now possible to enable/disable a particular protocol decoding (i.e. the protocol dissector is void or not). When a protocol is disabled, it is displayed as Data and of course, all linked sub-protocols are disabled as well. Disabling a protocol could be interesting: - in case of buggy dissectors - in case of wrong heuristics - for performance reasons - to decode the data as another protocol (TODO) Currently (if I am not wrong), all dissectors but NFS can be disabled (and dissectors that do not register protocols :-) I do not like the way the RPC sub-dissectors are disabled (in the sub-dissectors) since this could be done in the RPC dissector itself, knowing the sub-protocol hfinfo entry (this is why, I've not modified the NFS one yet). Two functions are added in proto.c : gboolean proto_is_protocol_enabled(int n); void proto_set_decoding(int n, gboolean enabled); and two MACROs which can be used in dissectors: OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree) CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree) See also the XXX in proto_dlg.c and proto.c around the new functions. svn path=/trunk/; revision=2267 --- packet-isis-snp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'packet-isis-snp.c') diff --git a/packet-isis-snp.c b/packet-isis-snp.c index fb105d562f..e0001f1eae 100644 --- a/packet-isis-snp.c +++ b/packet-isis-snp.c @@ -1,7 +1,7 @@ /* packet-isis-snp.c * Routines for decoding isis complete & partial SNP and their payload * - * $Id: packet-isis-snp.c,v 1.6 2000/06/19 08:33:49 guy Exp $ + * $Id: packet-isis-snp.c,v 1.7 2000/08/13 14:08:22 deniel Exp $ * Stuart Stanley * * Ethereal - Network traffic analyzer @@ -248,6 +248,8 @@ isis_dissect_isis_csnp(int type, int header_length, int id_length, guint16 pdu_length; int len; + OLD_CHECK_DISPLAY_AS_DATA(proto_isis_csnp, pd, offset, fd, tree); + hlen = 2+id_length+1+id_length+2+id_length+2; if (!BYTES_ARE_IN_FRAME(offset, hlen)) { @@ -331,6 +333,8 @@ isis_dissect_isis_psnp(int type, int header_length, int id_length, guint16 pdu_length; int len; + OLD_CHECK_DISPLAY_AS_DATA(proto_isis_psnp, pd, offset, fd, tree); + hlen = 2+id_length+1; if (!BYTES_ARE_IN_FRAME(offset, hlen)) { -- cgit v1.2.3