From 3b67c5b3084cd74986115e06eab954b4f8332a3f Mon Sep 17 00:00:00 2001 From: Martin Mathieson Date: Sun, 16 Aug 2020 21:41:18 +0100 Subject: TFS: Add some commonly-defined string pairs to tfs.c 'check_tfs.py --common' can look for tfs values that appear multiple times. Current output prior to these dssector changes was: ('No Extension', 'Extension') appears 3 times in: ['epan/dissectors/packet-bssap.c', 'epan/dissectors/packet-camel.c', 'epan/dissectors/packet-gsm_map.c'] ('Optimised for signalling traffic', 'Not optimised for signalling traffic') appears 3 times in: ['epan/dissectors/packet-gsm_a_gm.c', 'epan/dissectors/packet-gsm_map.c', 'epan/dissectors/packet-gtp.c'] ('Data PDU', 'Control PDU') appears 3 times in: ['epan/dissectors/packet-pdcp-lte.c', 'epan/dissectors/packet-pdcp-nr.c', 'epan/dissectors/packet-rlc-nr.c'] ('Message sent to originating side', 'Message sent from originating side') appears 3 times in: ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c'] ('User', 'Provider') appears 3 times in: ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c'] The first and last ones were made common, the others seem a little too specialised. Checking some of the existing items in tfs.c (using QtCreator's 'Find Usages'), some of the common items are used a lot, but many of them are not referenced. Change-Id: Ia4006d2c4fa7cafbc3b004dc7a367a986dbeb0c4 Reviewed-on: https://code.wireshark.org/review/38177 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- epan/dissectors/packet-q2931.c | 1 - 1 file changed, 1 deletion(-) (limited to 'epan/dissectors/packet-q2931.c') diff --git a/epan/dissectors/packet-q2931.c b/epan/dissectors/packet-q2931.c index c9fa28d442..59120a5ab5 100644 --- a/epan/dissectors/packet-q2931.c +++ b/epan/dissectors/packet-q2931.c @@ -1124,7 +1124,6 @@ static const value_string q2931_rejection_reason_vals[] = { { 0x00, NULL } }; -static const true_false_string tfs_user_provider = { "User", "Provider" }; static const true_false_string tfs_abnormal_normal = { "Abnormal", "Normal" }; static void -- cgit v1.2.3