From 1950ffc2141ffdb7a0b8ec8291b0bf99ac12d9d6 Mon Sep 17 00:00:00 2001 From: Anders Broman Date: Tue, 23 Oct 2007 05:50:00 +0000 Subject: Apply the small performance enhancment patches for: - if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe svn path=/trunk/; revision=23252 --- epan/dissectors/packet-ldp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'epan/dissectors/packet-ldp.c') diff --git a/epan/dissectors/packet-ldp.c b/epan/dissectors/packet-ldp.c index 2e62f22ddc..b382fdec3d 100644 --- a/epan/dissectors/packet-ldp.c +++ b/epan/dissectors/packet-ldp.c @@ -2264,7 +2264,7 @@ dissect_msg(tvbuff_t *tvb, guint offset, packet_info *pinfo, proto_tree *tree) if( rem < 8 ) {/*chk for minimum header = type + length + msg_id*/ if( check_col(pinfo->cinfo, COL_INFO) ) - col_append_fstr(pinfo->cinfo, COL_INFO, "Bad Message"); + col_append_str(pinfo->cinfo, COL_INFO, "Bad Message"); if(tree) proto_tree_add_text(tree, tvb, offset, rem, "Error processing Message: length is %d, should be >= 8", @@ -2287,7 +2287,7 @@ dissect_msg(tvbuff_t *tvb, guint offset, packet_info *pinfo, proto_tree *tree) if( (length = tvb_get_ntohs(tvb, offset + 2)) < (4+extra) ) {/*not enough data for type*/ if( check_col(pinfo->cinfo, COL_INFO) ) - col_append_fstr(pinfo->cinfo, COL_INFO, "Bad Message Length "); + col_append_str(pinfo->cinfo, COL_INFO, "Bad Message Length "); if(tree) proto_tree_add_text(tree, tvb, offset, rem, "Error processing Message Length: length is %d, should be >= %u", -- cgit v1.2.3