From 5f35fddc2349e876de21118a112627cc551bfe5f Mon Sep 17 00:00:00 2001 From: Alexis La Goutte Date: Fri, 25 May 2018 07:57:18 +0200 Subject: gQUIC: it is possible to have multiple COPT Tag And it is a STRING display Change-Id: I0f6521e936219bc98cd8eae2862bf6c582123f57 Reviewed-on: https://code.wireshark.org/review/27797 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- epan/dissectors/packet-gquic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'epan/dissectors/packet-gquic.c') diff --git a/epan/dissectors/packet-gquic.c b/epan/dissectors/packet-gquic.c index e65463df1a..33a6559b53 100644 --- a/epan/dissectors/packet-gquic.c +++ b/epan/dissectors/packet-gquic.c @@ -1504,8 +1504,8 @@ dissect_gquic_tag(tvbuff_t *tvb, packet_info *pinfo, proto_tree *gquic_tree, gui tag_offset += 4; break; case TAG_COPT: - if(tag_len){ - proto_tree_add_item(tag_tree, hf_gquic_tag_copt, tvb, tag_offset_start + tag_offset, 4, ENC_LITTLE_ENDIAN); + while(offset_end - tag_offset >= 4){ + proto_tree_add_item(tag_tree, hf_gquic_tag_copt, tvb, tag_offset_start + tag_offset, 4, ENC_ASCII|ENC_NA); tag_offset += 4; } break; @@ -2735,7 +2735,7 @@ proto_register_gquic(void) }, { &hf_gquic_tag_copt, { "Connection options", "gquic.tag.copt", - FT_UINT32, BASE_DEC_HEX, NULL, 0x0, + FT_STRING, BASE_NONE, NULL, 0x0, NULL, HFILL } }, { &hf_gquic_tag_ccrt, -- cgit v1.2.3