From 9754448044eb75e3087bf8c078eb50b481f82e9d Mon Sep 17 00:00:00 2001 From: Gerald Combs Date: Fri, 13 Jan 2023 10:37:34 -0800 Subject: CoAP+RTPS: Initialize some variables Fix ==10365== Conditional jump or move depends on uninitialised value(s) ==10365== at 0x81514B4: get_hfi_length (epan/proto.c:5981) ==10365== by 0x815A0A5: proto_tree_add_pi (epan/proto.c:5953) ==10365== by 0x815F41B: proto_tree_add_uint64 (epan/proto.c:5542) ==10365== by 0x6BF362C: dissect_msg_tag (epan/dissectors/packet-cose.c:462) ==10365== by 0x6BF1A27: dissect_cose_mac (epan/dissectors/packet-cose.c:656) ==10365== by 0x813511A: call_dissector_through_handle (epan/packet.c:757) ==10365== by 0x8130E58: call_dissector_work (epan/packet.c:850) ==10365== by 0x8131604: dissector_try_string_new (epan/packet.c:1751) ==10365== by 0x8131686: dissector_try_string (epan/packet.c:1776) ==10365== by 0x6BD8C60: dissect_coap_payload (epan/dissectors/packet-coap.c:1115) ==10365== by 0x6BDAD34: dissect_coap_message (epan/dissectors/packet-coap.c:1403) ==10365== by 0x6BD8ECB: dissect_coap (epan/dissectors/packet-coap.c:1526) ==10365== ==10365== Conditional jump or move depends on uninitialised value(s) ==10365== at 0x81517EC: get_hfi_length (epan/proto.c:6115) ==10365== by 0x815A0A5: proto_tree_add_pi (epan/proto.c:5953) ==10365== by 0x815F41B: proto_tree_add_uint64 (epan/proto.c:5542) ==10365== by 0x6BF362C: dissect_msg_tag (epan/dissectors/packet-cose.c:462) ==10365== by 0x6BF1A27: dissect_cose_mac (epan/dissectors/packet-cose.c:656) ==10365== by 0x813511A: call_dissector_through_handle (epan/packet.c:757) ==10365== by 0x8130E58: call_dissector_work (epan/packet.c:850) ==10365== by 0x8131604: dissector_try_string_new (epan/packet.c:1751) ==10365== by 0x8131686: dissector_try_string (epan/packet.c:1776) ==10365== by 0x6BD8C60: dissect_coap_payload (epan/dissectors/packet-coap.c:1115) ==10365== by 0x6BDAD34: dissect_coap_message (epan/dissectors/packet-coap.c:1403) ==10365== by 0x6BD8ECB: dissect_coap (epan/dissectors/packet-coap.c:1526) and ==10365== Conditional jump or move depends on uninitialised value(s) ==10365== at 0x748EB90: hash_by_guid (epan/dissectors/packet-rtps.c:6006) ==10365== by 0xC522FD5: wmem_map_lookup (wsutil/wmem/wmem_map.c:264) ==10365== by 0x74A2E33: rtps_util_detect_coherent_set_end_empty_data_case (epan/dissectors/packet-rtps.c:3294) ==10365== by 0x74A1054: dissect_RTPS_DATA (epan/dissectors/packet-rtps.c:10829) ==10365== by 0x748E606: dissect_rtps_submessage_v2 (epan/dissectors/packet-rtps.c:12064) ==10365== by 0x748DFBE: dissect_rtps_submessages (epan/dissectors/packet-rtps.c:12439) ==10365== by 0x74A3FC9: dissect_rtps (epan/dissectors/packet-rtps.c:12357) ==10365== by 0x748EDD2: dissect_rtps_udp (epan/dissectors/packet-rtps.c:12459) ==10365== by 0x81334CA: dissector_try_heuristic (epan/packet.c:2864) ==10365== by 0x76A8FF6: decode_udp_ports (epan/dissectors/packet-udp.c:712) ==10365== by 0x76AB875: dissect (epan/dissectors/packet-udp.c:1267) ==10365== by 0x76A9DAD: dissect_udp (epan/dissectors/packet-udp.c:1273) Fixes #18785 --- epan/dissectors/packet-coap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'epan/dissectors/packet-coap.c') diff --git a/epan/dissectors/packet-coap.c b/epan/dissectors/packet-coap.c index 364ba37a51..a05658ef6a 100644 --- a/epan/dissectors/packet-coap.c +++ b/epan/dissectors/packet-coap.c @@ -1080,7 +1080,7 @@ dissect_coap_payload(tvbuff_t *tvb, packet_info *pinfo, proto_tree *coap_tree, p tvbuff_t *payload_tvb; guint payload_length = offset_end - offset; const char *coap_ctype_str_dis; - http_message_info_t message_info; + http_message_info_t message_info = {0}; char str_payload[80]; int result = 0; -- cgit v1.2.3