From 7cd6906056922e4b8f68f1216d94eaa0809896fe Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Mon, 9 Jan 2017 22:18:49 -0800 Subject: Rename tvb_new_subset() to tvb_new_subset_length_caplen(). This emphasizes that there is no such thing as *the* routine to construct a subset tvbuff; you need to choose one of tvb_new_subset_remaining() (if you want a new tvbuff that contains everything past a certain point in an existing tvbuff), tvb_new_subset_length() (if you want a subset that contains everything past a certain point, for some number of bytes, in an existing tvbuff), and tvb_new_subset_length_caplen() (for all other cases). Many of the calls to tvb_new_subset_length_caplen() should really be calling one of the other routines; that's the next step. (This also makes it easier to find the calls that need fixing.) Change-Id: Ieb3d676d8cda535451c119487d7cd3b559221f2b Reviewed-on: https://code.wireshark.org/review/19597 Reviewed-by: Guy Harris --- doc/README.dissector | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/README.dissector') diff --git a/doc/README.dissector b/doc/README.dissector index 39600c515e..3a722cb87f 100644 --- a/doc/README.dissector +++ b/doc/README.dissector @@ -2225,7 +2225,7 @@ that are relevant to the next dissector). The syntax for creating a new TVBUFF_SUBSET is: -next_tvb = tvb_new_subset(tvb, offset, length, reported_length) +next_tvb = tvb_new_subset_length_caplen(tvb, offset, length, reported_length) or, in the common case where it should just run to the end of the packet, -- cgit v1.2.3