From c7fd1b2b1357cf491eeb57d8313e5d33fd766094 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Wed, 11 Feb 2004 00:55:28 +0000 Subject: Add a routine to be used to put up alert boxes for invalid display filter expressions; use that in a number of places, so we use the same alert box. (More work is needed to figure out the right way to handle some other "dfilter_compile()" failures.) Use the error message from the display filter as the primary error, as that's the message that tells you what the underlying problem is. (The GNOME HIG says "In most situations the user should only need the primary text to make a quick decision", so the primary text should tell you what's wrong with the filter, not just that it's invalid. If there are messages from the display filter code that don't give enough information, or are a bit cryptic, such as "Unexpected end of filter string," those should be fixed in the display filter code.) Improve the error used if an empty filter is used for "find frame". svn path=/trunk/; revision=10025 --- alert_box.h | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 alert_box.h (limited to 'alert_box.h') diff --git a/alert_box.h b/alert_box.h new file mode 100644 index 0000000000..5c35d1896a --- /dev/null +++ b/alert_box.h @@ -0,0 +1,44 @@ +/* alert_box.h + * Routines to put up various "standard" alert boxes used in multiple + * places + * + * $Id: alert_box.h,v 1.1 2004/02/11 00:55:27 guy Exp $ + * + * Ethereal - Network traffic analyzer + * By Gerald Combs + * Copyright 1998 Gerald Combs + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. + */ + +#ifndef __ALERT_BOX_H__ +#define __ALERT_BOX_H__ + +#ifdef __cplusplus +extern "C" { +#endif /* __cplusplus */ + +/* + * Alert box for an invalid display filter expression. + * Assumes "dfilter_error_msg" has been set by "dfilter_compile()" to the + * error message for the filter. + */ +extern void bad_dfilter_alert_box(const char *dftext); + +#ifdef __cplusplus +} +#endif /* __cplusplus */ + +#endif /* __ALERT_BOX_H__ */ -- cgit v1.2.3