From fbf08cffec52af67ba69858b0ca23ce92789d00c Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Mon, 8 Dec 2014 20:04:23 -0800 Subject: Nothing to free there. pcapng_read_block() never sets *err_info if it returns PCAPNG_BLOCK_NOT_SHB - that happens on an EOF, a short read, or on a successful read of something that doesn't look like an SHB. Change-Id: I23ad6aa1c95d800b068a798a4aad1d70d07ac281 Reviewed-on: https://code.wireshark.org/review/5686 Reviewed-by: Guy Harris --- wiretap/pcapng.c | 1 - 1 file changed, 1 deletion(-) diff --git a/wiretap/pcapng.c b/wiretap/pcapng.c index abbc0c4c93..7c44a10e9b 100644 --- a/wiretap/pcapng.c +++ b/wiretap/pcapng.c @@ -2325,7 +2325,6 @@ pcapng_open(wtap *wth, int *err, gchar **err_info) case PCAPNG_BLOCK_NOT_SHB: /* An error indicating that this isn't a pcap-ng file. */ pcapng_free_wtapng_block_data(&wblock); - g_free(*err_info); /* We don't care why */ *err = 0; *err_info = NULL; return WTAP_OPEN_NOT_MINE; -- cgit v1.2.3