From b446e3647174fab41e5623b16d0ca31ca4898c90 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Thu, 10 Sep 2020 01:39:53 -0700 Subject: aeron: the Error String in an Error Header is not null-terminated. The Aeron specification says nothing about it being null-terminated, and in at least some captures, it's not null terminated. Make it an FT_STRING, rather than an FT_STRINGZ. Clean up a comment so that more of the URL is visible in a narrower window. --- epan/dissectors/packet-aeron.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/epan/dissectors/packet-aeron.c b/epan/dissectors/packet-aeron.c index 0b1c721302..71cfd1eb24 100644 --- a/epan/dissectors/packet-aeron.c +++ b/epan/dissectors/packet-aeron.c @@ -19,7 +19,11 @@ #include #include -/* The Aeron protocol is defined at https://github.com/real-logic/Aeron/wiki/Protocol-Specification */ +/* + * The Aeron protocol is defined at + * + * https://github.com/real-logic/aeron/wiki/Transport-Protocol-Specification + */ void proto_register_aeron(void); void proto_reg_handoff_aeron(void); @@ -3202,7 +3206,7 @@ void proto_register_aeron(void) { &hf_aeron_err_off_hdr, { "Offending Header", "aeron.err.off_hdr", FT_BYTES, BASE_NONE, NULL, 0x0, NULL, HFILL } }, { &hf_aeron_err_string, - { "Error String", "aeron.err.string", FT_STRINGZ, BASE_NONE, NULL, 0x0, NULL, HFILL } }, + { "Error String", "aeron.err.string", FT_STRING, BASE_NONE, NULL, 0x0, NULL, HFILL } }, { &hf_aeron_heartbeat, { "Heart Frame", "aeron.heartbeat", FT_NONE, BASE_NONE, NULL, 0x0, NULL, HFILL } }, { &hf_aeron_heartbeat_frame_length, -- cgit v1.2.3