aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2017-03-19[Automatic update for 2017-03-19]Gerald Combs7-50/+143
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I5d2807ce653df495722663def31164e2342b0d89 Reviewed-on: https://code.wireshark.org/review/20622 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-03-19Fix various compile warnings turning error on Linux with gcc6 whenJoerg Mayer1-8/+8
compiling with HAVE_PCAP_REMOTE (and ENABLE_ECHLD) Change-Id: If5524f2d3dcacca9c82a46167480c8436dd8b1b2 Reviewed-on: https://code.wireshark.org/review/20615 Petri-Dish: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-03-19Fix warning turning error:Joerg Mayer1-3/+4
/home/jmayer/work/wireshark/git/ui/qt/manage_interfaces_dialog.cpp:273:33: error: variable ‘link_type_name’ set but not used [-Werror=unused-but-set-variable] By commenting out all lines using this variable for now. Change-Id: I8f074b24f86ee2063fc545cabd99d446b31a06ec Reviewed-on: https://code.wireshark.org/review/20616 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-03-17Qt: Pluralize packet count in Size stringStig Bjørlykke2-9/+25
Change-Id: Ifb23f4d558aa30df4ec436e42a4e23b23c2af110 Reviewed-on: https://code.wireshark.org/review/20566 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-16proto_dlg.c: Convert GSList into wmem_treeMichael Mann1-156/+173
Change-Id: Ice643361e91bded91547428d7fbb7cdff969664f Reviewed-on: https://code.wireshark.org/review/20383 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-16g_assert on device.if_info.name to prevent undefined behaviour.Joerg Mayer1-0/+1
Change-Id: Id730eb0e846e557c2f5a47139b480362a0b2a777 Reviewed-on: https://code.wireshark.org/review/20561 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-03-15Qt: Disable "Show hidden interfaces"Stig Bjørlykke2-0/+6
Disable the "Show hidden interface" option until bug 13354 is fixed because it's not possible to capture from hidden interfaces yet. Ping-Bug: 13354 Change-Id: I428c2698485f0c7c2d9a8ab8408d7129af5fecf1 Reviewed-on: https://code.wireshark.org/review/20528 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-13tap-iostat (cli): fix this statement may fall through ↵Alexis La Goutte1-1/+1
[-Werror=implicit-fallthrough] found by gcc7 Change-Id: Idd8f4e2175d6575beecaccf2ee018457a25fd225 Reviewed-on: https://code.wireshark.org/review/20493 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-13Qt: Use em dash when hide the "Show" checkboxStig Bjørlykke1-1/+2
Match the style used in "Capture Interfaces" table when elements are N/A by using the em dash. This item should also be disabled using QPalette::Disabled to get a even better match. Change-Id: I127ce309318df2c36515996df8584d1e4ce690c0 Reviewed-on: https://code.wireshark.org/review/20527 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-12Qt: hide the "Show" checkbox for default devicesPeter Wu2-11/+14
When marking a previously hidden device as default (e.g. via wireshark -ocapture.device:eth0), an unchecked checkbox is visible. This is just confusing, just hide the checkbox completely. Change-Id: I3f85cfcb659c351c72237dced52f0684733188c4 Reviewed-on: https://code.wireshark.org/review/20478 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-12[Automatic update for 2017-03-12]Gerald Combs7-210/+210
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I5718e7c7df8061f81eb01973f504ebbb0cfe1e44 Reviewed-on: https://code.wireshark.org/review/20511 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-03-12Qt: Give discard button focus (but not as default)Stig Bjørlykke2-0/+6
Set focus to the discard button in the "Unsaved packet" and "Unsaved comments" dialogs to enable spacebar for discard and enter for save. Bug: 13363 Change-Id: I576b02c4e3f0964aef56a0f1c06ed57c6ba683bf Reviewed-on: https://code.wireshark.org/review/20485 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-10io_graph_item: fix false positive array subscript is above array bounds ↵Alexis La Goutte1-0/+1
[-Werror=array-bounds] Change-Id: I14fc19f131782a9c85104ca2189b9452079d0013 Reviewed-on: https://code.wireshark.org/review/20454 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-09RTP streams dialog: Fix find reverse buttonErik de Jong1-1/+3
Fix find reverse button Bug: 13462 Change-Id: I6e19fa38cd333285c9ca3cf01e4c06ff8de56b2a Reviewed-on: https://code.wireshark.org/review/20462 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-03-09Qt: Fix heap-use-after-free when deleting IO graphStig Bjørlykke1-1/+1
Deleting a IO graph item while editing a field will use the IOGraph object so ensure we delete in correct order to avoid heap-use-after-free. Bug: 13234 Change-Id: I6d0de21684f842fbd67c9b38fc6b75b81aec5518 Reviewed-on: https://code.wireshark.org/review/20456 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-06Switch conversations to use wmem_tree_t instead of (sorted) GSList.Michael Mann7-34/+59
Change-Id: Ifaf25ca5a7974f1d398ceebbb4c6733d4d3e001a Reviewed-on: https://code.wireshark.org/review/20006 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-05[Automatic update for 2017-03-05]Gerald Combs7-3766/+3906
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I074b964d75082adc6ab216514c36abf3d54c6a0a Reviewed-on: https://code.wireshark.org/review/20395 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-03-04Qt: Apply selected bookmark display filterStig Bjørlykke3-4/+12
When selecting a display filter from the bookmark list this filter should be applied, because that's the most common action for a user. Holding down the the Alt key will only prepare the filter. Change-Id: I567ee8a2a70a3de07fea33fa5763d9efba591de3 Reviewed-on: https://code.wireshark.org/review/20317 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-03-04pluginIF: Allow en-/disable of elementsRoland Knall1-5/+33
Allow the enable/disable of an element Change-Id: I9652e8d74b261ba259cebfba53e7bc7ef560d347 Reviewed-on: https://code.wireshark.org/review/20370 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-03-03Qt: Fix goto next/prev packet toolbar buttonsStig Bjørlykke1-4/+6
Use bitwise AND to check if a modifier bit is set. Also changed from MetaModifier to AltModifier to match the comment and the modifier key used in "Next/Previous Packet in History". Change-Id: I89072a1dfdd14a2beb7344a672cbc18a3ace8924 Reviewed-on: https://code.wireshark.org/review/20359 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-03Qt: reduce minimum window size requirementPeter Wu2-2/+2
Strip some padding from the main welcome screen and lower the minimum width to allow the window to be shrinked. Even when a capture file was open, the minimum dimensions from the main welcome screen would apply. The minimum dimensions on Arch Linux with Qt 5.8.0-5 and Plasma 5.9.2 (with the default Breeze theme) for a window have changes as follows: - main screen/pcap loaded: 746x626 -> 702x590 - with search bar opened: 826x658 -> 826x622 (These numbers exclude 35x10 window decoration.) Change-Id: Iccc43ee55803abb8105c0d9664368aab09e8cfcf Reviewed-on: https://code.wireshark.org/review/20343 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-03-03pluginIf: Add/Remove single entries from selectorRoland Knall1-31/+51
Allow to add and remove single items from a selector list and also fixing the selection of items in a selector list Change-Id: I0c69ea97db6ca1a6932939f0df9049c6fb720f77 Reviewed-on: https://code.wireshark.org/review/20363 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-03-03Qt: Add selection history navigation.Gerald Combs5-2/+124
Add the ability to move back and forth in the packet selection history similar to GTK+. Update the documentation accordingly. Change-Id: If1fdc1e59b240c0588c292dc0f7f0a5f083c30e1 Reviewed-on: https://code.wireshark.org/review/20320 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-03Qt: allow Packet Bytes view to be shrinkedPeter Wu2-0/+7
Even if a packet has only one or two lines for the byte view, Qt autoresizing insists to require a minimum of 5.5 lines (or 7.5 lines for packets without multiple data sources). Remove this artificial requirement and allow the packet bytes view to be resized to show nothing (except for possible data sources tabs). This makes it easier to fit more packets and details for screenshots. Change-Id: I3ea997b9effa8292b396dc2ceb2ab1c35cead410 Reviewed-on: https://code.wireshark.org/review/20342 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-02Use glib-compatAndersBroman1-5/+1
Change-Id: I510af18d433c4db360243dda72260e59eb84355f Reviewed-on: https://code.wireshark.org/review/20336 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-02include <wsutil/glib-compat.h> to allow use of g_list_free_full() withAndersBroman1-0/+1
older glibs. Change-Id: I3eb7e178dcb844ddbac47f53f221a98e2d32f413 Reviewed-on: https://code.wireshark.org/review/20334 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-28Qt: Fix -Wshorten-64-to-32 warningsStig Bjørlykke9-16/+16
Fix some warnings when building with -Wshorten-64-to-32 flag for C++ code. Fixes for warnings from QList, QTimer and QVector has been pushed upstream, so some time we may be able to enable this flag for C++. Change-Id: Iae7457f9afc469c63f3edbe23dbf272b5c6c9e5e Reviewed-on: https://code.wireshark.org/review/20310 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-02-27Qt: Avoid null pointer dereference (CID 1401573)Stig Bjørlykke1-2/+3
Change-Id: I638174a05c6275baf54e000d941f47f8ba572169 Reviewed-on: https://code.wireshark.org/review/20302 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-02-27print_stream: free memory on exit.Dario Lombardo1-0/+1
Change-Id: I6c4acaa9026cfdf1d4230c28c30bccfb6c025cef Reviewed-on: https://code.wireshark.org/review/19920 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-26Fix error: extra ';' after member function definition [-Werror,-Wextra-semi]Joerg Mayer1-2/+2
Change-Id: I53aee8f259c3e855bf71160bbfd1d79254a5cdf4 Reviewed-on: https://code.wireshark.org/review/20290 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-02-26Qt: Enable/disable Capture Interfaces buttons consistently.Gerald Combs1-6/+3
The "Compile BPFs" and "Start" buttons need to be enabled and disabled at the same time and according to the same criteria. Make sure we do so. Change-Id: I708886564dcf569cd71f936119195209ef6dcbd5 Reviewed-on: https://code.wireshark.org/review/20265 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-02-26[Automatic update for 2017-02-26]Gerald Combs7-4423/+4621
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I3094033ff26c1d8da5abcc22a25e4075f6bc087f Reviewed-on: https://code.wireshark.org/review/20285 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-02-26apply_line_edit(.h): fix extra ';' inside a class [-Wextra-semi] (clang) / ↵Alexis La Goutte1-2/+2
extra ‘;’ [-Wpedantic] (gcc) Change-Id: Ie75da8de308a5fe3a063cf929d0bb2ab739ad96f Reviewed-on: https://code.wireshark.org/review/20276 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-26preferences_dialog (Qt): fix commas at the end of enumerator lists are a ↵Alexis La Goutte1-1/+1
C++11 extension [-Wc++11-extensions] Change-Id: I9781fea02e7578f7d940c050a6f405bfe4b347dd Reviewed-on: https://code.wireshark.org/review/20278 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-26pluginif: Adapt code for Qt4.8Roland Knall1-0/+15
Change-Id: I663bb39cc6b186228bee01946c705eb6e12a8a0a Reviewed-on: https://code.wireshark.org/review/20280 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-02-26Bugfix for extcap fileselect functionality, start button in extcap options ↵Kim Bäckström1-1/+3
dialog wouldn't get enabled if the user had selected a file (and mustexist=true wasn't specified). This commit also contains minor fixes to doc/README.extcap, it's now more aligned to the actual implementation. Added example usage of fileselect, radio and multiselect to doc/extcap_example.py. Change-Id: Ibfe40a35a26f49322fbe64c0594506a2163f7e20 Reviewed-on: https://code.wireshark.org/review/20274 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-02-25Revert "Qt: call cleanup from destructor in WiresharkApplication."Peter Wu1-2/+1
Calling cleanup() twice (via exit signal and via destructor) results in a use-after-free on exit via write_profile_recent. This reverts commit e47f9fbeb090a68f9229b0f03c3f76a6285d2dff. Change-Id: Ic3ca0742c03a345fd8cb7f3f782942872a3057f5 Reviewed-on: https://code.wireshark.org/review/20273 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-02-25Replace "n/a" with an em dash.Gerald Combs3-6/+8
Replace occurrences of "n/a" with an em dash. It matches what we do elsewhere and reduces the need for translation. Change-Id: Ib5b63be765b7da9ae3e66ab19bd25cb497fd722d Reviewed-on: https://code.wireshark.org/review/20267 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-24Qt: Code cleanupStig Bjørlykke2-62/+48
Remove whitespace to match coding style used in file. Change-Id: I4c1649aa02087cd39b2f516db6e40749899c5125 Reviewed-on: https://code.wireshark.org/review/20260 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-02-24PluginIF: AdditionalToolbarRoland Knall12-9/+1129
Creates an interface for plugins and other parts of the code, to add a new toolbar to the system and have various widget types interact with this toolbar. All toolbars added via this interface, will be added to an additional submenu called "Additional Toolbars" within Wireshark. Also a demo plugin is being provided, demonstrating various features of the toolbar, including updating the gui elements. It also demonstrates how to update toolbar items. Change-Id: I8d0351224b3d7f4b90220d58970b51695551d7e3 Reviewed-on: https://code.wireshark.org/review/19803 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-02-22Qt: call cleanup from destructor in WiresharkApplication.Dario Lombardo1-1/+2
This allow the correct cleanup routine to be called both when user exits and when application exits by itself (like in WIRESHARK_QUIT_AFTER_CAPTURE=1). Change-Id: I88e468bde029b4247ac90616f3aba0065a2b8e00 Reviewed-on: https://code.wireshark.org/review/20210 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-22Qt: free memory used by rtd_tables.Dario Lombardo2-2/+4
Change-Id: Ibb6e3327127840fd01c5410c145ccec07efa4c73 Reviewed-on: https://code.wireshark.org/review/20209 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-22extcap: Reduce number of scans and storageRoland Knall2-2/+9
Reduce the number of storage arrays and the number of necessary loads. Also include cleaner methods for reloading the interfaces and cleanly reload if asked by the overall system Change-Id: I529465ec2593d40c955c6cdeaf3a85e3021c0596 Reviewed-on: https://code.wireshark.org/review/20230 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-02-22Qt: Avoid flicker in filter expressions toolbarStig Bjørlykke1-1/+7
Calling adjustSize() on the display filter toolbar causes flicker in the filter expression toolbar when switching between profiles without buttons and in some cases changing to a profile without buttons. Only calling adjustSize() if adding buttons should be fine to avoid this issues, even if they may be caused by something else. Change-Id: I8cca84a51dbbc8244dc4342ac0466e35884c294d Reviewed-on: https://code.wireshark.org/review/20222 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-21Qt: Handle cancel in import coloring rulesStig Bjørlykke1-4/+6
Change-Id: I450cfc41d19c0dcb4aa59c0515d8d0834cfee60b Reviewed-on: https://code.wireshark.org/review/20223 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-02-21Get rid of unused variable.Guy Harris1-1/+0
Change-Id: I684ce34b33e8abc596b9109068e302db57f85115 Reviewed-on: https://code.wireshark.org/review/20220 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-21Have all the remote host list routines' names begin with recent_.Guy Harris4-18/+19
Some did, some didn't - make it consistent. Clean up some header comments while we're at it. Change-Id: I978c84167cce3c8f1c0280898aa4d0b60958325b Reviewed-on: https://code.wireshark.org/review/20218 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-21Have a routine to iterate over the remote host list.Guy Harris4-12/+17
Have a routine that iterates over the remote host list if it exists. Remove the routine to get the remote host list; all accesses should be through functions in ui/remote.c. Change-Id: Idddceba76b50ce85ef8557e132d7552191c2fddc Reviewed-on: https://code.wireshark.org/review/20217 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-20Calling g_hash_table_size with a NULL argument causes a GLib-CRITICAL.Joerg Mayer2-1/+5
This fixes the first issue appearing in the log of Bug: 13418 Change-Id: I2fe68a06dd4a19be8300ec34be65a8dc47d0f8b3 Reviewed-on: https://code.wireshark.org/review/20214 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-02-20Yell at the user less.Gerald Combs8-34/+34
Our user-facing messages should have a helpful (or at the very least neutral) tone. In English, exclamation points are neither. Replace a bunch of them with periods. Change-Id: I29c3b2f84c25e06aae5b559860224559053a0378 Reviewed-on: https://code.wireshark.org/review/20189 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-18 17:47:49 +0000