aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2015-02-18Fix QCustmPlot retina problems.Gerald Combs2-0/+24
Make sure our intermediate pixmaps have the same number of pixels as the screen. A merge request with the same changes has been made upstream. Change-Id: I19950181d52f347e3aa7f5abb6e9ad33a4097abf Reviewed-on: https://code.wireshark.org/review/7224 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-18Make UAT record update callbacks return a success/failure indication.Guy Harris1-3/+1
Have them return TRUE on success and FALSE on failure. Check the return value rather than whether the error string pointer is null or not. Change-Id: I800a03bcd70a6bbb7b217cf7c4800e9cdcf2189c Reviewed-on: https://code.wireshark.org/review/7222 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-17[Qt] don't clear the display filter when a capture file is closedMartin Kaiser1-6/+0
Bug: 10951 Change-Id: I958aa9e88c30ac20cd7d7971ee903ac97265c1f4 Reviewed-on: https://code.wireshark.org/review/7098 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2015-02-17Set a window icon for WiresharkDialog.Gerald Combs1-0/+1
Otherwise it ends up with a generic icon. Change-Id: I47292c966332073d07ef358316cf8b40bcf1329b Reviewed-on: https://code.wireshark.org/review/7200 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-17Fix up formatting and indentation a bit.Jeff Morriss1-44/+53
Change-Id: Ifdc6b8b2525efdc9e0f73519e73afbd4adbf65f4 Reviewed-on: https://code.wireshark.org/review/7191 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-02-16Make get_manuf_name return a const string.Michael Mann1-2/+2
Model get_manuf_name after get_ether_name so that a string (either name resolved or colon-separated bytes) is always stored in a hash table. This will make name resolution of addresses perform a little better because it doesn't have to worry about the wmem_allocator. Change-Id: If976fe7b0c3f9cd053225096c2ac05418f061af6 Reviewed-on: https://code.wireshark.org/review/7081 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-16Qt: fix "Assigned value is garbage or undefined"Peter Wu1-151/+115
Clang Static Analyzer reported that function link_changed uses a garbage value for "device.links" which is indeed the case when global_capture_opts.all_ifaces->len == 0. There seem to be some issues here: - When global_capture_opts.all_ifaces->len == 0, then device is uninitialized. - When no interface name matches, the last entry will always be updated. - There is duplicate code querying for the interface by name. This patch addresses the above issues by extracting the interface name check into a new utility function which returns NULL when a device is not found. Then the callers (such as link_changed) will check this value. While at it, stop storing a copy of (interface_t), use a pointer instead. This allows for removal of g_array_remove_index followed by g_array_insert_val. Verified with clang 3.5.1. Change-Id: I03e0f179577a23a3f1efdca768e67922273192f0 Reviewed-on: https://code.wireshark.org/review/7145 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-15Fix handling of invalid UAT itemsPeter Wu2-0/+6
If the UAT file failed a field check, then the user_data pointer may be empty. As a result uat_save() triggers an invalid write. (Discovered while working with a dfilter_macros file having duplicate names for bug 10957, caught by ASAN.) The second issue fixed in this patch is that the validity of an item is only calculated when a new record is added. So even if the user edits the UAT and makes the entry valid, it would not be saved. This is solved by adding a new uat_update_record() function which got wires up into GTK and Qt. Some open-coded g_array_index and UAT[_USER]_INDEX_PTR are also converted. Even after this patch, Qt has some issues with UAT handling. In particular, it saves new, but empty/invalid, items. It also it does not check individual fields when saving all fields (unlike Gtk). This patch focused on getting Gtk fixed first so ignores those existing issues. Change-Id: Ia35cfe9d2b793c65144ae7e29a1ed706b6668d99 Reviewed-on: https://code.wireshark.org/review/7120 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-15ui/gtk/*.c: Add editor modelines; As needed: Fix indentationBill Meier99-1443/+2723
Change-Id: I8cd9d9fe5f12c284f46b8f725766f681faccd753 Reviewed-on: https://code.wireshark.org/review/7138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-14WSUG and image updates.Gerald Combs2-6/+4
Update the protocol hierarchy, conversation, and endpoint sections of the User's Guide. When everything is an admonition nothing stands out. Make a series of "NOTE"s plain old paragraphs. Scale the new conversation and endpoint images to fit the page width. This looks funny in my browser but I'm not sure about the best way to fix it. Move image/compress-pngs to the tools directory. Use it to reduce the size of the WSUG and WSDG images. Fixup traffic table column names and window titles. Change-Id: I674342ed901fc64563b384ee5e1f35413736cb19 Reviewed-on: https://code.wireshark.org/review/7122 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-14Fix diagnostics macros and squelch a gcc warning.Gerald Combs3-8/+7
Both clang and gcc define __GNUC__. Make sure we account for that when defining diagnostic macros. Use DIAG_OFF + DIAG_ON to suppress gcc -pedantic warnings about frame_data. Get rid of packet_char_enc casts. Change-Id: Idbcc61bcdb35c1d20f185461c69451dcdf73bae9 Reviewed-on: https://code.wireshark.org/review/7106 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-14"Hide" hashether_t structure.Michael Mann1-3/+3
One use in a GUI function isn't really enough to justify making the structure public. Change-Id: Ic7dee275ba0a2bd4e19c06702a867417c5624c27 Reviewed-on: https://code.wireshark.org/review/7080 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-14Qt: Fix side effects of recent WiresharkDialog changes.Gerald Combs5-4/+7
Quit the application when the main window closes. This cleans up any other top-level windows that might be open. Don't dereference a NULL pointer when opening the sequence dialog from the VoIP calls dialog. Change-Id: I9902d40ead1c5f2e541b6d79f3d957228e4e9687 Reviewed-on: https://code.wireshark.org/review/7107 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-13Replace tabs by spaces when editor modelines has "expandtab"Bill Meier5-384/+384
Change-Id: If7a6f2697be732ae4f94ed8b845fd293c32510f7 Also: tabs-stops should be 8 Reviewed-on: https://code.wireshark.org/review/7100 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-13Qt: Allow shift-double-clicking on a frame link.Gerald Combs4-3/+10
You can open a new packet window in the GTK+ UI by holding down the shift key and double-clicking on a frame link in the protocol tree. Add this behavior to the Qt UI. Document the different ways of opening a new packet window and update the image. Change-Id: I55caf6cc8089a6c305fafd47b4870e7c69dbfb10 Reviewed-on: https://code.wireshark.org/review/7101 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-13Qt: Try to make some dialogs behave like windows.Gerald Combs2-3/+3
Initialize WiresharkDialog with a NULL parent. This should make its subclasses behave like independent windows. Change-Id: If84609eeba53a92780c0873a1243888998d2b26b Reviewed-on: https://code.wireshark.org/review/7094 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-02-13Italian translation updateVincenzo Reale2-556/+559
Change-Id: Ibf66f25a257051ba12c3fb9687ac57377117138f Reviewed-on: https://code.wireshark.org/review/7036 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-02-13Qt: Revert g6e88978 for main_status_bar.Gerald Combs2-9/+9
It made some slot signatures unusable. Change-Id: I0f7cdad9e84a5ffb2bdfe4042ac93b3ea19b4893 Reviewed-on: https://code.wireshark.org/review/7095 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-13Qt: Make WiresharkDialog act like a window.Gerald Combs1-1/+1
Set Qt::Window when we initialize QDialog. This should add a minimize button to most of the dialogs that need one. Change-Id: I8595dee9c6a28a4e0a8518213176ba10a6d8dcc6 Reviewed-on: https://code.wireshark.org/review/7093 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-13Qt: Double clicking a packet opens the packet window.Gerald Combs1-0/+2
Connect the packet list's doubleClicked signal to the main window's openPacketDialog slot. Change-Id: I5bc20c113fb1f22e2257fc1dbdef76c9920e05d0 Reviewed-on: https://code.wireshark.org/review/7092 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-13Qt: More #include → forward declarations.Gerald Combs27-106/+150
Change-Id: Ib6de71f801cd3053374b6c867370acd594dcd396 Reviewed-on: https://code.wireshark.org/review/7089 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-13Qt: ElidedLabel doesn't support rich text / HTML.Gerald Combs3-14/+24
Change-Id: Ia5ca9784c60325c01ba5e6378997008f8ef1dd6e Reviewed-on: https://code.wireshark.org/review/7091 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-13Try to fix compilation on OS X.Gerald Combs1-0/+1
Change-Id: I63d1f639bf5fd56aeaea112c797efedca8c0bf6e Reviewed-on: https://code.wireshark.org/review/7090 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-12Qt: Add the "new packet" window^Wdialog^Wwindow.Gerald Combs16-65/+469
Allow persistence across files. Preserve the use of "window" even though we're really a dialog. Update ByteViewTab and ProtoTree to support multiple instances. Remove the need for a cast in frame_data. Add more forward declarations. Change-Id: I50d3d9d1455b8ecc158a37218f9e41fe696d5ae2 Reviewed-on: https://code.wireshark.org/review/7086 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-12Revert ""Hide" hashether_t structure."Anders Broman1-3/+3
This reverts commit 297ef07b9b2f5b681234d0c31269996413262cbc. Change-Id: Id47f5fd221b631c95ca71e3f9315f5263bab22de Reviewed-on: https://code.wireshark.org/review/7077 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12Revert "Make get_manuf_name return a const string."Anders Broman1-2/+2
This reverts commit 797ea88aefc2f45dba7e77d2dcaebe68ac1a4fac. Change-Id: I9bc2cef0051d88c6374c6f1868b0250cba3edbd4 Reviewed-on: https://code.wireshark.org/review/7076 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12Make get_manuf_name return a const string.Michael Mann1-2/+2
Model get_manuf_name after get_ether_name so that a string (either name resolved or colon-separated bytes) is always stored in a hash table. This will make name resolution of addresses perform a little better because it doesn't have to work about the wmem_allocator. Change-Id: I80f465ae0845290255a659ab63310ac3cc35506e Reviewed-on: https://code.wireshark.org/review/7075 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12"Hide" hashether_t structure.Michael Mann1-3/+3
One use in a GUI function isn't really enough to justify making the structure public. Change-Id: I6d70b9bacbc0fa1898150f59c0c69779a6cd5d51 Reviewed-on: https://code.wireshark.org/review/7074 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-11capture_dlg.c: Fix (possibly valid) "Using uninitialized memory" MSVC2013 ↵Bill Meier1-4/+4
Code Analysis warning Change-Id: I849b731420d779b68ab4335eb8d06482ecd649e7 Reviewed-on: https://code.wireshark.org/review/7068 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-10Qt/C++: Change a bunch of includes to forward declarations.Gerald Combs37-45/+98
In theory this this should reduce compilation times. On my particular system it makes no difference but hopefully it will elsewhere. Change-Id: I570177d3ca4eec691c82d46b4dbbce74092aac1d Reviewed-on: https://code.wireshark.org/review/7060 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-10Add a "Sum" column to the Service Response Time (SRT) window.Kevin Grigorenko14-14/+27
The Service Response Time (SRT) window currently provides the columns: Index, Procedure, Calls, Min SRT, Max SRT, and Avg SRT. A Sum column has been found useful in some customer situations to understand the total time spent doing a set of procedures. For example, in one case we were trying to isolate whether most time was being spent on a client thread or in the act of making outbound calls. We knew the start and end time of the client call, so with the "Sum" of time spent in that period, we could isolate a particular set of procedures driving the slow down. Additional changes made in this patch: * Add " (s)" to Min, Max, Avg, and Sum columns to make it clear that times are in seconds. * Refactor out width and height constants used in calls to gtk_window_set_default_size in most of the SRT users into #define SRT_PREFERRED_WIDTH and SRT_PREFERRED_HEIGHT. Also increase the common width of 550 to 650 to account for the additional column. Change-Id: I20f152eecbcd0bbf69f71c6c6b9f9463e8867e23 Reviewed-on: https://code.wireshark.org/review/7047 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-09Use G_GINT64_MODIFIER when formatting g{u}int64 values.Guy Harris1-1/+1
Remove extra trailing blank from output while we're at it. Change-Id: Ie415afa76a3eaba630ee3d59b177b44de75413a4 Reviewed-on: https://code.wireshark.org/review/7046 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-09(Trivial) Fix printf-related 'Mismatch on sign' warningsBill Meier19-36/+37
Found by MSVC2013 Code Analysis Change-Id: I58063946dd558e98308c87b36eeac0ddbe1a6e79 Reviewed-on: https://code.wireshark.org/review/7045 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-09Fix use-after free in RTP playerPeter Wu1-0/+1
Clicking "Decode" in the RTP player triggered an ASAN heap-use-after-free in update_progress_bar(). Explicitly set progress_bar to NULL to prevent this. Change-Id: Ice3105a11642a1cc5a54b8fbdf7dbf0ed430d965 Ping-Bug: 10714 Reviewed-on: https://code.wireshark.org/review/6999 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-08Menubar (GTK): fix warning: no previous prototype for ↵Alexis La Goutte1-0/+1
‘set_menus_capture_start_sensitivity’ [-Wmissing-prototypes] Change-Id: I11c805b285d277ecb963622385154c310f6d1c67 Reviewed-on: https://code.wireshark.org/review/7032 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-08Multicast Stream: Move mcast_stream.[ch] to uiAlexis La Goutte8-65/+96
Preparation to add Multicast Stream Dialog on Qt (Add extern C...) Change-Id: Ic8bc39a18dba607d6da116df799de7847ce8e4c8 Reviewed-on: https://code.wireshark.org/review/6984 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-07Don't call the Bluetooth code's UUID type "uuid_t".Guy Harris1-2/+2
uuid_t is a data type provided by a number of environments, thanks to the Open Software Fuundation; calling the Bluetooth code's data type, which includes an actual OSF-style UUID as a member, "uuid_t" can lead to confusion and *does* lead to compile errors on platforms where, for better or worse, system headers such as <unistd.h> define uuid_t (and are included by, for example, Qt headers). Just rename it "bluetooth_uuid_t". Change-Id: Ic742723913ba4105cd3269dd24fc821147285176 Reviewed-on: https://code.wireshark.org/review/7017 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-07Add the profile name to the Coloring Rules window title.Gerald Combs1-1/+3
Matches GTK+ behavior. Change-Id: I3dedb1532b5e14cc18a3ff34fd5be89438912834 Reviewed-on: https://code.wireshark.org/review/7012 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-07WSUG: Update the Packet Colorization section.Gerald Combs1-1/+1
Change-Id: I0f880293bd185e202d230f0db1a6bc4cbe6cfbfb Reviewed-on: https://code.wireshark.org/review/7011 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-07Bluetooth/GUI: ATT: Add Server Attribute TableMichal Labedzki10-0/+743
It is a GUI+QT feature that introduce Bluetooth menu and "ATT Server Attributes" that present all handle+UUID pairs as table. User may copy cell value, row, selected rows or whole table within header. On activate user will go to packet that introduce UUID for specified handle. Change-Id: If17e53aff5feb89ededc740a595ba5882b90be5e Reviewed-on: https://code.wireshark.org/review/6911 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-02-07Fix RTP crash on RTP analysis attemptPeter Wu5-18/+17
The tap listener was handling rtpstream_tapinfo_t* types while other users was expecting a GList* instead. Fix this and avoid future confusion by replacing void* pointers. Ping-Bug: 10714 Change-Id: I66f62eaaed4a529714264bbf4e7ad1e72b46ce5a Reviewed-on: https://code.wireshark.org/review/6997 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-07Qt: Fix coloring rules reordering.Gerald Combs1-0/+1
Change-Id: I8bf36fffb3e3fc19c10c5f07db951cc5a4253556 Reviewed-on: https://code.wireshark.org/review/6998 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-07Qt: Add the Coloring Rules dialog.Gerald Combs17-133/+815
Merge in the old ColorDialog which was a placeholder for color_filter_add_cb. Change-Id: I48d188509f480b8514122b4011ac9d8790fcca10 Reviewed-on: https://code.wireshark.org/review/6996 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-06Qt: Fix preference change behavior.Gerald Combs5-41/+58
Main window: Keep track of our current layout and only change it if the preferences change. This keeps the panes from resizing. Re-select the current packet if the layout changes so that the proto tree and byte view aren't left in an invalid state. This fixes a crash similar to bug 10896. Search frame: Get rid of an invalid error message. Update coding style. I don't think any of these fix bug 10921 since Xiaochuan seems to get a crash immediately upon opening the dialog. Change-Id: I0e880a50d3c9ac1c6ae6a01034b05fd2249444f4 Reviewed-on: https://code.wireshark.org/review/6989 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-06Multicast Stream (GTK): fix crash when try to select a streamAlexis La Goutte1-1/+1
Change-Id: Iaaa9445ae99b37cfb1865251d50f38375f3eb272 Reviewed-on: https://code.wireshark.org/review/6985 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-04Qt: Add "Copy As..." to the Protocol Hierarchy stats.Gerald Combs3-10/+144
This implementation is slightly different compared to other dialogs since we have nested items. Tweak the bar highlight color look better on Windows while we're here. Change-Id: If0607c4624f304042fe3d6c8a941756b342e703d Reviewed-on: https://code.wireshark.org/review/6953 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-04HTTP2: Add tap for HTTP2 dissectorAlexis La Goutte4-0/+18
Change-Id: Ib13d9391b64dad19321a4399c95b95d7fb791284 Reviewed-on: https://code.wireshark.org/review/6421 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-02-04Convert val_to_str -> val_to_str_wmem.Michael Mann20-104/+241
This is mostly for GUI usage, but a few dissectors needed some "non-packet scope" conversions. val_to_str officially now uses wmem_packet_scope() Change-Id: Ic9413eeb3406d7a7683222b86709f3675d628d81 Reviewed-on: https://code.wireshark.org/review/6933 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-04Qt: Add the Protocol Hierarchy statistics dialog.Gerald Combs19-32/+654
Change-Id: I6872e323daca4798c638d764873f54c4c0dc0006 Reviewed-on: https://code.wireshark.org/review/6934 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-04Decorate declarations with G_GNUC_PRINTF() as appropriate.Guy Harris1-2/+4
Decorate val_to_qstring() and val_ext_to_qstring() similarly to val_to_str_wmem(); this squelches some compiler warnings. Change-Id: I86e102e7c0a1a135be9492b7d605001c5d922031 Reviewed-on: https://code.wireshark.org/review/6940 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-23 01:39:28 +0000