aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2013-04-02Rename cf_not_saved() to cf_has_unsaved_data() to clarify what itGuy Harris3-6/+6
indicates. (Note: "unsaved data" is more than just "unsaved changes"; it could also mean "temporary file that hasn't been saved anywhere".) svn path=/trunk/; revision=48709
2013-04-02Handle the case of there being no comment view.Guy Harris1-9/+11
svn path=/trunk/; revision=48708
2013-04-02Show the comment area only if we could write out the comments were theGuy Harris1-20/+22
user to enter any. svn path=/trunk/; revision=48707
2013-04-02Only enable Edit->Packet Comment... if we can save the file withoutGuy Harris1-1/+1
losing the packet comments, just as we now do in the GTK+ version. svn path=/trunk/; revision=48699
2013-04-02Add support for the initial direction indication. Irene will hookMichael Tüxen2-6/+38
it up to the GUI soon. svn path=/trunk/; revision=48696
2013-04-01Add routines to file.c to indicate whether:Guy Harris5-83/+22
a save can be done ("can" in the sense of "there's something to save" and in the sense of "we can write that something out"); a "save as" can be done (in the sense of "we can write what we have out"); there's unsaved data to save (which might be unsaved changes or might be a temporary file full of packets); and use them as appropriate. This means that the "unsaved data" indicator in the UI will be turned on for temporary files full of packets as well as for files with unsaved changes; that's what we want. svn path=/trunk/; revision=48693
2013-04-01If we can't write the capture out in a file format that supportsGuy Harris1-1/+1
per-packet comments, don't let the user add/edit/delete per-packet comments - they can comment all they want, but once Wireshark closes the file, those comments will be gone. svn path=/trunk/; revision=48692
2013-04-01Add a wtap_dump_can_write() routine that indicates whether WiretapGuy Harris3-24/+4
supports writing files with a given set of encapsulations and comment types. Use it, rather than asking for a list of file formats that support the given set of encapsulation and comment types and checking whether we got back such a list, or duplicating its logic. Having file.c use it means that nobody's using wtap_dump_can_write_encaps() any more; get rid of it. Instead, have a private routine that checks whether a given file format supports a given set of encapsulations *and* comment types, and use that internally. svn path=/trunk/; revision=48690
2013-04-01Define a collection of bits for different types of capture file comments.Guy Harris3-103/+116
For each capture file type, have a bitset of comment types supported by that capture file type. Add a Wiretap routine that, for a given file type, returns the bitset of comment types it supports. Have wtap_get_savable_file_types() take a bitset of comment types that need to be supported by the file types it returns. Replace cf_has_comments() with a routine that returns a bitset of capture file comment types in the capture file. Use those routines in the capture file dialogs; don't wire in the notion that pcap-NG supports all comment types and no other file formats support any comment types. (That's currently true, but we don't want to wire that in as being forever true.) svn path=/trunk/; revision=48689
2013-04-01Add a setTitlebarForCaptureInProgress() method to MainWindow, and use itGuy Harris3-1/+21
to set the title when we have a capture in progress. svn path=/trunk/; revision=48688
2013-04-01Get rid of main_capture_set_main_window_title(), as it just wrapsGuy Harris1-8/+2
set_titlebar_for_capture_in_progress(); make the call directly, to make it a bit clearer when it needs to be called (which helps us do the equivalent in the Qt version). svn path=/trunk/; revision=48687
2013-04-01Move the knowledge about what the window title should be toGuy Harris5-35/+51
ui/gtk/main_titlebar.c, with set_titlebar_for_capture_file() for either no capture file or an opened capture file and set_titlebar_for_capture_in_progress() for an in-progress capture. svn path=/trunk/; revision=48683
2013-03-31Add a setTitlebarForCaptureFile() and have it set the titlebar and theGuy Harris3-4/+22
"modified" indicator. For some reason, it's not getting called in all the right places. svn path=/trunk/; revision=48682
2013-03-31Rename set_display_filename() to set_titlebar_for_capture_file(), asGuy Harris3-5/+6
it affects more than just the file name, it also affects whatever "you have unsaved changes" indicator the UI provides. Put a comment in the Qt code as a reminder of how to set the "you have unsaved changes" indicator. svn path=/trunk/; revision=48680
2013-03-31Make the menu item for importing a hex dump text file be "Import fromGuy Harris8-12/+12
Hex Dump", to clarify that it's not some sort of "generic" import function, just one that can read a hex dump file. ("Import from Hex Dump Text" is another possibility.) Use that string in the dialog title as well. svn path=/trunk/; revision=48665
2013-03-30Move wireshark's display filter flag to -Y for consistency with tshark.Evan Huus1-5/+5
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8223 svn path=/trunk/; revision=48653
2013-03-30Have 'Capture file' and 'Stop after' extries left aligned in GTK+ 3 as well.Jaap Keuter1-23/+49
svn path=/trunk/; revision=48652
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus6-15/+15
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-28If wireshark is started with a file and a display filter, apply the displayEvan Huus1-9/+10
filter *after* initially reading the file so that we get the expected multi- pass behaviour and forward-looking filters (like response_in) work properly. svn path=/trunk/; revision=48615
2013-03-28Fix distcheck: put wssplash.h in noinst_HEADERS.Jeff Morriss1-0/+1
svn path=/trunk/; revision=48610
2013-03-28-Wmissing-prototypesAnders Broman1-1/+1
svn path=/trunk/; revision=48609
2013-03-28Follow up on bug 8416.Jaap Keuter14-73/+73
Remove C++ incompatibilities in GTK+ 3 code. svn path=/trunk/; revision=48606
2013-03-28From Michal Labedzki via ↵Evan Huus1-1/+3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8530 Enable "Decode As" for Bluetooth over USB. svn path=/trunk/; revision=48605
2013-03-27Add the new splash image. Designed by Elliott Aldrich. Switch the splashGerald Combs5-10/+1910
image from XPM to PNG+pixbuf. Remove old XPMs. svn path=/trunk/; revision=48600
2013-03-27Add an interface list icon. Some of the new capture icons were 1 pixelGerald Combs5-717/+902
too small, so add corrected ones. Add SVG versions of the new toolbar icons. Use consistent naming for alternate icons. Remove some no-longer-used XPMs. Add a script to compress PNGs using various utilities and run it. Regenerate the pixbuf includes using the smaller PNGs. svn path=/trunk/; revision=48591
2013-03-27Fix bug 8524 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8524) and ↵Irene Rüngeler1-18/+37
show the correct tooltips for the columns. svn path=/trunk/; revision=48587
2013-03-27From Jim Young via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8531 :Pascal Quantin1-3/+3
Fix compilation when building with HAVE_GTKOSXAPPLICATION svn path=/trunk/; revision=48585
2013-03-27From Peter Hatina:Anders Broman1-4/+6
We call capture_dlg_prep() and do_file_close() in wrong order. capture_dlg_prep() clears global options for currently running capture and then we get an assertation fail in capture_input_new_packets(). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8526 svn path=/trunk/; revision=48581
2013-03-26Add new capture toolbar icons.Gerald Combs3-13/+848
svn path=/trunk/; revision=48571
2013-03-26add explicit cast to avoid a compiler warningMartin Kaiser1-1/+2
svn path=/trunk/; revision=48568
2013-03-26More icon updates. Gerald Combs10-65/+3512
Use the PNG versions of the new application icons. Remove the XPM versions of the Wireshark application and capture icons. To paraphrase Zoidberg, XPMs are bad and we should feel bad. Remove xpm_to_widget_from_parent (which we weren't using and likely won't use in the future). Replace wiki_24.xpm (which was a GNOME or GTK+ stock icon IIRC) with the 16x16 and 24x24 versions emblem-web.png from GNOME icon theme 2.30.3. This version was used specifically because it's GPLv2 and later versions are GPLv3. Update image/README. svn path=/trunk/; revision=48565
2013-03-26Fix Coverity CID 990752: Unused pointer value. (column was previously unused)Chris Maynard1-9/+9
svn path=/trunk/; revision=48561
2013-03-26Fix c++-compat errors if WANT_PACKET_EDITOR is defined.Evan Huus1-7/+7
svn path=/trunk/; revision=48560
2013-03-26From Jim Young:Anders Broman3-5/+5
Add casts to support c++ when HAVE_GTKOSXAPPLICATION is defined. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8525 svn path=/trunk/; revision=48557
2013-03-25The capture options edit dialog is a dialog, not a menu, so don't useGuy Harris1-2/+2
GDK_WINDOW_TYPE_HINT_MENU, use GDK_WINDOW_TYPE_HINT_DIALOG. GDK_WINDOW_TYPE_HINT_MENU, at least on OS X with quartz-wm, causes the combo box for the interface type not to work, so GDK_WINDOW_TYPE_HINT_MENU breaks things. GDK_WINDOW_TYPE_HINT_DIALOG, at least on OS X with quartz-wm, causes the minimize and whatevertheheckthegreenbuttondoesize buttons to be clear and inactive, so maybe GDK_WINDOW_TYPE_HINT_DIALOG does something approximating the right thing. svn path=/trunk/; revision=48545
2013-03-25Add a few missing explicit castsPascal Quantin2-2/+2
svn path=/trunk/; revision=48544
2013-03-24add casts for ws_gtk_grid_attach_extended()Martin Kaiser1-9/+18
svn path=/trunk/; revision=48541
2013-03-24add missing castMartin Kaiser1-1/+1
svn path=/trunk/; revision=48540
2013-03-24Forget about the show and hide dance.Jaap Keuter1-8/+0
svn path=/trunk/; revision=48531
2013-03-24Set the height to fit the interfaces actually shown.Jaap Keuter1-2/+2
svn path=/trunk/; revision=48529
2013-03-24Redissect extra packet windows in all cases (that I know of) where weEvan Huus8-24/+79
redissect normal packet list. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8482 svn path=/trunk/; revision=48528
2013-03-24From beroset:Anders Broman1-9/+15
allow flexible resizing of graph_analysis.c items Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7418 svn path=/trunk/; revision=48525
2013-03-22Add Modelines Info (and remove some tabs)Alexis La Goutte1-3/+16
svn path=/trunk/; revision=48487
2013-03-22Fix "Decryption Key Warning " Dialog broken in revision 47005Alexis La Goutte1-8/+8
svn path=/trunk/; revision=48486
2013-03-22Fix "Advanced Wireless Settings" Dialog broken in revision 47003Alexis La Goutte1-10/+10
svn path=/trunk/; revision=48485
2013-03-22Remove minimize / maximize buttons for "Edit Interfaces / Remote Capture ↵Alexis La Goutte1-0/+3
Settings" Dialog svn path=/trunk/; revision=48483
2013-03-22After Revision 46500 ( Make "Edit Interfaces Dialog" modal )Alexis La Goutte2-0/+4
The "Advanced Wireless / Remote Capture Settings" is not on the top of Dialog Make "Advanced Wireless / Remote Capture Settings " Dialog modal too svn path=/trunk/; revision=48482
2013-03-22Make Dialog about "Decryption Key (List / Add / Edit)" ModalAlexis La Goutte1-1/+4
svn path=/trunk/; revision=48481
2013-03-22On Windows (Tested with XP and 7), the Add(New)/Edit Decryption Key Dialog ↵Alexis La Goutte1-0/+2
is not always in top (regarding Decryption Key Management Dialog) svn path=/trunk/; revision=48480
2013-03-21Idea from Michail Koreshkov via bug #8371. Open a referenced packet in a newEvan Huus1-2/+7
window when double-clicking with a modifier key held. The original suggestion was CTRL, but GTK didn't like that, so ALT was suggested as an alternative, but I think SHIFT makes more sense, since that's what browsers use (shift+click) to open links in a new window. svn path=/trunk/; revision=48470