aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2017-06-22Add support for "bool" and "display filter" types for UATs.Michael Mann3-6/+54
Filter expressions needs support for a checkbox (bool) and string field that verifies display filters. Change-Id: Idfbffd6cdb5abaee8914126a05d890e834c17306 Reviewed-on: https://code.wireshark.org/review/22340 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-21Qt: fix sorting of custom columns with multiple fieldsPeter Wu2-14/+37
Fields like "dns.time || http.time || smb.time" were sorted by column number before. Recognize when all fields are numeric values and then try to sort by number and otherwise fallback to a value comparison. In theory sorting should now also be a bit faster for custom columns because the columnn type is looked up once. Change-Id: Id40d7cce8080d05823d74459fc493ec6ebf80956 Reported-by: Laura Chappell Reviewed-on: https://code.wireshark.org/review/22317 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-21[sipstat] Update the Response Codes table.Anders1-2/+21
Change-Id: Iae6e49963ea94ba8a174342e25d2ca5494001e28 Reviewed-on: https://code.wireshark.org/review/22310 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-21Qt: display newlines in capture file commentsPeter Wu1-2/+2
Due to the use of HTML, whitespace (including newline) are shown as single horizontal space. Add a special case for newlines. Bug: 13819 Change-Id: Iefa2af7d2948ed18a3b7f8f4ee8cb90100bf3460 Reviewed-on: https://code.wireshark.org/review/22306 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-20Fix filter for "Next Packet in Conversation"Peter Wu2-76/+4
The "Previous/Next Packet in Conversation" actions accidentally overwrites more specific filters (like TCP port matching) by less specific ones (like IP addresses). This resulted in strange behavior where packets from different TCP streams were selected. Change-Id: Ifa93064e1db3777fa3c12e2220bbb0b36b9478fe Reported-by: Christian Landström Reviewed-on: https://code.wireshark.org/review/22274 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-06-20Fix Toggle indicator for searchRoland Knall1-3/+0
Removing the toggle indicator. Search behaves now the same as it does for e.g. in SublimeText Change-Id: I4523001b536caa116bcb989f0850aa769c6220f8 Reviewed-on: https://code.wireshark.org/review/22280 Reviewed-by: Roland Knall <rknall@gmail.com>
2017-06-20Qt: Rename "Filter Expressions" to "Filter Buttons"Stig Bjørlykke1-1/+1
Change-Id: I7adcb1d28d239bbc25d8a7a5969b34c6db84e022 Reviewed-on: https://code.wireshark.org/review/22277 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-06-20Qt: make Wireless Timeline a separate itemPeter Wu6-18/+29
Do not put the wireless timeline in the main view with splitters, it has a fixed size anyway and is not taken into account for layout and size calculations for the panes. Bug: 13776 Change-Id: I71da962950c3f1b215908674f4852afa76744343 Reviewed-on: https://code.wireshark.org/review/22242 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Simon Barber <simon.barber@meraki.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-20Qt: Turn off auto scroll when going to a packetStig Bjørlykke2-1/+17
When going to a packet (first, last, next, prev and specific) during capture we must turn off auto scroll to let the packet be shown in the packet list. Change-Id: If1c615eb4d422c3b4c0418114064f7a4a0b75b35 Reviewed-on: https://code.wireshark.org/review/22244 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-20Don't scroll back to the selected frame when we get name resolution updates.Jeff Morriss2-4/+12
With live or large capture files and asynchronous name resolution this can cause serious scrolling issues as the name resolutions come in. Bug: 12074 Change-Id: I1a5cca410c0608927b32e9e7107885370caf14d7 Reviewed-on: https://code.wireshark.org/review/22245 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-19Qt: Flush signals when disable protocolsStig Bjørlykke1-0/+4
When opening the enabled protocols dialog from a protocol preferences menu we must flush app signals to ensure a redissect is done. Change-Id: I512b8f6959aabcc15ccffc67615583ee9c60ceec Reviewed-on: https://code.wireshark.org/review/22224 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-06-19SearchBar - Focus on shortcut instead of closingRoland Knall2-3/+4
If the searchbar is already open focus on the bar and highlight existing test, instead of closing an already open bar Change-Id: I4f8ae2e903cb65c0ebca238f3bcc1c62b63b5c3b Reviewed-on: https://code.wireshark.org/review/22223 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-19Attempt to clean up addr_resolv flags by removing DUMMY_ADDRESS_ENTRYAnthony Coddington3-6/+6
Replace with easier to understand and already present NAME_RESOLVED given dummy address is always filled. Change-Id: If8464f89e88722aac70689749fe0d4a31c119db2 Bug: 13798 Reviewed-on: https://code.wireshark.org/review/22110 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-18[Automatic update for 2017-06-18]Gerald Combs7-240/+240
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I9a55ca147bd4e42b9caded98294597acfad99909 Reviewed-on: https://code.wireshark.org/review/22203 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-06-17Do not process UI events while reading from live capturePeter Wu1-6/+0
For at least Qt, the main_window_update callback is not necessary to make the stop button work. When restarting a live capture during a flood (via Ctrl-R), this callback actually results in an infinite loop in MainWindow::captureStop since the capture state never changes from FILE_READ_IN_PROGRESS. Remove this callback to ensure that the problematic pipeActivated / sync_pipe_input_cb / capture_input_new_packets / main_window_update / ... / on_actionCaptureRestart_triggered / testCaptureFileClose / captureStop sequence is avoided. Even though captureStop invokes capture_stop, I guess that this does not change the state because the pipeActivated callback is already active. Bug: 10917 Change-Id: I6ca4fa946963928b7bc8a53ca14f9a9a3a35eaa7 Reviewed-on: https://code.wireshark.org/review/22097 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-06-17Qt: fix hang on exiting Qt while loading capture filePeter Wu1-10/+29
testCaptureFileClose can also be invoked while reading an existing capture file (the original comment only applied to GTK+, not Qt). When the user quits Wireshark while reading an offline pcap, this could result in a confusing "Unsaved packets" dialog. Fix this by checking the actual capture session state. After fixing this, the next issue is that cf_close trips on an assertion ("cf->state != FILE_READ_IN_PROGRESS"). To address this problem, do not close the capture file immediately, but signal to the reader (cf_read) that this should be done (similar to the quit logic in GTK+). Bug: 13563 Change-Id: I12d4b813557bf354199320df2ed8609070fdc58a Reviewed-on: https://code.wireshark.org/review/22096 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-06-16Change some names to reflect Apple's new UNIX-for-Macs name.Guy Harris1-3/+3
{OS_X,os_x} -> {MACOS,macos}. Change-Id: Icebea6ab566c65996ee97bacb88fac7e84ec32de Reviewed-on: https://code.wireshark.org/review/22161 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-14[tap-rtp-common] Add EVS to mimetype_and_clock_mapAnders1-0/+1
Change-Id: I21b3d023c8644421059d84b0905ff264e991c8a8 Reviewed-on: https://code.wireshark.org/review/22127 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-13Fix the display of the IPv4 Hash Table in Resolved Addresses Dialog QT UIsfd1-2/+2
Was sign extending the key to 64-bit in Linux. GPOINTER_TO_UINT should not be stored in 'int', use guint. Change-Id: Ib4a994fdda5d69a589d3cffce644584103f2cd1d Reviewed-on: https://code.wireshark.org/review/22107 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-11[Automatic update for 2017-06-11]Gerald Combs7-3442/+3701
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ia8c543f56fc9d09e78174d76144577a99359cc39 Reviewed-on: https://code.wireshark.org/review/22067 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-06-10Put the non-filter part of epan/color_filters.h into wsutil/color.h.Guy Harris1-1/+1
Places that only need color_t, such as certain preferences, don't need the color filter stuff. Change-Id: I88fc2858454d04e659b323a8bc28b21d362ca3fb Reviewed-on: https://code.wireshark.org/review/22060 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-10Fix weird comment.Guy Harris1-1/+2
Change-Id: I4254b37b14631929681b5642dc44911019807cb1 Reviewed-on: https://code.wireshark.org/review/22058 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-07Qt: Wireless Timeline improvementsStig Bjørlykke2-15/+17
- Change keyboard shortcuts to Ctrl+Shift+[IOU] - Use UTF8_MICRO_SIGN in tooltip text - Change 0xffffffffffffffff with G_MAXUINT64 - Check for valid wlan_radio *ri before use - Small whitespace cleanups Change-Id: I9fa85c0d675ef3837510afaf5f1b723d89ac134c Ping-Bug: 13769 Reviewed-on: https://code.wireshark.org/review/21993 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Simon Barber <simon.barber@meraki.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-06-05Qt: Build wireless_timeline.cpp with -Wshorten-64-to-32Stig Bjørlykke1-1/+1
[...]/wireshark/ui/qt/wireless_timeline.cpp:190:50: error: implicit conversion loses integer precision: 'unsigned long' to 'guint' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32] guint half_window = (end_tsf - start_tsf)/2; ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~^~ Change-Id: I675408f8a6c0809588ce89b2b98e05d7bfb10ed9 Reviewed-on: https://code.wireshark.org/review/21969 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-06-05Add a timeline view for packets, with the timing data used to generate the ↵Simon Barber10-0/+849
display taken from the timing analysis done in the wlan_radio dissector. QT only. The timeline background is light gray, white for packets displayed in the packetlist, and blue for the currently selected packet. Packets are coloured according to the colouring rules foreground colour. The timeline can be zoomed with controls on the toolbar. At higher zoom levels the duration (NAV) field is plotted as a horizontal line to the right of a packet. The height of a packet in the timeline is proportional to the RSSI. The bottom half of the packet is only shown if it matches the display filter. Todo: Auto detect TSF timing reference point (start/end of packet) Add a scrollbar Add a ruler showing time Improve handling of focus. Do not display NAV for packets with bad FCS. Show related packets graphically Different Y axis modes - bandwidth/channel use display - different transmitters per line - background color from coloring rules Live capture support Change-Id: Ic31fffb0d6854966361ade7abb5c0be50db9a247 Reviewed-on: https://code.wireshark.org/review/20043 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-05Allow bigger snapshot lengths for D-Bus captures.Guy Harris16-41/+45
Use WTAP_MAX_PACKET_SIZE_STANDARD, set to 256KB, for everything except for D-Bus captures. Use WTAP_MAX_PACKET_SIZE_DBUS, set to 128MB, for them, because that's the largest possible D-Bus message size. See https://bugs.freedesktop.org/show_bug.cgi?id=100220 for an example of the problems caused by limiting the snapshot length to 256KB for D-Bus. Have a snapshot length of 0 in a capture_file structure mean "there is no snapshot length for the file"; we don't need the has_snap field in that case, a value of 0 mean "no, we don't have a snapshot length". In dumpcap, start out with a pipe buffer size of 2KB, and grow it as necessary. When checking for a too-big packet from a pipe, check against the appropriate maximum - 128MB for DLT_DBUS, 256KB for everything else. Change-Id: Ib2ce7a0cf37b971fbc0318024fd011e18add8b20 Reviewed-on: https://code.wireshark.org/review/21952 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-04[Automatic update for 2017-06-04]Gerald Combs7-3454/+3538
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I95d3c8d0ce5c4215730d461f00812d48fd697892 Reviewed-on: https://code.wireshark.org/review/21932 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-06-04Bugfix GTK Decode AsMichael Mann1-1/+1
Current layer number needs to be unconditionally saved after v2.3.0rc0-3740-ge1f84f985e, which increased the number of dissectors that use current layer number to determine Decode As value. Change-Id: Ib82370af94ea00613a337890369e228cffa1ed81 Reviewed-on: https://code.wireshark.org/review/21928 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-03Don't keep the pcap/pcapng link-layer header type as interface data.Guy Harris2-2/+0
Either 1) it can be determined from the libwiretap encapsulation type, in which case it's redundant information or 2) there *is* no pcap/pcapng link-layer header type for that encapsulation type, in which case you need to check for the attempt to determine it failing and handle that failure appropriately. Change-Id: Ie9557b513365c1fc8c6df74b9c8239e29aad46bc Reviewed-on: https://code.wireshark.org/review/21924 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-02Qt: Add version check for setTextInteractionFlagsStig Bjørlykke1-0/+2
This property was introduced in Qt 5.1. Change-Id: I3446886d65fbeaf011a69071b605b044e5205b60 Reviewed-on: https://code.wireshark.org/review/21895 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-01Qt: Enable unhiding all interfaces.Stig Bjørlykke1-1/+3
When having hidden interfaces it was not possible to unhide all in the "Manage Interfaces" dialog because prefs.capture_devices_hide was not updated when not having any hidden interfaces. This bug was introduced in g6eee29bf. Change-Id: If94c2e592eea60e6f1ef1ce2107ff9b2b27c3176 Reviewed-on: https://code.wireshark.org/review/21869 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-06-01Qt+prefs: Add a dark theme check and default colors.Gerald Combs1-0/+4
Add prefs_set_gui_theme_is_dark and call it in the WiresharkApplication constructor. Add a set of dark syntax color defaults. We could alternatively add a preference for the syntax foreground color, but that would imply adding a preference for the background color as well. Bug: 11131 Bug: 13738 Change-Id: Iefe135ed04e63372ed434c5b9759647c9f4046e3 Reviewed-on: https://code.wireshark.org/review/21827 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-01Qt: Disable -Wframe-larger-than= for ui_main_window.hStig Bjørlykke2-0/+14
The generated Ui_MainWindow::setupUi() can grow larger than our configured limit, so turn off -Wframe-larger-than= for ui_main_window.h. Change-Id: I550ff30ebe566b711c63f7a9d0276e5b06244407 Reviewed-on: https://code.wireshark.org/review/21866 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-05-31Qt: Capitalize "Select SACKs" in tcptrace graph.Stig Bjørlykke1-1/+1
Change-Id: I2d0b433fec482431f6ccfe6f8fe6576193fc7773 Reviewed-on: https://code.wireshark.org/review/21863 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-05-31Qt: Add cast to QByteArray.resize()Stig Bjørlykke1-1/+1
Change-Id: I651cf6e625b8c757820a1e879f3fbde99746ba88 Reviewed-on: https://code.wireshark.org/review/21860 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-05-30Qt: Add support to verify extcap capture filterMichael Mann1-6/+33
Bug: 11668 Change-Id: Ib218d87c1905e53ffdab4e3dd6f93ba2c3d07c8b Reviewed-on: https://code.wireshark.org/review/21770 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-05-29GTK: Bugfix not allowing extcap capture filters to be verified.Michael Mann1-1/+1
Matches Id45052f21ebb290bf92c201370584156a65f2e19 Change-Id: I2b097d176ec3ce0637af95d66d2f58b834c79ea2 Reviewed-on: https://code.wireshark.org/review/21783 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-29Qt: Fix capture filter verification for non-extcap interfaces.Stig Bjørlykke1-1/+1
Change-Id: Id45052f21ebb290bf92c201370584156a65f2e19 Reviewed-on: https://code.wireshark.org/review/21777 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-28GTK+Qt: Show Osmux Packet Counter on Telephony menuPau Espin Pedrol4-0/+26
Change-Id: I565b0d2d43dd98781f77a302a20bd841e3e4650e Reviewed-on: https://code.wireshark.org/review/21598 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-05-27Qt: About dialog fails when configured without pluginsJaap Keuter1-2/+6
The about dialog compilation fails when plugins and LUA are disabled. Add the missing preprocessor statements. Also make the plugin tab really empty when there's nothing to report. Change-Id: Idba0dc86e7110e56b2d949f517c966a121d28e47 Reviewed-on: https://code.wireshark.org/review/21768 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-26Report syntax errors in UAT prefs parsingPeter Wu1-2/+8
Add the cause for a syntax error while parsing UATs. Example output: $ tshark -ouat:ssl_keys:, tshark: Invalid -o flag "uat:ssl_keys:,": ssl_keys:1: No IP address given. $ tshark -ouat:unknown:, tshark: Invalid -o flag "uat:unknown:,": Unknown preference Change-Id: I549406c4e31a81d29f487ef47bdb3c22da084947 Reviewed-on: https://code.wireshark.org/review/21748 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-25GTK: Don't allow extcap capture filters to be verified.Michael Mann1-0/+5
There isn't an API to do it and if WinPcap isn't present it can cause a crash. Change-Id: I5338f854acb26f0822ac027e6c853a550da3f7b1 Reviewed-on: https://code.wireshark.org/review/21758 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-25Don't try to compile capture filter if pcap_compile isn't available.Michael Mann2-6/+24
This is most likely due to WinPcap not being installed. Bug: 13672 Change-Id: Ic7069f98c7f8068cdc5045204c2e23ab56b3f7eb Reviewed-on: https://code.wireshark.org/review/21757 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-21[Automatic update for 2017-05-21]Gerald Combs7-335/+337
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I4a0774a6aa3ecb101b7ca0a87571544dc936012d Reviewed-on: https://code.wireshark.org/review/21723 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-05-19Qt: Add check for packet bytesStig Bjørlykke1-0/+8
Disable menu items handling packet bytes if not having any. Bug: 13723 Change-Id: I9cdb1185910f865c61a8ee74e3cf3177159bf315 Reviewed-on: https://code.wireshark.org/review/21710 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-05-19Qt: Check for no tvb in Show Packet BytesStig Bjørlykke1-0/+3
Bug: 13723 Change-Id: I145fe93fc05a9cfdc6c0fc949274a1e88dcf2f1e Reviewed-on: https://code.wireshark.org/review/21709 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-05-16sharkd: export uat records.Jakub Zawadzki1-42/+4
Move gtk's fld_tostr() to epan API as uat_fld_tostr. Change-Id: I01e3b66ca9ea3cd1e2e06e2122190ee42b9ad44b Reviewed-on: https://code.wireshark.org/review/21664 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14[Automatic update for 2017-05-14]Gerald Combs7-2560/+539
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ia7833dc62cb4f4687da664b66eba6c5f31437f9a Reviewed-on: https://code.wireshark.org/review/21630 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-05-12Don't include pcap headers if you don't have pcap.Guy Harris1-0/+5
Don't try to compile code that uses pcap if you don't have it. Change-Id: Ifa98b4ff47783f5347cb6e1129bbf4e5cac35aab Reviewed-on: https://code.wireshark.org/review/21611 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-11Put the HAVE_REMOTE hack into wsutil/wspcap.h, and include that file.Guy Harris3-39/+3
Have a header file that defines HAVE_REMOTE if HAVE_PCAP_REMOTE is defined, and then includes pcap.h. Replace all other includes of pcap.h, and the definition of HAVE_REMOTE, with includes of that file. Check for anything other than wspcap.h including pcap.h in checkAPIs.pl. Change-Id: I3cbee8208944ad6f006f568b3fe3134e10b2a883 Reviewed-on: https://code.wireshark.org/review/21605 Reviewed-by: Guy Harris <guy@alum.mit.edu>