aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2018-05-14Qt: MainWindow::dropEvent fixes.Gerald Combs1-1/+8
Limit our dropped file count to 100. Make sure we always accept our proposed action and either accept or ignore the event. Blind attempt at fixing bug 14609. Change-Id: Id08b179b6eb63529aa15bce7284460fbd19f7fec Ping-Bug: 14609 Reviewed-on: https://code.wireshark.org/review/27462 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-14Free g_ptr_array_free-related memory leaksPeter Wu1-3/+2
g_ptr_array_free(a, FALSE) returns "a->pdata". Callers that do not handle this will leak memory (e.g. "tshark -G plugins"). Convert other users to use the return value instead of direct access to "a->pdata". Change-Id: I29835477d587f5f54bf0d94cdae9f375e3da3ce3 Reviewed-on: https://code.wireshark.org/review/27437 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-13Remove a question from a comment.Guy Harris1-3/+0
Given that we're not using GTK+, the answer to the question is "no". Change-Id: Ib0e512909993830b1462d1fe3eada9265d9b1cdf Reviewed-on: https://code.wireshark.org/review/27515 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-13Get rid of some GTK+-only stuff.Guy Harris2-5/+5
Change-Id: I85806476246a567f747e3911e3d15716e9cfe06b Reviewed-on: https://code.wireshark.org/review/27514 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-13Fix indentation.Guy Harris1-2/+2
Change-Id: I15ddf53938ea23fce655b8ec558855a5e2bedf0c Reviewed-on: https://code.wireshark.org/review/27513 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-13Get rid of some GTK+-only stuff.Guy Harris2-6/+6
Change-Id: I841a1cdb637f37673466e4d065474c0f7e2dfc56 Reviewed-on: https://code.wireshark.org/review/27512 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-13[Automatic update for 2018-05-13]Gerald Combs7-8/+70
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Icf753ad9d075f2dd0688f0f58ce73d5e283dc10c Reviewed-on: https://code.wireshark.org/review/27486 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-12Get rid of some GTK+-only stuff.Guy Harris3-5/+5
Change-Id: I6c14429d4d473464ad7bea18dee07c3adf34664d Reviewed-on: https://code.wireshark.org/review/27479 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-12cli: make "-z host,ipv4" filter actually workPeter Wu1-8/+12
Respect the "ipv4" and "ipv6" filters and actually restrict the output. Change-Id: I06ee62ee2c85cb45fb33a52e86ce3698452d175f Fixes: v1.11.0-rc1-2592-ge3cccd17f4 ("Get rid of some users the addrinfo_list.") Reviewed-on: https://code.wireshark.org/review/27452 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-09Windows: Make sure native dialogs handle HiDPI.Gerald Combs2-80/+120
Enable per-monitor v2 DPI awareness before displaying native file dialogs so that they will render correctly on HiDPI displays. Add some notes about DPI awareness in our manifest and in wireshark-qt.cpp. Remove win32_get_ofnsize while we're here. Change-Id: Ic553fdeea0c05020c3a7ff06f648692cb814b3eb Reviewed-on: https://code.wireshark.org/review/27435 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-09ui/tap-rtp-common: fix some memleaksPeter Wu1-4/+10
If a stream with the given parameters was already known, the addresses and payload_type_name would be leaked. There are potential other leaks for rtp_stream_info_t (also in Qt RtpAnalysisDialog::showPlayer), but that requires a more careful analysis. Found by Clang Static Analyzer. Change-Id: I2fb19464b4c0f89d597a7e6117d219111922b4f2 Reviewed-on: https://code.wireshark.org/review/27346 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-09ui/voip_calls: fix memleak in is_mgcp_signalPeter Wu1-2/+6
Change-Id: I91226fc88f6e200c0c45ff74cc4232521e602fd3 Reviewed-on: https://code.wireshark.org/review/27345 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-09Qt: fix memleaks in CompiledFilterOutputPeter Wu1-4/+3
QString already copies the memory, no need to strdup it. Simplify use of GString as well (str is NUL terminated). Found by Clang Static Analyzer. Change-Id: Ic3ba3daa9121736529e0bee2d41adc95a55a3feb Fixes: v1.99.0-rc1-253-gdf8c4bf264 ("Capture Interfaces Dialog:") Reviewed-on: https://code.wireshark.org/review/27344 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-09Qt: fix memleak of profile name on copying a profilePeter Wu1-0/+1
add_to_profile_list (via add_profile_entry) clones the name and does not own it, so free it afterwards. Found by Clang Static Analyzer. Change-Id: I340c91b65d97b24a52812fd6f4b85933cfb15f89 Reviewed-on: https://code.wireshark.org/review/27343 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-09Always explicitly set tm_isdst before calling mktime().Guy Harris1-0/+1
Except in rare cases, we want to set it to -1 so that we let mktime() determine whether DST/Summer Time was in effect at the given date and time rather than pretending that we know whether it's in effect or not. Change-Id: I0ea75317dd308a515cedf4d1260b583e1592cc9b Reviewed-on: https://code.wireshark.org/review/27431 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-09Qt: remove unused vars in main_window_preferences_frame (CID 1435498).Dario Lombardo1-2/+0
Change-Id: Ibd20bdb3f88b3800d2bfa93e32d41c4827e24dcb Reviewed-on: https://code.wireshark.org/review/27421 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-09extcap: Fix required indicatorRoland Knall1-1/+9
Fix required indicator on reset and change an assert to a simple drop-out Change-Id: I355980223f213fef8ee4c6ac7d6bcb0fce1a7913 Reviewed-on: https://code.wireshark.org/review/27416 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-05-09Qt: Add Show as UTF-16 in Show Packet BytesStig Bjørlykke2-0/+14
Change-Id: Ia7c7af162ac0010e2a5b83caf1ac467012432567 Reviewed-on: https://code.wireshark.org/review/27420 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-09Qt: Add plural translationsStig Bjørlykke2-8/+9
Add plural translations in capture file dialog preview. Reworded text for "error after X records(s)" to use same format as similar messages. Change-Id: I7b2c8811a9c0c0f76587c5aad1a648a1b969f37a Reviewed-on: https://code.wireshark.org/review/27412 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-09Qt: Update frame selected in several casesStig Bjørlykke3-8/+15
Ensure that frameSelected(0) is emitted when not having a proto tree field selected because of: 1. No match when trying to restore selected field 2. Search selects a packet with no field to select 3. Current packet is deselected This will disable functionality which requires a selected field and updates the status bar according to selected field. Bug: 14658 Change-Id: I158fae4f26c02f718cee0030ef9e38b597876381 Reviewed-on: https://code.wireshark.org/review/27395 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-08Qt: fix IPv4 GeoIP lookup in endpoints dialogPascal Quantin1-1/+3
maxmind_db_lookup_ipv4() expects an address in network byte order Bug: 14656 Change-Id: Ie47e3ae44d305d040e409d42f4398f55ae8c2395 Reviewed-on: https://code.wireshark.org/review/27391 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Christopher Maynard Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-05-08extcap: Group argumentsRoland Knall3-27/+159
Group arguments together to better present them, as well as to have the possibility to better facilitate settings categories. The order of tabs is defined by the numbering of arguments and their appearance. If no tab can be found or no group has been defined for the argument, a default tab will be added. Change-Id: I032881193e09d4ad5d65c9f73fede87695acdace Reviewed-on: https://code.wireshark.org/review/27054 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-05-05Don't use dladdr() to get a pathname for the current executable().Guy Harris1-1/+1
Change-Id: I24ad11a659c2cb936f873339dc2b36ac9944280a Reviewed-on: https://code.wireshark.org/review/27359 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-04CMake: fix build by not unnecessarily linking with wsutilPeter Wu1-2/+1
When built with -DCMAKE_BUILD_WITH_INSTALL_RPATH=1, make-taps and make-dissectors fail to run because they cannot locate libwsutil.so.0. Since v2.9.0rc0-178-gbb81bef535 ("glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0") wsutil is definitely no longer needed. Change-Id: Ida269fdb5f2cba979e3776f57c1a6bf3d546fe5d Reviewed-on: https://code.wireshark.org/review/27329 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-03Qt: Add check for running toolbar reader threadStig Bjørlykke1-1/+4
Check if the reader thread is running before calling requestInterruption() in an attempt to avoid a crash when stop capture. Change-Id: I07cdc19eb42413ce421f05186314fc34c33041e6 Ping-Bug: 14631 Reviewed-on: https://code.wireshark.org/review/27316 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-03Qt: Fix toolbar signal on start captureStig Bjørlykke1-1/+1
Always call toolbar->startCapture() when starting a capture even if not having a list of interfaces. startCapture() will check for this. Change-Id: Ifb654f403c72e1d687ae1f6471fc955aa4f6f23c Ping-Bug: 14631 Reviewed-on: https://code.wireshark.org/review/27306 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-03Qt: Set margins in createEditor layoutStig Bjørlykke1-0/+2
Try to align the QComboBox with the other elements. Change-Id: I63acdc2eb463e8806edffe27d67423dc37d161e5 Reviewed-on: https://code.wireshark.org/review/27305 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-03Editorconfig: Add a filename match for Makefiles.Gerald Combs1-12/+0
The "Autotools, Make" section in .editorconfig didn't have an associated filepath glob pattern, which meant that it matched the preceding pattern, which was "*". This would appear to explain why VS Code mysteriously forced 8-character tabs for some files. Remove ui/qt/Makefile_custom.common while we're here. Change-Id: I5a84cc53c992bb2a95036cb98dc97cc7eb6b1299 Reviewed-on: https://code.wireshark.org/review/27281 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-02Qt: fix compilation with gcc 8Pascal Quantin1-1/+1
conversation_hash_tables_dialog.cpp:52:67: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers] Change-Id: I07c815a7233af41c840087a35eaf9172c06161f3 Reviewed-on: https://code.wireshark.org/review/27268 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-01Qt: do not further modify filename from Save dialogPeter Wu4-1/+29
Let the Save dialog fixup the extension on accepting the dialog. Otherwise it is possible that files are silently overwritten without prompting. Additionally, if a user decides to save a pcapng file as "foo.pcap", do not try to rename it to "foo.pcap.pcapng". This change is limited to macOS and Linux because Windows uses a different file dialog. Tested with both macOS and Linux. Bug: 14600 Change-Id: Ie0bc1f579766a04f0aad96dcd5daba3fffef9764 Reviewed-on: https://code.wireshark.org/review/27188 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-01Qt: improve extension selection in Save As dialogPeter Wu2-25/+88
The default Qt behavior for extension adjustment is quite bad. When the file type filter is changed, the extension always becomes "gz" because "pcap.gz" happens to be the first extension in the list. It also did not check that the last suffix is actually a valid extension (e.g. "capture.2018.01" became "capture.2018.gz"). Improvements: - Respect the "compression" checkbox when adjusting the filename. - Replace the extension only if it is a known one, append otherwise. - Use a better default extension (from "wtap_default_file_extension"). Affects only macOS and Linux since Windows has its own native dialog. See also https://bugreports.qt.io/browse/QTBUG-67993 Bug: 14600 Change-Id: I8cd0788f2abac0c6d7e29490b1ebb381f5a926d0 Reviewed-on: https://code.wireshark.org/review/27186 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-01Fix comment end after SPDX identifierStig Bjørlykke386-402/+788
Move */ to a separate line below the SPDX identifier. Change-Id: Id1032215449cfccae0933147b45e04b65e0b727f Reviewed-on: https://code.wireshark.org/review/27211 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-30Qt: Make the selected packet in the packet list more clear.Paul Zander1-12/+24
When using coloring rules the selected packet is sometime hard to recognize. The stylesheet of the packet list is extended for this. Bug: 14621 Change-Id: Ied465e0e211b3c11e69cb71f89988eb45622dd72 Reviewed-on: https://code.wireshark.org/review/27141 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-26Qt: fix crash on dragging in packet dialogPeter Wu3-6/+17
"packet_dialog.cpp" does not use setCaptureFile, resulting in a NULL dereference while trying to obtain the dissection context. Apply a fix similar to v2.5.1rc0-121-g9198448f9d (pass a fixed dissection context to ProtoTree). Additionally, fix a memleak and correct documentation. Why not add "proto_tree_->setCaptureFile(cap_file_.capFile())" in PacketDialog? Well, it also uses "proto_tree_->setRootNode(edt_.tree)" which means that "cf_->edt" would be different from "edt_". If that is the case, then "proto_construct_match_selected_string" will not return a filter for FT_NONE fields (see the call chain in proto.c). Bug: 14620 Change-Id: I6eeaf32b650a2095e15f64bbe64b54cdd545c7a9 Fixes: v2.5.0rc0-1608-g4d6454e180 ("Qt: Drag n Drop Filter expression from Packet Tree") Reviewed-on: https://code.wireshark.org/review/27160 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-04-25Qt: Fix various missing header includesRoland Knall3-0/+3
Qt 5.11 seems to have changed the include dependencies, so adding those, that are missing Change-Id: I2b0482f7554467d6981be65bfd3fea1a3e118976 Reviewed-on: https://code.wireshark.org/review/27145 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-24remove redundant break statementchinarulezzz1-8/+0
Change-Id: Ib6d4bbb1662d921fc4b5920b50e47d2b30ebb95c Reviewed-on: https://code.wireshark.org/review/27103 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-22[Automatic update for 2018-04-22]Gerald Combs1-10/+10
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0769900c468b88eb19304e697d2faecddaeb4b11 Reviewed-on: https://code.wireshark.org/review/27072 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-20SCTP: INIT collisionruengeler3-32/+101
Change-Id: I283ce92048af39ff4cf54e5e401e714bf6ec308b Reviewed-on: https://code.wireshark.org/review/27023 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-04-20Qt: fix invalid member access within expert info dialogPeter Wu1-11/+12
Opening a context menu in the expert dialog resulted in an UBSAN warning because ExpertInfoModel::data is invoked with a proxy model index. Rely on the proxy to perform this mapping (change filterActionTriggered to avoid direct model access while at it). Change-Id: Id399f44b954b87d7d4dd0341fbedb391ab1b13da Fixes: v2.5.0rc0-1966-gb0112e60ad ("Add a model to use for Expert Info dialog.") Reviewed-on: https://code.wireshark.org/review/27025 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-18Qt: expose CaptureEvent definition for MOCPeter Wu3-57/+84
All WiresharkDialog instances have a "captureEvent(CaptureEvent)" method that requires the definition of "CaptureEvent" from capture_file.h. By luck, this definition is available for CMake builds due to the generated MOC headers being included in the right order, but this cannot be relied on. On an autotools build with less luck: main_status_bar.moc.cpp: In static member function ‘static void MainStatusBar::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’: main_status_bar.moc.cpp:241:86: error: invalid use of incomplete type ‘class CaptureEvent’ case 28: _t->captureEventHandler((*reinterpret_cast< CaptureEvent(*)>(_a[1]))); break; Create a new header file to limit exposure of the CaptureFile class. Change-Id: I4ab609f13b9438797e39e7b98f367da35536979b Fixes: v2.9.0rc0-186-g57bf7e4347 ("Qt: Fix memory leak for CaptureEvent") Reviewed-on: https://code.wireshark.org/review/27003 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-18Remove autotools build system.Dario Lombardo3-1324/+0
It has been replaced by cmake. Change-Id: I83a5eddb8645dbbf6bca9f026066d2e995d8e87a Reviewed-on: https://code.wireshark.org/review/26969 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-17Qt: fix remaining CaptureEvent signal connectionsPeter Wu8-15/+15
Converted all remaining "CaptureEvent *" to "CaptureEvent" using: sed -e 's/CaptureEvent *\*/CaptureEvent/g' $(git grep -le 'CaptureEvent *\*') -i Change-Id: I328d2890ec3b5e6672fa3fab22e85063e8309574 Fixes: v2.9.0rc0-186-g57bf7e4347 ("Qt: Fix memory leak for CaptureEvent") Reviewed-on: https://code.wireshark.org/review/26985 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-04-17Qt: Fix memory leak for CaptureEventRoland Knall27-107/+117
Make the argument to the events a non-memory object Change-Id: I46d8c24415aa2bc48b2a2d3b1fccffa6956d08b5 Reviewed-on: https://code.wireshark.org/review/26671 Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-17Qt: Fix segfault bug when analysing SCTP packetsruengeler1-3/+3
Change-Id: Id444318621ffa61ee5edb84d40de372e8b7f60ef Fixes: v2.5.2rc0-26-gecda3d0901 ("tap-sctp: remove guint32 unneeded allocations.") Reviewed-on: https://code.wireshark.org/review/26977 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-04-17Switch the Doxygen API reference build to CMake.Gerald Combs4-174/+26
Switch to a single Doyxgen configuration which was generated using a recent version of Doxygen and customized to suit our needs. Add wsar_html and wsar_html_zip targets to CMake. Update some Doxygen markup and documentation as needed. Change-Id: Ic8a424b292c35a26f74ae0b53322265683e56e69 Reviewed-on: https://code.wireshark.org/review/26976 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-17Remove some GTK+-only code.Gerald Combs13-81/+7
Change-Id: Ic2498c7acd6a1a522be45094148402ee34a6b4d1 Reviewed-on: https://code.wireshark.org/review/26958 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-16Qt: Rename packet_list_enable_colorStig Bjørlykke4-4/+3
Rename packet_list_enable_color() to packet_list_recolor_packets() to reflect what it does. Remove the call from where it's not needed. Change-Id: I55dd1a9af8f5b1dbd83b06136a5bbcfddea06cdb Reviewed-on: https://code.wireshark.org/review/26959 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-16glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0Anders5-8/+0
Change-Id: Ie95cf37f9cd283545693e290340a7489cc989c95 Reviewed-on: https://code.wireshark.org/review/26970 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-16Qt: Do not show MaxMind DB path when not enabledStig Bjørlykke1-0/+2
The About dialog should not show MaxMind DB path when built without the MaxMind DB resolver. Change-Id: Id5b51628a04005fc4dcaacea26abb3a0ddee9b66 Reviewed-on: https://code.wireshark.org/review/26886 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-04-15More PortAudio removal.Gerald Combs2-2/+2
Change-Id: Ib56212e09d41fc76494d8186c77541302700104c Reviewed-on: https://code.wireshark.org/review/26952 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-27 12:52:17 +0000