aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2018-04-17Switch the Doxygen API reference build to CMake.Gerald Combs4-174/+26
Switch to a single Doyxgen configuration which was generated using a recent version of Doxygen and customized to suit our needs. Add wsar_html and wsar_html_zip targets to CMake. Update some Doxygen markup and documentation as needed. Change-Id: Ic8a424b292c35a26f74ae0b53322265683e56e69 Reviewed-on: https://code.wireshark.org/review/26976 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-17Remove some GTK+-only code.Gerald Combs13-81/+7
Change-Id: Ic2498c7acd6a1a522be45094148402ee34a6b4d1 Reviewed-on: https://code.wireshark.org/review/26958 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-16Qt: Rename packet_list_enable_colorStig Bjørlykke4-4/+3
Rename packet_list_enable_color() to packet_list_recolor_packets() to reflect what it does. Remove the call from where it's not needed. Change-Id: I55dd1a9af8f5b1dbd83b06136a5bbcfddea06cdb Reviewed-on: https://code.wireshark.org/review/26959 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-16glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0Anders5-8/+0
Change-Id: Ie95cf37f9cd283545693e290340a7489cc989c95 Reviewed-on: https://code.wireshark.org/review/26970 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-16Qt: Do not show MaxMind DB path when not enabledStig Bjørlykke1-0/+2
The About dialog should not show MaxMind DB path when built without the MaxMind DB resolver. Change-Id: Id5b51628a04005fc4dcaacea26abb3a0ddee9b66 Reviewed-on: https://code.wireshark.org/review/26886 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-04-15More PortAudio removal.Gerald Combs2-2/+2
Change-Id: Ib56212e09d41fc76494d8186c77541302700104c Reviewed-on: https://code.wireshark.org/review/26952 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-15[Automatic update for 2018-04-15]Gerald Combs2-2/+2
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I50b0c7211bfde3e0a17b4580e18fa423ab8fbdf1 Reviewed-on: https://code.wireshark.org/review/26953 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-15Gtk: Remove source codeRoland Knall230-142700/+0
Removing all gtk source code, except for main.? which will remain for the official removal during SFUS18 Change-Id: I4273baf207df1eaaa4b94623cfd10bf74b1fc4a4 Reviewed-on: https://code.wireshark.org/review/26937 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-11qt: capture file properties: add a splitterMartin Kaiser2-26/+52
Add a splitter to the capture file properties dialog. This allows for modifying the relative sizes of the details vs comment boxes. People who paste lots of text into the capture file comment may want a lager box for it. Change-Id: Id79d9f5fd7e589a2ba88aa5f16b52bb37d7c47ae Reviewed-on: https://code.wireshark.org/review/26845 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-04-11Qt: Disable collapsible children in the main window.Gerald Combs4-0/+14
Set the childrenCollapsible property to false in the main window splitters. Set the minimum size for the packet list, proto tree, and byte views to a small (one em), consistent, and nonzero value. Otherwise it's easy to inadvertently end up with a hidden main window view. Bug: 14478 Change-Id: I07a352cf2cf0375829ae2e0cb53b2a7d717dbb7d Reviewed-on: https://code.wireshark.org/review/26847 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-04-10Qt: Enable Emoji & Symbols selector againRoland Knall1-1/+1
Enable the emoji and symbols selector again. Change-Id: I4ceb54ef2bdc0a268f9ec1ded597fdc01f2137c2 Reviewed-on: https://code.wireshark.org/review/26839 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-09Qt: Fix MacOSX menu entriesRoland Knall2-0/+86
Remove various menu items added automatically on Mac OS X. The following menu items have been removed: - Edit / Start Dictation - Edit / Emoji & Symbols - View / Enter Fullscreen Mode - View / Show Tab Bar - Hide Tab Bar Bug: 13366 Change-Id: I44deae7ee8ea7a43926820e4f5d0517ece246939 Reviewed-on: https://code.wireshark.org/review/26823 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-09QT: keep cursor visible after completerion selectMichail Koreshkov1-0/+1
Before it was like this (display filter line edit "lost" focus) After press Enter in completion pupup, line edit stop show cursor. I was confused every time because without cursor it look like focus lost. But in fact focus is not lost and only cursor was disappear. Now cursor is not disappear Change-Id: I56979a1a774b6fb0b8b8be8239c01f5034c42fc8 Reviewed-on: https://code.wireshark.org/review/26781 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-09main window: don't keep a dangling freeze_focus_ pointerMartin Kaiser1-1/+2
Without this fix, Wireshark crashes when the user presses Ctrl-D or selects Edit / Ignore Packet and the current focus is somewhere on the bytes view. To ignore a packet, we protect the actual ignore operation by calling main window's freeze and thaw methods. We save a pointer freeze_focus_, pointing to the widget that has the focus, and restore the focus during thaw. This causes a crash if the focused widget is part of ByteViewTab. Ignoring the packet causes a redissection, the ByteViewTab and its children are cleared. freeze_focus_ remains non-NULL but doesn't point to a valid QWdiget any more. Calling freeze_focus_->setFocus() crashes. Fix this by using a QPointer<QWdiget> for freeze_focus_. The pointer is then reset to NULL when the QWdiget that it points to goes out of scope. Change-Id: Icc1f71a9de971284c628b7815a7fc1a5cc0d5fe2 Reviewed-on: https://code.wireshark.org/review/26693 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-08[Automatic update for 2018-04-08]Gerald Combs7-40/+75
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I85850833928dcf94e44957943c55126369c20905 Reviewed-on: https://code.wireshark.org/review/26799 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-06Remove some references to Qt4.Gerald Combs4-28/+5
Change-Id: I50f5abafb8adf18a5407427f7feb260301df45cc Reviewed-on: https://code.wireshark.org/review/26771 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-05QT: Copy as printableMichail Koreshkov1-1/+1
Copy all printable characters (like in GTK-based) but not only letters Change-Id: I5e431d0c52d65c5867f4893c86b6f0eb3f535972 Reviewed-on: https://code.wireshark.org/review/26757 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-05Qt: remove ws_buffer_start_ptr calls from clang-scan.Dario Lombardo2-0/+6
They are false positives. Change-Id: I06b5c2d2f7f462143050ffd4a624f76a440d5d5a Reviewed-on: https://code.wireshark.org/review/26729 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-04-05Qt: Remove checks for version below 5.2Roland Knall37-317/+52
This stops the main source from being buildable by Qt 4.x Change-Id: I61edbae04ac2b3bf0ae8ee8e09d335083945c176 Reviewed-on: https://code.wireshark.org/review/26756 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-04-05extcap: Reload values on requestRoland Knall8-44/+212
Allow certaing elements to be reloaded upon request. The way this works is, certain elements can be configured to be reloadable. By doing so, the extcap is asked once more just for the values list of this item, together with all already set options, and reloads the available options depending on the response. Only supported for selector. Radio and Multiselect will need additional patches, also moving those parts outside of extcap_argument.cpp might make sense before hand. Change-Id: I2e9e3d109b334bf878835a7cc9354f468bc22dee Reviewed-on: https://code.wireshark.org/review/26223 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-01[Automatic update for 2018-04-01]Gerald Combs7-34/+48
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0db4c4cd78549ffca3f55a94de5279c7ad131647 Reviewed-on: https://code.wireshark.org/review/26699 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-29Extend 'HTTP Referer statistics' to sequence HTTP RedirectsMoshe Kaplan3-7/+7
This patch adds support for sequencing HTTP Redirects. This enables tracking of HTTP-based redirects, which may not have a Referer header. As such, this patch also renames 'HTTP Referer statistics' to 'HTTP Request Sequences' to better reflect the more generic functionality. Note that this does not fully support RFC 3986. An external library like uriparser.github.io may be a better option for efficient, full relative HTTP URL resolution. A Sample PCAP to test functionality is available here: https://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=http_redirects.pcapng A sample PCAP to demonstrate usefulness is available here: https://www.malware-traffic-analysis.net/2015/08/31/page2.html (examine request to hxxp://lk2gaflsgh.jgy658snfyfnvh.com/service.php) Change-Id: I9edd1a1de86228b0dcb1df9f6f30e24379684321 Reviewed-on: https://code.wireshark.org/review/26679 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-03-28Qt: keep the extension in CaptureFile::fileName().Dario Lombardo1-1/+1
Change-Id: Iaecae7eea8398ae648bd31a0ae464242123f156b Reviewed-on: https://code.wireshark.org/review/26551 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-27tap: fix remaining potential memleaks with register_tap_listenerPeter Wu4-5/+33
Additionally, add an attribute to the tap function to prevent future callers from leaking this memory. Change-Id: Ief6af2bbc74d19153628f09d7b273e85cb2284ab Reviewed-on: https://code.wireshark.org/review/26642 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-26Qt: TCP Stream Graphs dialog updates.Gerald Combs5-15/+73
Add duplicate ACK ticks to Statistics → TCP Stream Graphs → Time Sequence (tcptrace), which I missed when porting from GTK+. Add zero window crosses while we're here. Switch TCPStreamDialog to a subclass of GeometryStateDialog. Add a slot and URL for the Help button and a stub entry in the User's Guide. Bug: 12009 Change-Id: Idf2ddb9eb33d924d65998285b5cffc234156497c Reviewed-on: https://code.wireshark.org/review/26592 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-25[Automatic update for 2018-03-25]Gerald Combs6-96/+0
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie7d9f2b00222e5ed4e05b5c3fc9100ad26e65084 Reviewed-on: https://code.wireshark.org/review/26635 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-25In some dialogs, have *no* auto-default buttons on macOS.Guy Harris2-2/+53
In macOS dialogs, there's a default button, which is the button that Enter/Return activates, and that Enter/Return *always* activates, *regardless* of what button has the input focus. To activate the button that has the input focus, you use the space bar. To implement that, we need to disable auto-default on all buttons, including the Cancel button. Put in a comment explaining all this. We may want to do this in all alert boxes, and possibly all dialogs with buttons. Change-Id: I214dd2870a9720ea705d8db39adc5b6af2003fb1 Reviewed-on: https://code.wireshark.org/review/26629 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-24wslua: Fix loggingPeter Wu1-1/+1
Always display Lua messages (to match tshark), do not send them to qDebug as they will not be visible with the default log options. Change-Id: I660a3877355891d45881b26735596ea6dc8a8b29 Fixes: v2.5.0rc0-2037-gc9b6887d84 ("wslua: Fix logger after g6a5e90f2") Reviewed-on: https://code.wireshark.org/review/26599 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-24OID name resolv: Fix MIB/PIB path presentationsJaap Keuter2-2/+4
oids.c: Sort out libsmi init, add user paths once. Qt, About WS: Stop memory leak of MIB/PIB paths. GTK, About WS: Allow for 20 individual paths. tshark, folders: init before getting paths, allow 20 individual. Bug: 14539 Change-Id: I113ee2dd4394d553a16b256e66fd840eeeec78ef Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/26555 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-23Qt: Remove a redundant include.Gerald Combs1-1/+0
Change-Id: I0f5e4227bebc98678344b28e835e1c7b26b57502 Reviewed-on: https://code.wireshark.org/review/26607 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-23Qt: ensure that taps are invoked on reload/rescanPeter Wu1-1/+2
Invoke the tap draw callback immediately after reloading a capture (or changing a display filter) rather than waiting for a timer to expire. Change-Id: I3d1549d1a18c8e173cd29d45f31ce7586e0d70fe Reviewed-on: https://code.wireshark.org/review/26600 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-21Qt: fix "Follow stream" in Conversations dialogPeter Wu4-16/+16
If no stream is given to FollowStreamDialog::follow(), then it overwrites the display filter with a conversation filter for the first packet in the capture file. Pass an explicit stream number and the "Follow stream" button will set a correct display filter. Test: open pcap with three TCP streams. Statistics -> Conversations. Select last TCP conversation (expect "tcp.stream eq 2"). Select the second conversation (expect "tcp.stream eq 1") and activate "Filter Out" button (expect "!(tcp.stream eq 1)" and not "!(tcp.stream eq 2) and !(tcp.stream eq 1)"). Bug: 14254 Change-Id: I28744d7f76f5034b07ea5660b45399566e3a7d2c Reviewed-on: https://code.wireshark.org/review/26520 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-20Note that exit_application() has UI-specific implementations.Guy Harris1-0/+1
Change-Id: I79d51dd4301451d4158d172d0b05094cb3d5d61b Reviewed-on: https://code.wireshark.org/review/26576 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-20Remove redundant declaration of exit_application().Guy Harris1-3/+0
Change-Id: I60c9236a53083f14d1f7b94c7db66172944d17bf Reviewed-on: https://code.wireshark.org/review/26575 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-20gui_utils(.c): fix no previous prototype for ‘exit_application’ ↵Alexis La Goutte1-0/+2
[-Wmissing-prototypes] Change-Id: I975fdc9ce7aa53208fc13cc76dcf0bb7a4a58bcd Reviewed-on: https://code.wireshark.org/review/26569 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-18Qt: allow keyboard navigation in Unsaved packets dialogPeter Wu2-0/+4
Currently the "Continue without Saving" button is visually highlighted in the "Unsaved packets..." dialog, but pressing Enter triggers "Save" instead. Even after changing button focus with arrow or tab keys, pressing Enter will not confirm the action (but Spacebar does). Restore the expected behavior for Linux and Windows, but preserve the fix for macOS since (for which this was originally added). Bug: 14531 Change-Id: Ic20fc5809b55949f6fd960bcb32618a4fa7fd1e9 Fixes: v2.3.0rc0-2672-gb0335359e5 ("Qt: Give discard button focus (but not as default)") Reviewed-on: https://code.wireshark.org/review/26511 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-18[Automatic update for 2018-03-18]Gerald Combs7-60/+28
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I9424882cb781156d38c634b91defcd45cd3f4743 Reviewed-on: https://code.wireshark.org/review/26528 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-18Qt: ensure field is visible on selection from bytes viewPeter Wu4-73/+5
Ensure that a selected field (via selectedFieldChanged) becomes visible in the packet details view when selected from the bytes view (or when found via a search). As making a field always visible seems a desirable feature (and in the interest of simplifying preferences), enable this by default using the smarter EnsureVisible hint. Remove the associated preferences and mark them GTK+ only. Change-Id: I05a918c1e09135c0b4e10f04024bff092756e55c Fixes: v2.5.0rc0-2383-g6b2764a41e ("ProtoTree behavior fixes.") Reviewed-on: https://code.wireshark.org/review/26509 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-17tap-tcp-stream: fix indentation.Dario Lombardo1-17/+22
Change-Id: I9ec60866dc674d9ec682afc6d644d78255182cac Reviewed-on: https://code.wireshark.org/review/26526 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17tap-tcp-stream: replace some g_malloc with g_new.Dario Lombardo1-3/+3
Change-Id: I25414be8ea73b986ea84294686a1d97159e1e2c7 Reviewed-on: https://code.wireshark.org/review/26525 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17tap-iax2-analysis: fix minor indentation issues.Dario Lombardo1-5/+9
Change-Id: I778fb32450e43a28b15e78e1e90ed7b69d4f341a Reviewed-on: https://code.wireshark.org/review/26524 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17tap-sctp: replace g_malloc with g_new.Dario Lombardo1-15/+15
When allocating structs this increases a lot the code readability. Change-Id: I86b26ea3debb400d6e1e8012206008740e528b23 Reviewed-on: https://code.wireshark.org/review/26523 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17tap-sctp: remove guint32 unneeded allocations.Dario Lombardo1-9/+6
They've been replaced by direct cast. Change-Id: I99fbc0463af724dc2592fbfe24a63c645902c703 Reviewed-on: https://code.wireshark.org/review/26522 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-15Qt 4.8 compatibility for escaping HTMLPeter Wu1-4/+4
Change-Id: I63fb59190b510b08db588ee8fe828f5df345d83a Fixes: v2.5.0rc0-2548-gf5a8711ef1 ("Qt: About dialog updates.") Reviewed-on: https://code.wireshark.org/review/26486 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-15Epan+Qt: Invalidate cached column strings.Gerald Combs7-12/+32
Add col_data_changed, which checks to see if we have updated column info. Add col_append_frame_number, which adds a frame number and sets col_data_changed. Call col_append_frame_number instead of col_append_fstr from some dissectors. Add PacketListRecord::invalidateAllRecords, which invalidates any cached record data. Add PacketListModel::invalidateAllColumnStrings which calls invalidateAllRecords and signals that our data has changed. Call invalidateAllColumnStrings when we have new name resolution or column information. Bug: 11414 Bug: 11468 Change-Id: I2671594a722f4f9436fe1df84d43489a148e0cee Reviewed-on: https://code.wireshark.org/review/26373 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-03-15tap-sctp: remove leak of sack and tsn (found by clang).Dario Lombardo1-1/+8
Change-Id: I829f117f8e19f60d34104730fbb0bc4504f231dd Reviewed-on: https://code.wireshark.org/review/26434 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-15tap-sctp: remove leak of tmp_info (found by clang).Dario Lombardo1-1/+7
Change-Id: If2eff49d5cf2ec4c0df5e9cafc1c69383502d8ae Reviewed-on: https://code.wireshark.org/review/26433 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-15tap-sctp: rework the memory allocations.Dario Lombardo1-121/+35
Change-Id: Iafab07cd5f83e94e92ef31d0183c42c6ec0c797c Reviewed-on: https://code.wireshark.org/review/26419 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-12Remove some unused or hard-coded header checks.Gerald Combs1-2/+0
Remove some unused checks and code found using grep -o 'HAVE_[A-Z0-9_]*' ConfigureChecks.cmake | sort -u \ | while read have_h ; do echo = $have_h ; git --no-pager grep -cl $have_h ; done Change-Id: I86bfcfdc4f60d9d7de87017a7bb00f833a79bd2c Reviewed-on: https://code.wireshark.org/review/26451 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-12Qt: Implement MulticastStatisticsDialog::treeItemDataGerald Combs2-0/+12
Implement MulticastStatisticsDialog::treeItemData so that the "Copy" button works. Bug: 14477 Change-Id: I8e7ff2a41b0f14e600b0781c3a01e03270c26ae7 Reviewed-on: https://code.wireshark.org/review/26430 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>