aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/sctp_graph_dialog.cpp
AgeCommit message (Collapse)AuthorFilesLines
2018-08-20Qt: fix several crashes in the SCTP DialogsVasil Velichkov1-21/+35
Store the association id instead of a pointer to the volatile "sctp_assoc_info_t" structure because it gets freed after a rescan. Bug: 14970 Change-Id: Id8fe2dfe3549bd711fc8ddef0770b217e83c2088 Fixes: v1.11.3-rc1-604-g796bf409b0 ("Add dialogs and graphs to analyse SCTP behavior similar to the GTK version.") Reviewed-on: https://code.wireshark.org/review/28711 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30SCTPGraphDialog: fix displaying a single TSNVasil Velichkov1-3/+2
When the SCTP association contains a single DATA/SACK chunk in direction the max and min TSN values are equal and as a result the Y axis range is (maxTSN, maxTSN) or (0, 0) and the dots for the TSN are not visible To fix this always set the Y axis maximum to maxTSN + 1 similar to the X axis maximum of max_secs + 1 Also removed one unused local variable Change-Id: Id38eb4dbd13a8ebbba98d4df00f3707331bd1464 Reviewed-on: https://code.wireshark.org/review/28862 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-23SCTPGraphDialog: Remove two unused membersVasil Velichkov1-7/+0
Those two members are leftovers from the gtk interface where a single button was used. Current Qt interface uses three buttons so those two members are no longer needed. Change-Id: I10e8c6aa887582e21ceec87bc3021a49abcc34dd Reviewed-on: https://code.wireshark.org/review/28834 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-07-23SCTPGraphDialog: Clear internal vectorsVasil Velichkov1-0/+16
Every time the graph is redrawn new items are added to the vectors but these items are never removed and the used memory increase over time which for larger captures could be problematic. Change-Id: I5f029d5f48e215aacf4a69fb7aef348d16df9846 Reviewed-on: https://code.wireshark.org/review/28782 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-06-08SCTP: Add a checkbox to show relative TSNsruengeler1-23/+60
Change-Id: I296cc5801e8a5184aea6bdc7fb841cce0c4f7b1d Reviewed-on: https://code.wireshark.org/review/28056 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-30Qt: fix memleak from cf_get_display_namePeter Wu1-1/+2
Free the memory as documented. Change-Id: I8a8842160be676bb08f5b93e795b9ed8edef2ede Reviewed-on: https://code.wireshark.org/review/27829 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16Windows: Make sure more native dialogs handle HiDPI.Gerald Combs1-2/+2
Add a WiresharkFileDialog class, which is a thin wrapper around a few QFileDialog functions that sets per-monitor v2 DPI awareness before showing native dialogs and resets the awareness context afterward. Use it where we call QFileDialog::getXXX. Change-Id: Ib711a70aa94b693a2515804a729f666ea7fbd673 Reviewed-on: https://code.wireshark.org/review/27568 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-01Fix comment end after SPDX identifierStig Bjørlykke1-1/+2
Move */ to a separate line below the SPDX identifier. Change-Id: Id1032215449cfccae0933147b45e04b65e0b727f Reviewed-on: https://code.wireshark.org/review/27211 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-20SCTP: INIT collisionruengeler1-7/+1
Change-Id: I283ce92048af39ff4cf54e5e401e714bf6ec308b Reviewed-on: https://code.wireshark.org/review/27023 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-02-08replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo1-1/+1
The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-02Qt: use SPDX identifiers.Dario Lombardo1-14/+1
Change-Id: I111945c08f99818c249a868c12d9a7b3a3df64b3 Reviewed-on: https://code.wireshark.org/review/25563 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-05Fix unitialized variable warnings that popped up with -OgJoão Valverde1-1/+1
Using GCC version 7.1.1. Change-Id: I7447a48fc97efb1eb15a016a29165f69d37f40a6 Reviewed-on: https://code.wireshark.org/review/23399 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-07-26Qt: Move utils to separate utils directoryRoland Knall1-1/+1
Following the move for widgets directory, moving utils to the utils directory. Guidelines for this directory are: - Generic use but not a widget - Utility functionality used by many classes Note: additionally all includes affected by this move have been changed to absolute path includes, instead of relative ones. Change-Id: I019ae4b6e6f6d06a5745a63ed195edbd36fb936b Reviewed-on: https://code.wireshark.org/review/22602 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-07-04Qt: add initializers (CID 1159357).Dario Lombardo1-1/+4
Change-Id: I27d561d8d63e0d15f7811dd7a033c38df17dfb36 Reviewed-on: https://code.wireshark.org/review/16271 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-23ui: Code cleanupStig Bjørlykke1-2/+2
Fixed code layout to use common style in the file. Mostly whitespace changes. Change-Id: Id37b57717a9e26248fad07322dff09b1d1f45ac2 Reviewed-on: https://code.wireshark.org/review/13504 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-05SCTP I-DATA supportruengeler1-4/+10
Change-Id: I459942b9e3287d500dda517568252d4cb56d3216 Reviewed-on: https://code.wireshark.org/review/10802 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Michael Tüxen <tuexen@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2015-10-05Move utf8_entities.h to wsutilJoão Valverde1-1/+1
Change-Id: I6298b3de5f0a1cb988014ff16082eaf8c2a3c3c0 Reviewed-on: https://code.wireshark.org/review/10786 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-01Revert "SCTP: Add I_DATA support"Michael Tüxen1-10/+4
This reverts commit 4e9361dc88eefef27d031e29e2f8ca9891cc03eb. Change-Id: Ia7aee9ffbe5bc5d3ae88e957c234cbee7b65f457 Reviewed-on: https://code.wireshark.org/review/10723 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2015-10-01SCTP: Add I_DATA supportruengeler1-4/+10
Change-Id: Ib8566b7d94fdafdb9735b356d129f378c94af3cf Reviewed-on: https://code.wireshark.org/review/10716 Reviewed-by: Michael Tüxen <tuexen@wireshark.org> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2015-06-25Qt: use <> for including the generated ui_*.h filesMartin Kaiser1-1/+1
this should make Visual Studio pick up the generated include files from the build directory instead of the source directory (which may contain lefovers from an in-tree build) Change-Id: Ie3de4cdd85a2865e203118a42ab10f443372f03b Reviewed-on: https://code.wireshark.org/review/9129 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-13Qt: More #include → forward declarations.Gerald Combs1-0/+11
Change-Id: Ib6de71f801cd3053374b6c867370acd594dcd396 Reviewed-on: https://code.wireshark.org/review/7089 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-04SCTP (Graph Dialog Qt): fix Copy-paster error (CID 1158585)Alexis La Goutte1-1/+1
Change-Id: I8939dbc8339284f9a1e515aff533d67ddbb6d469 Reviewed-on: https://code.wireshark.org/review/6274 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-31Qt: Convert more dialog titles.Gerald Combs1-1/+3
Change-Id: I9c3e3471a92b7af9347a541bece3d9405d37dce0 Reviewed-on: https://code.wireshark.org/review/6193 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-21Add minimize and maximize buttons to the SCTP analysis windows.Irene Ruengeler1-0/+5
As suggested by Jeff Morriss. Change-Id: Ibe2d30c31d51ab92377d64068527b424a92e8a64 Reviewed-on: https://code.wireshark.org/review/5361 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-20Limit the range to the TSNs provided.Irene Rüngeler1-4/+6
Change-Id: Ibf72fb60d06baa7a9590a303f2e10e5a86c61093 Reviewed-on: https://code.wireshark.org/review/254 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2013-12-18Add 'Filter Association' to context menu in packet list.Irene Rüngeler1-0/+4
svn path=/trunk/; revision=54219
2013-12-17Make translatable ready SCTP Graph for QtAlexis La Goutte1-10/+10
svn path=/trunk/; revision=54170
2013-12-17Find the right frame when plottable was clicked.Irene Rüngeler1-23/+53
svn path=/trunk/; revision=54167
2013-12-13Try to silence warnings and add a comment for Irene toMichael Tüxen1-2/+2
fix these appropriately next week. svn path=/trunk/; revision=54041
2013-12-13Add Copyright and modelines (Fix also indent to use 4 spaces)Alexis La Goutte1-0/+36
svn path=/trunk/; revision=54038
2013-12-13"Fix" 'set but not used' warning turning error.Jörg Mayer1-7/+7
svn path=/trunk/; revision=54029
2013-12-13Add dialogs and graphs to analyse SCTP behavior similar to the GTK version.Irene Rüngeler1-0/+399
svn path=/trunk/; revision=54026
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-19 14:48:51 +0000