aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/rtp_analysis_dialog.cpp
AgeCommit message (Collapse)AuthorFilesLines
2021-08-18RTP Analysis: CSV export has header lineJirka Novak1-0/+27
Export to CSV from RTP Analysis has header now. Header is on top of the export so for export of multiple tabs it is just once in the export.
2021-06-07Qt: Give a directory to wsApp->setLastOpenDir()Stig Bjørlykke1-2/+1
Use wsApp->setLastOpenDirFromFilename() to convert a filename to a directory name before calling wsApp->setLastOpenDir(). This will ensure to always store a directory instead of a filename in the recent gui.fileopen_remembered_dir.
2021-05-22VoIP Dialogs: Refactoring of singleton windows to factory methodsJirka Novak1-0/+28
Singletons moved from main_window to each class's static open<NameOfClass> method: - RtpPlayerDialog - RtpStreamDialog - VoipCallsDialog - RtpAnalysisDialog Fixed issue with selecting RTP stream in sequence dialog. When user selected a stream and moved mouse to Rtp Player button and pressed it, incorrect RTP stream was sent to it.
2021-05-04VoIP dialogs: Default actions for buttons works as beforeJirka Novak1-6/+14
When button is pressed or triggered by shortcut, it opens same window as before. User can click small arrow next to button and it open menu with all new actions e.g. Set/Add/Remove for RTP Player. Documentation updated.
2021-04-22RTP Player: Added button 'Refresh streams' for live capturej.novak@netsystem.cz1-12/+12
2021-04-15VoIP dialogs: Improvements and new functionsJirka Novak1-131/+46
Changes: - RTP Player added to Telephony/RTP menu. - When openning RTP Analysis or RTP Player from RTP menu, just selected stream is added. When Ctrl is hold during opening, reverse stream is searched and added too. - RTP Player: Added tool to select/deselect all inaudible streams - RTP Player: Added Prepare Filter button - RTP Player: Added Analyze button - RTP Analysis: Added Prepare Filter button - documentation updated Code changes: - RTP Player::rescanPacket() is not fired multiple times during rate change and during dialog creation - Error shown in RTP player is cleared after every new decode of streams - RTP Player handles case when Qt do not emit stop stream event - "Select" menu code unified between dialogs> - RTP Player: Audio routing menu unified - buttons are connected to actions by signals() - Analyze dialog is called by list of rtpstream_id, not rtpstream_info
2021-04-14VoIP dialogs: Performance improvementsJirka Novak1-9/+25
Retap and UI response are much faster when many RTP streams are processed. RTP Streams/Analyse 1000+, RTP Player 500+. Changes: - RTP streams are searched with hash, not by iterating over list. - UI operations do not redraw screen after every change, just after all changes. UI is locked when rereading packets. - Sample list during RTP decoding is stored in memory so wireshark uses just half of opened files for audio decoding than before. - Analysis window checkbox area is limited in height - Dialogs shows shows count of streams, count of selected streams and count of unmuted streams - Documentation extended with chapter about RTP decoding parameters - Documentation extended with performance estimates
2021-04-11WSUG: Added description of new features of telephony dialogsJirka Novak1-4/+4
Changes: - Added description of playlist idea and related operations - Added description of RTP Player dialog - Added description of VoIP Calls dialog - Added description of Flow Graph dialog - Added help link to Flow Graph dialog - Added description of RTP Streams window - Added description of RTP Stream Analysis window - Updated related past images
2021-04-11VoIP dialogs: Cleanups and clarifications based on work on WSUGJirka Novak1-8/+3
2021-04-10RTP Analysis: Fix of use of uninitialized structureJirka Novak1-1/+4
Fixes crash when RTP Analysis was called directly from Telephony menu.
2021-04-10RTP Player: Fix of opening of multiple dialogsj.novak@netsystem.cz1-1/+6
2021-04-07RTP Stream Analysis: Process more streams than two, audio save removedj.novak@netsystem.cz1-1018/+521
2021-03-30RTP Player: Dialog is nonmodal now and can be called multiple waysJirka Novak1-45/+30
Changes: - refactored main_dialog handling of telephony dialogs - RTP Player dialog is nonmodal now and can be left open - it is possible to issue three actions on RTP Player dialog from other dialogs (other dialog have selected set of RTP streams before action) - replace - removes existing streams from RTP dialog and shows new set - add - adds new set to existing list in RTP dialog - remove - remove streams in set from list in RTP dialog - Sequence Dialog: - was modified to hold rtpstream_info_t for RTP streams - added Play button - VoIP features (RTP Play button, select/deselect RTP stream) are disabled after creation and must be enabled. It handles that RTP Play button is not shown e.g. in TCP sequence show
2021-03-24VoIP UI: Added shortcuts for dialog buttonsJirka Novak1-1/+2
VoIP/SIP Calls, Sequence, RTP Streams, RTP Player and RTP Analysis dialogs have shortcuts assigned. Shortcuts are same over all dialogs.
2021-03-14Voice dialogs: Unified naming and order of buttons in dialogsJirka Novak1-5/+6
Dialogs has same order of buttons: - dialog specific (Flow Sequence, Find Reverse, Analyze, Reset Diagram) - common voice functions (Prepare Filter, Play Streams) - exports (Copy, Export) - Close of dialog Names were unified: - Copy really copying to clipboard - Save/Export was unified to Export
2021-03-10RTP player: It is possible to select SETUP packet related to RTP streamJirka Novak1-0/+2
When SETUP (or related signalling packet) exists, it is selected by Shift+G. If RTP stream is "alone", first RTP packet of the stream is selected.
2021-03-08Remove modelines in ui/qt.Gerald Combs1-13/+0
Remove the editor modeline blocks from most of the source files in ui/qt by running perl -i -p0e 's{ \n+ /[ *\n]+ editor \s+ modelines .* shiftwidth= .* \*/ \s+ } {\n}gsix' $( ag -g '\.(cpp|h)' ) then cleaning up the remaining files by hand. This *shouldn't* affect anyone since - All of the source files in ui/qt use 4 space indentation, which matches the default in our top-level .editorconfig - The one notable editor that's likely to be used on these files and *doesn't* support EditorConfig (Qt Creator) defaults to 4 space indentation.
2021-01-13Qt: fix build error with older GCCJoakim Karlsson1-2/+2
qt-5.12.2/include/QtCore/qstring.h:291:31: note: candidate 1: QString QString::arg(double, int, char, int, QChar) const Q_REQUIRED_RESULT QString arg(double a, int fieldWidth = 0, char fmt = 'g', int prec = -1, qt-5.12.2/include/QtCore/qstring.h:975:16: note: candidate 2: QString QString::arg(int, int, int, QChar) const inline QString QString::arg(int a, int fieldWidth, int base, QChar fillChar) const wireshark/ui/qt/rtp_analysis_dialog.cpp:926:77: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: [-Werror] .arg(abs(r_calc.start_time_ms - f_calc.start_time_ms), 0, 'f', 6) Change-Id: I6a27adff3b03bcfeac8fb56ceb0833d2707000b5
2021-01-11Qt framework: Dialogs are correctly notified when capture file was closedJirka Novak1-6/+0
The patch reintroduces WiresharkDialog::captureFileClosed() method and calls captureFileClosing() and captureFileClosed() in right order. Both methods call updateWidgets() at its end. All dialogs were reviewed and captureFileClosing/Closed methods updated when appropriate. captureEvent() method in multiple dialogs changed to captureFileClosing/Closed as it does same actions - looks like old style of detecting of capture file closing.
2021-01-07Telecom dialogs: Fixed issues during capture file closingJirka Novak1-6/+4
When capture file is closing/closed, dialogs do not disable buttons which can't work without capture file. Patch fixes it.
2021-01-02RTP analysis: Dialog uses common calculation functionJirka Novak1-88/+44
UpdateStatistics method uses common rtpstream_info_calculate function.
2021-01-01All RTP dialogs: Added option to specify count of decimal placesJirka Novak1-16/+16
Preferences are extended with advanced settings: gui.decimal_places1 - 2 gui.decimal_places2 - 4 gui.decimal_places3 - 6 rtp_analysis_dialog, rtp_player_dialog and rtp_stream_dialog uses new settings for formating numbers. Same information in all dialogs uses same settings. It solves request #15481. Note: Other UI dialogs can be adapted later.
2020-12-09Fix various spelling errors.Guy Harris1-1/+1
Found by lintian and by looking for the misspelled words that lintian found. (Does not fix spelling errors in .asn1 files.)
2020-10-01Qt: Use … instead of UTF8_HORIZONTAL_ELLIPSIS in translated strings.Gerald Combs1-2/+2
Run $ gsed -i -e 's/\(tr *(.*".*\)" *UTF8_HORIZONTAL_ELLIPSIS/\1…"/' $( ag -l 'tr *\(.*" *UTF8_HORIZONTAL_ELLIPSIS' ) $ gsed -i -e 's/\(tr *( *\)UTF8_HORIZONTAL_ELLIPSIS *"/\1"…/' $( ag -l 'tr *\( *UTF8_HORIZONTAL_ELLIPSIS *"' ) in ui/qt. As discussed in #16812, the UTF8_ macros were required at one time because we only allowed ASCII in our source code. However, that requirement has since been relaxed and Qt's translation framework doesn't handle concatenating strings and macros very well.
2020-03-31Qt+wslua: Add back progress bar titles.Gerald Combs1-1/+1
As part of the Qt migration we dropped support for showing progress bar titles. Add them back. Fix the title and task arguments in wslua. Change-Id: I76f008ff1f73e868a9b3833d24d355513692ae8b Reviewed-on: https://code.wireshark.org/review/36612 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-13Qt: Make sure shortcuts are visible in context menus.Gerald Combs1-0/+2
As of Qt 5.10, context menu shortcuts can be hidden: https://bugreports.qt.io/browse/QTBUG-61181 Add set_action_shortcuts_visible_in_context_menu to qt_ui_utils and call it for our context menus as needed. For Qt 5.{10,11,12} it calls QAction::setShortcutVisibleInContextMenu(true). For Qt 5.13 and later, call QStyleHints::setShowShortcutsInContextMenus(true) in WiresharkApplication. Change-Id: Ie8941951c3a9801b4642f4ce15ac217e37d1300f Reviewed-on: https://code.wireshark.org/review/35761 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-07rtp_player: Player is able to set start of audio play by double clickJirka Novak1-0/+9
Patch adds ability to set start of audio play by double clicking on waveform. Patch fixes unreported issue with placing waveform at incorrect place when switched relative/absolute time mode (check/uncheck Time of Day). Change-Id: Ib8ce24aea870e2443e033afbb6d6e9fbcf222431 Reviewed-on: https://code.wireshark.org/review/35621 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07rtp_analysis_dialog: Improved codec recognition during saving of audio to .auJirka Novak1-23/+31
I found that when codec is negotiated to nonstandard payload id, it was reported as unsupported even was supported. Patch fixes it. Change-Id: I4eb14fc22f83eb42300fc67baee8456dff65d191 Reviewed-on: https://code.wireshark.org/review/35575 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-21rtp_analysis_dialog.cpp: save any supported codec as .auJirka Novak1-148/+180
Change improves Wireshark ability to save rtp streams. It allows a user to save any supported codec with 8 kHz rate. In real, it means G.711 and G.729 for now. There is no hardcoded codec limitation during save anymore. If code detects unsupported codec or rate during save, it replaces samples with silence and reports it. Therefore any added codec in future will be supported. Note to RTP saving: RTP streams (there can be up to two of them for save) can contain multiple codecs in each direction - some of it can be supported and some unsupported. What should be exported then? Till my patch save do not run and a user received nothing even part of stream was OK/encoded with supported codec. Therefore I managed the code to start with export and do its best. Unknown codec/part is replaced with silence and user is warned after export. Therefore a user will get: a) audio - when all codecs are supported (no warning) b) mix audio/silence - when some codecs are supported (warning) c) only silence - when no codec is supported (warning) BTW same output user sees/gets in RTP player for years. Change-Id: Id938d419f5841af46d2d2d3ddfaf1ec9a0235bcc Reviewed-on: https://code.wireshark.org/review/35105 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-17Qt: Cleanup space inside parenthesesStig Bjørlykke1-6/+6
Remove randomly used space inside parentheses to make the coding style uniform. Add space after if, for and while. Change-Id: I519f5994b6f73d8a57a5004d51ca460276c618fe Reviewed-on: https://code.wireshark.org/review/35112 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03rtp_analysis_dialog.cpp: Correct src/dst info for two independent streamsJirka Novak1-2/+8
Display the source and destination for the second reverse stream in case it differs from the first forward stream. Change-Id: I117899acca47713a42efcfef28f893d9be26c337 Reviewed-on: https://code.wireshark.org/review/34915 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-03rtp_analysis_dialog: save as au: fix for streams with multiple codecsJirka Novak1-4/+23
When the stream contains a mix of G.711A/U and silence, the RTP Analysis dialog prevented it from being saved. Add an exception for silence to fix this. Change-Id: I46bb1392244ff0ba300c371fb5ccd110fbd59a7e Reviewed-on: https://code.wireshark.org/review/34901 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-10-02Qt: Do not use exec() in RTP dialogsTomasz Moń1-6/+8
Favor asynchronous show() as it does not create new event loop. Change-Id: I01982806f87705f04138f15ae8eb084f1d4f9b2c Reviewed-on: https://code.wireshark.org/review/34677 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-17Update to qcustomplot 2.0.1Alexis La Goutte1-1/+1
Upgrade the internal version of QCustomPlot to 2.0.1 Change-Id: I1eb372d8e6a2f6c1bbdde4c74596785bf2d405c2 Reviewed-on: https://code.wireshark.org/review/17980 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-08Qt UI: Warn about not saving non-PCM encoded audioJaap Keuter1-3/+13
When saving audio data from RTP stream(s) in Sun AU format we (still) do not harness the build-in codec framework. This results in empty Audio files for all but PCM encoded RTP streams. At least warn the user about the codec not being supported for saving in Audio file. Change-Id: Ia76caf71d0d5319a66dbf1cee517c0922bf7a561 Reviewed-on: https://code.wireshark.org/review/34466 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-30Qt: Add macro for g_list_next for C++Roland Knall1-3/+3
Using a simple (type *) cast on g_list_next results in a warning with modern compilers "old-style cast" Adding a warning for g_list_next and data access to avoid the warning A good overview why reinterpret_cast has been used can be found here: https://stackoverflow.com/questions/332030/when-should-static-cast-dynamic-cast-const-cast-and-reinterpret-cast-be-used It is a 1:1 replacement in this case, but does not use any of the new cast styles and therefore should be used with caution. Change-Id: I989f237afc39aaf40133a788b1c0bbd7a51bf974 Reviewed-on: https://code.wireshark.org/review/34284 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-27HTTPS In More Places, update some URLs.Guy Harris1-2/+2
Change-Id: Ice2e1e2e4d94f6c9da7c651866cfa1a8ac4a31d8 Reviewed-on: https://code.wireshark.org/review/34096 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-04-15Hava a routine to read the currently-selected frome.Guy Harris1-2/+2
Have cf_read_current_record() take a capture_file as an argument and read, into its wtap_rec and Buffer for the currently-selected frame, information for the currently-selected frame. Rename cf_read_record_r() to cf_read_record(). That gives us 1) a routine that reads the currently-selected frame into the wtap_rec and Buffer for the currently-selected frame and 2) a routine that reads an arbitrary frame into the wtap_rec and Buffer supplied to it. If you *want* the currently-selected record, use the former, otherwise use the latter. Change-Id: If6bd5915dd5bc18334d7b89859822a19234153a4 Reviewed-on: https://code.wireshark.org/review/32858 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-04-06Revert "Get rid of the per-capture_file wtap_rec and Buffer."Peter Wu1-18/+3
This reverts commit 9445403f9558901dc54c88754ff21795ea1803f3. cf_select_packet frees the buffer backing the dissection result (cf->edt) which results in use-after-frees when callers try to access the contents. See for example this call trace: * PacketList::selectionChanged * cf_select_packet(cap_file_, row) * frameSelected(row) -> ByteViewTab::selectedFrameChanged * addTab(source_name, get_data_source_tvb(source)) get_data_source_tvb returns the buffer that backs the dissection and must remain valid even after dissection has completed. If this is not done, then a possibly expensive redissection must be done in order to populate the byte view. The temporary memory savings are not worth it. Bug: 15683 Change-Id: Ia5ec2c7736cdebbac3c5bf46a4e2470c9236262d Reviewed-on: https://code.wireshark.org/review/32758 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-04-05Get rid of the per-capture_file wtap_rec and Buffer.Guy Harris1-3/+18
Most code that reads from a capture_file already has its own wtap_rec and Buffer; change the remaining ones to do so as well. Change-Id: I9b7c136642bbb375848c37ebe23c9cdeffe830c3 Reviewed-on: https://code.wireshark.org/review/32732 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-08Fixing some implicit coversations (-Wshorten-64-to-32)Uli Heilmeier1-9/+9
Fixing some "implicit conversion loses integer precision" warnings reported by clang with -Wshorten-64-to-32 option Change-Id: Icd641d5f4fd8ff129f03f1b9e1da0fc86329f096 Reviewed-on: https://code.wireshark.org/review/31901 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29Qt: Fix memory leak of QMenu.Stig Bjørlykke1-2/+3
Set the push button as parent to the save menu so it will be deleted when that parent is destroyed. Change-Id: Ic396dcf25092c90cd305a010be3d551d8ad8397c Reviewed-on: https://code.wireshark.org/review/31802 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-6/+6
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris1-1/+1
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-29Clean up the epan_dissect_t in the normal code path.Guy Harris1-0/+2
We initialized it, but only cleaned it up in an error code path, not in the regular code path. That could leak memory. Change-Id: Ic6689163ca58990fa5091b23e7ab2e0292eed76c Reviewed-on: https://code.wireshark.org/review/29930 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-06Use the file *base* name for statistics graphs etc..Guy Harris1-1/+1
For example, if the file is foo.pcap, make the default name for a saved PDF of some graph be foo.pdf, as it was prior to 2.6, not foo.pcap.pdf. Change-Id: Ide99c9c7fa1f3d16f829e731f968a209fbb52b8d Reviewed-on: https://code.wireshark.org/review/28624 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-03CaptureFile.fileTitle() is for display, not for file name processing.Guy Harris1-1/+1
Don't use CaptureFile.fileTitle() if you're constructing a pathname; use it only if you're constructing a window title. Change-Id: I40f225ddb07be2f7dc3ae03108dae816846f20c7 Reviewed-on: https://code.wireshark.org/review/28582 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-02Make arrays of 4 octets arrays of 4 guint8.Guy Harris1-8/+13
That makes it clearer that it's not a string, and avoids some type complaints from change Ida7b98af8c44a52ddac2c4ab0702db2519a0c4af. Update a comment while we're at it. Change-Id: I6737bb2a7ff3b4d461700c641cb580194f7809e7 Reviewed-on: https://code.wireshark.org/review/28572 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-25RTP: Common functions for allocation/deallocation of rtpstream_info_tJiri Novak1-7/+7
Change-Id: I9a0a11d238473a7c57d85547dca0713ed421a500 Reviewed-on: https://code.wireshark.org/review/28417 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-20RTP: Encapsulation of comparsion of two rtpstreamsJiri Novak1-163/+110
Changes: - rtpstream_id_t is introduced and its related functions. It encapsulates comparsion of two rtpstreams. - dest_* renamed to dst_* - src_port and dst_port are 16bits only. - sharkd_session.c use common id functions - IAX2 part related to RTP updated to common *id* function Change-Id: Id38728a4e5d80363480c7ce42ff9c6eaad069686 Reviewed-on: https://code.wireshark.org/review/28340 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-26 13:20:05 +0000