aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/iax2_analysis_dialog.cpp
AgeCommit message (Collapse)AuthorFilesLines
2018-02-02Qt: use SPDX identifiers.Dario Lombardo1-14/+1
Change-Id: I111945c08f99818c249a868c12d9a7b3a3df64b3 Reviewed-on: https://code.wireshark.org/review/25563 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-28Qt: use QVariant::String instead of QMetaType::QString.Dario Lombardo1-1/+1
They both have the value 10, but the checks are run against methods that return a QVariant::Type, then is formally more correct to use that. This also removes the need for a cast. CID: 1323929. CID: 1311958. CID: 1268202. CID: 1268201. CID: 1238868. Change-Id: I792c0e3b70b0f181867648d8f47a02c675200b10 Reviewed-on: https://code.wireshark.org/review/25036 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-27Apply new CaptureEvents to statistics dialogs.Michael Mann1-2/+11
Refactoring from If366d42b07dc822636404ac44ba2306ec4418b4e ignored dialogs outside of the main window. Searched for removed signals from CaptureFile class and applied new CaptureEvent handling. Change-Id: I9e0aaa0dc1c702ce04810d27c8f9273997f7ca30 Reviewed-on: https://code.wireshark.org/review/25007 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-12-08Have the frame_tvbuff.c routines not use the global cfile.Guy Harris1-1/+2
Have the routines that create them take a pointer to a struct packet_provider_data, store that in the tvbuff data, and use it to get the wtap from which packets are being read. While we're at it, don't include globals.h in any header files, and include it in source files iff the source file actually uses cfile. Add whatever includes that requires. Change-Id: I9f1ee391f951dc427ff62c80f67aa4877a37c229 Reviewed-on: https://code.wireshark.org/review/24733 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-12-04Put the structure of a capture_file back in cfile.h.Guy Harris1-1/+0
The split isn't necessary now that epan no longer uses the capture_file structure. Change-Id: Ia232712a2fb5db511865805518e8d03509b2167f Reviewed-on: https://code.wireshark.org/review/24693 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-12-03Use cfile.h to define the capture_file type.Guy Harris1-0/+1
Have cfile-int.h declare the structure, and use it in files that directly access the structure. Have cfile.h just incompletely declare the structure and include it rather than explicitly declaring it in source files or other header files. Never directly refer to struct _capture_file except when typedeffing capture_file. Add #includes as necessary, now that cfile.h doesn't drag in a ton of Change-Id: I7931c8039d75ff7c980b0f2a6e221f20e602a556 Reviewed-on: https://code.wireshark.org/review/24686 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-06Qt: fix RTP/IAX2 reverse stream export to CSVPascal Quantin1-2/+2
Bug: 14040 Change-Id: Idadfbd3b60124b5f7ac4ace275db94b10daf010a Reviewed-on: https://code.wireshark.org/review/23409 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-26Qt: Move utils to separate utils directoryRoland Knall1-3/+3
Following the move for widgets directory, moving utils to the utils directory. Guidelines for this directory are: - Generic use but not a widget - Utility functionality used by many classes Note: additionally all includes affected by this move have been changed to absolute path includes, instead of relative ones. Change-Id: I019ae4b6e6f6d06a5745a63ed195edbd36fb936b Reviewed-on: https://code.wireshark.org/review/22602 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-04-12Rename routines to clarify what they do.Guy Harris1-1/+1
XXX_prime_with_YYY makes it a bit clearer than does XXX_prime_YYY that we're not priming YYY, we're priming XXX *using* YYY. Change-Id: I1686b8b5469bc0f0bd6db8551fb6301776a1b133 Reviewed-on: https://code.wireshark.org/review/21031 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-28Qt: Fix -Wshorten-64-to-32 warningsStig Bjørlykke1-6/+6
Fix some warnings when building with -Wshorten-64-to-32 flag for C++ code. Fixes for warnings from QList, QTimer and QVector has been pushed upstream, so some time we may be able to enable this flag for C++. Change-Id: Iae7457f9afc469c63f3edbe23dbf272b5c6c9e5e Reviewed-on: https://code.wireshark.org/review/20310 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-09-16Qt: Avoid crashes in IAX2 Stream AnalysisStig Bjørlykke1-2/+13
Avoid crash when opening IAX2 Stream Analysis without having any packets and when not having a selected packet. Also disable the Save Audio options if not having any IAX2 packets. Also set Close as default button. Change-Id: I1da04e3f907d9d562fa227ab9f0428aa6097131e Reviewed-on: https://code.wireshark.org/review/17708 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-13qt: use #include <file.h> for generated include filesMartin Kaiser1-1/+1
make sure that generated include files are picked up only from the directories set by -I (or /I), not from the current directory if we use #include "file.h", Visual Studio searches for file.h in the same diretory as the source file that includes file.h if we do an out-of-tree build with cmake and the source directory contains files from an in-tree build (done with autotools), we might end up including the wrong file Change-Id: Iaaed2626258b6ff0c12485fe3f436bd03bbb5adf Reviewed-on: https://code.wireshark.org/review/15873 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-10Qt: activate RTP/IAX2 analysis widget when analyzing packets with a snaplenPascal Quantin1-4/+9
Only the payload save should be deactivated Bug: 12406 Change-Id: I8dd53c0b0c1ea4568f0ff292806656bfb65a6566 Reviewed-on: https://code.wireshark.org/review/15322 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-28Qt: Add dialog geometry restoreStig Bjørlykke1-2/+1
Add GeometryStateDialog class to handle load and save dialog geometry. The QDialog class name will be used as window name. For shared classes the UAT name or the statistics title or abbr will be used. Change-Id: I5a019598307fb3861518f41e733de834788184d8 Reviewed-on: https://code.wireshark.org/review/14139 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-1/+1
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-04Remove unneeded "#if 0"ed out code.Guy Harris1-85/+10
If we ever need to look at the value of any field in the packet, we should do it the way we do in the RTP analysis code, rather than walking the entire protocol tree. Get rid of an unnecessary extra level of indirection for the filter string. Change-Id: Ie95c0171da79e7f24019a3f67396f6a533959881 Reviewed-on: https://code.wireshark.org/review/13046 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-01Qt: Don't expose ColorUtils::graph_colors_.Gerald Combs1-2/+2
Make graph_colors_ private and accessible via getters. Blind attempt at fixing bug 11833. Bug: 11833 Change-Id: I03b7e90c686374d2d0f046f7e5fe87e43939dc82 Reviewed-on: https://code.wireshark.org/review/12318 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-27Qt: display RTP/IAX2 graph analysis arrival time as absolute instead of relativePascal Quantin1-2/+2
It makes it easier to synchronize the graph and packet list Change-Id: Ia0c6bc46227c1ff9267622ff52b5a5d966cd6e6a Reviewed-on: https://code.wireshark.org/review/12195 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-27Qt: Protect against unintentional "no capture file" window statusMichal Labedzki1-0/+2
If capture file was closed and we have some WiresharkDialogs opened, then we still need to know filename of capture file related to specific dialog. Change-Id: I15f0e5176b87713bf747eead64021619d0bdf039 Reviewed-on: https://code.wireshark.org/review/11025 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Gerald Combs <gerald@wireshark.org>
2015-10-22Use address functions instead of ADDRESS macros in ui.Gerald Combs1-12/+12
Replace CMP_ADDRESS, COPY_ADDRESS, et al with their lower-case equivalents in the ui directory. Change-Id: I10e95e66c8da5b880133452ebc484c53046e87ba Reviewed-on: https://code.wireshark.org/review/11199 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-05Move utf8_entities.h to wsutilJoão Valverde1-1/+1
Change-Id: I6298b3de5f0a1cb988014ff16082eaf8c2a3c3c0 Reviewed-on: https://code.wireshark.org/review/10786 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-13Qt: remove unused variables in IAX2 analysis codePascal Quantin1-4/+0
Spotted by Coverity Change-Id: I4877eb282890415fbd24cbc6e48ababa46109b12 Reviewed-on: https://code.wireshark.org/review/10510 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-09Add the IAX2 Analysis dialog.Gerald Combs1-0/+1330
Copied from the RTP Analysis dialog, just like the GTK+ version. Change-Id: I111020bc4073a3a3ba583bdace51a91ee5fef300 Reviewed-on: https://code.wireshark.org/review/10447 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>