aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/expert_info_dialog.cpp
AgeCommit message (Collapse)AuthorFilesLines
2016-06-19Revert "tap: change glib functions to wmem."Pascal Quantin1-3/+3
This reverts commit 2e9f3c5d366eaa7139fc877b5301392166b3f985. It breaks the registration of codec, dissector and libwiretap plugins. Change-Id: I4ef91dd192f765adf87ea9fe9f3693e25dbd24de Reviewed-on: https://code.wireshark.org/review/16012 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-17tap: change glib functions to wmem.Dario Lombardo1-3/+3
Change-Id: I878ae6b121a669f9b7f4e1e57bc079f0cb44c0bf Reviewed-on: https://code.wireshark.org/review/15270 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-15qt: add initializer to ExpertPacketTreeWidgetItem (CID 1362746).Dario Lombardo1-0/+1
Change-Id: I8ca154907e01fb40affb9e5f5a0aaf55921c95db Reviewed-on: https://code.wireshark.org/review/15926 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-14Qt: fix crash when opening Expert Info dialogPascal Quantin1-3/+5
g6ff19ff tried to access cinfo by following a chain of pointers from expert_info. Access cinfo from cap_file_, which is more reliable. While we are at it, let's explicitly check the pointer validity. Change-Id: I0da72c5b1d2230a49c125a1b57c81c3115c4f2fb Reviewed-on: https://code.wireshark.org/review/15901 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-13Qt: Add the Info column contents to Expert Info.Gerald Combs1-9/+20
When "group by summary" is enabled, packet items contain a packet number followed by a lot of empty space. Fill it with the contents of the Info column. Set the first column title to "Severity" or "Packet" depending on the item selection. Change-Id: Iff96ab2ec631300ec8f08e55019e191e88cff84a Reviewed-on: https://code.wireshark.org/review/15814 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-12expert_info_dialog (Qt): fix Uninitialized members (UNINIT_CTOR) reported by ↵Alexis La Goutte1-0/+1
Coverity (CID 1362692) Change-Id: I1bc71ac7b9c08a9a5749aa9bc88863fa10eb27c7 Reviewed-on: https://code.wireshark.org/review/15848 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-06-10Qt: Expert info grouping.Gerald Combs1-56/+166
Add the ability to group expert info items by summary and enable it by default. This more closely matches the GTK+ UI behavior. Show matching item counts while we're here. Bug: 12218 Change-Id: Ic02267da8435fb70015de8dd15e0ac46faabbee9 Reviewed-on: https://code.wireshark.org/review/15796 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-28Qt: Add dialog geometry restoreStig Bjørlykke1-2/+1
Add GeometryStateDialog class to handle load and save dialog geometry. The QDialog class name will be used as window name. For shared classes the UAT name or the statistics title or abbr will be used. Change-Id: I5a019598307fb3861518f41e733de834788184d8 Reviewed-on: https://code.wireshark.org/review/14139 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-17Qt: deactivate "limit to display filter" checkbox when retappingPascal Quantin1-0/+8
Bug: 11848 Bug: 11900 Change-Id: I39bc1f6d8006ee9c258c986a69b460cf99c7e65a Reviewed-on: https://code.wireshark.org/review/12687 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-10-29Qt: Allow Expert Information retapping.Gerald Combs1-21/+36
The Expert Information dialog is open-ended. It adds a tap listener but doesn't remove it, which is useful during live captures. Make sure we add our second-level tree items each time taps are drawn and when tapping is finished. Change-Id: Ie06d60512644e540172f1b330b631db4e4e86897 Bug: 11644 Reviewed-on: https://code.wireshark.org/review/11407 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-26Rework tapping in Qt dialogs.Gerald Combs1-16/+10
Add cf_cb_file_retap_started and cf_cb_file_retap_finished to file.[ch]. Add their associated signals to CaptureFile. Add registerTapListener and removeTapListeners to WiresharkDialog, which collect and automatically remove tap listeners. Add beginRetapPackets and endRetapPackets, which can be used to wrap critical sections so that we don't delete ourselves while tapping. Don't cancel tapping on close in WiresharkDialog. Use beginRetapPackets and endRetapPackets in WiresharkDialog and FollowStreamDialog. We will likely need to add them elsewhere. Update comments. Change-Id: I1788a6ade0817c31aa3419216df96be5e36b2178 Reviewed-on: https://code.wireshark.org/review/10261 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-17Fixup tap listener registration.Gerald Combs1-1/+1
Make sure we run make-tap-reg.py on files that register tap listeners. Make sure Qt-specific registration routines start with register_tap_listener_qt_. Change-Id: Idca382180f475db71e4d1965a70ae4cc2fa4f9d5 Reviewed-on: https://code.wireshark.org/review/10074 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-12Expert information dialog performance improvements.Gerald Combs1-11/+23
Inserting QTreeWidgetItems individually is slow. This isn't a problem if you only have a few items but the Expert Information dialog can have thousands. Add "packet" tree items in groups, which should be much faster. Note that we still add "group" tree items individually since that gives us a nice progress indicator. While we're here, make sure we show the dialog before tapping packets. Bug: 11439 Change-Id: I8a182f4158d078cae5f42b8d1355414197f423e1 Reviewed-on: https://code.wireshark.org/review/10000 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-11[Qt Expert Info dialogue] remove our tap listener when the dialogue is destroyedMartin Kaiser1-0/+1
if we don't do this, there'll be a dangling tap listener and we'll see a crash when its reset method is called this can be triggered by opening another expert info dialogue, this will invoke cf_retap_packets() and reset_tap_listeners() which in turn calls the reset method of each registered tap listener Bug: 11432 Change-Id: I8fc13351666c875e1a3641f31bada8e80d167ab2 Reviewed-on: https://code.wireshark.org/review/9979 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-03Add ServiceResponseTimeDialog.Gerald Combs1-1/+2
Add ServiceResponseTimeDialog as a subclass of TapParameterDialog, similar to StatsTreeDialog. Add initial plumbing for statistics menu items and command line invocation. Don't append "..." to menu item names. Don't add menu icons. In each case this avoids repetitive UI clutter. Change-Id: I463b95c93090160bb81d2e80b16aad389dc0bd6c Reviewed-on: https://code.wireshark.org/review/8864 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-25Qt: use <> for including the generated ui_*.h filesMartin Kaiser1-1/+1
this should make Visual Studio pick up the generated include files from the build directory instead of the source directory (which may contain lefovers from an in-tree build) Change-Id: Ie3de4cdd85a2865e203118a42ab10f443372f03b Reviewed-on: https://code.wireshark.org/review/9129 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-05-08Expert Info dialog.Gerald Combs1-0/+581
Show all expert messages in a combined view. Group top-level items by a (severity, group, protocol) tuple. Let the user enable and disable messages via a check menu. Add ProtoTree::goToField and expert_info_t.hf_index. Use them to jump to what we hope is the afflicted item. Enable the context menu only if the user has selected a packet item. Add a free-form search field that matches expert summaries. This differs from the GTK+ version but hopefully provides a smoother workflow. Bug: 10931 Change-Id: Ia12cb7c27cdea1634fa2798fb7e4c1b23bd16ad2 Reviewed-on: https://code.wireshark.org/review/8294 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-13 12:12:52 +0000