aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/capture_interfaces_dialog.ui
AgeCommit message (Collapse)AuthorFilesLines
2017-07-11Qt: Move all utility widgets to widgets subdirectoryRoland Knall1-1/+1
Move all utility widgets to the widgets subdirectory and add separate source_group for their files Correct some alphabetization in ui/qt/CMakeLists.txt noticed during compare. Change-Id: I2d664edc2b32f126438fb673ea53a5ae94cd43d1 Reviewed-on: https://code.wireshark.org/review/22531 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-31Qt: Use a standard "Start" button in Capture Options.Gerald Combs1-1/+1
QDialogButtonBox does a fine job of creating and managing buttons. Instead of creating our own "Start" button, just rename the "OK" button. This matches what we do elsewhere, e.g. in the Extcap Options dialog. Change-Id: I3c5eec1f01925f7b82c4e7360d685acbe4bb2fea Reviewed-on: https://code.wireshark.org/review/15653 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-05-31Qt: Monitor mode fixups.Gerald Combs1-1/+1
When we update the monitor mode setting for an interface, update its link type list. Start filling in interface columns from a common function instead of multiple places. Rename some member function names to match https://www.wireshark.org/docs/wsdg_html_chunked/ChUIQt.html#_coding_practices_and_naming_conventions Bug: 11364 Change-Id: I26ac7e9719863169b62069e49ebf17ed97fbe516 Reviewed-on: https://code.wireshark.org/review/15583 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-26Qt: Capture Interfaces dialog geometry updates.Gerald Combs1-1/+1
Widen CaptureInterfacesDialog. Manually set some column widths. Change-Id: I84fd060d83b5f7bc186d79e22d5cc608dfdbd6c5 Reviewed-on: https://code.wireshark.org/review/14148 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-27Make Qt UI capture filter behavior more closely match the GTK+ UI.Gerald Combs1-3/+3
If the user enters a capture filter in the Capture Interfaces dialog and presses "Start", make sure we copy the filter to the main welcome screen. Back out capture filter code from g0ce9ac4. Leave out the code that set the global capture filter. Move the code that set individual capture filters to the welcome screen. Fix multiple interface selection in the welcome screen. Rename allFilterComboBox in the capture interfaces dialog to captureFilterComboBox to match the main welcome screen. If the user starts typing in captureFilterComboBox, make sure the "Capture Filter" column is visible. Update the "Capture Filter" column as the user types. Conversely, if the user edits the "Capture Filter" column, update captureFilterComboBox accordingly. If we're editing a per-interface filter make sure we commit its contents before starting capture. Map our device index directly to each tree item instead of using a separate map which will no longer be valid any time our sort order changes (which we do right away in our constructor). Don't set prefs.capture_devices_filter in the Qt UI. The GTK+ UI doesn't and doing so can lead to surprising behavior. Note that it's mostly unused. Note that we don't multiple selected filters very well. Ping-Bug: 11886 Change-Id: I3c052f4f464411e2fb8fb7d96b218e1ce2bac3fd Reviewed-on: https://code.wireshark.org/review/13410 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-14Qt: fix Z-order assignment: '' is not a valid widget warningPascal Quantin1-1/+0
Change-Id: Ic9f41f34b017d161f13604cf8813bc70aa7a68d4 Reviewed-on: https://code.wireshark.org/review/13284 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-14Fix capture output options.Gerald Combs1-100/+49
Remove the "permanent file" checkbox. We weren't properly checking its value and it was extraneous. Add placeholder text about temporary files. Move the filename above the other options. That's where it is in the GTK+ UI and it's arguably the most important. When capturing to multiple files the size and duration settings aren't mutually exclusive. Change-Id: I1da1d3524e3c2de2361050913281472a172faa3a Reviewed-on: https://code.wireshark.org/review/13269 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-19Qt UI: use a default (and minimum) value of 2 for the number of files in aJeff Morriss1-0/+6
ring buffer. This matches the Gtk UI. (Note that the Qt UI's upper limit for this option (1k) is much lower than the Gtk UI's (100k).) Change-Id: Ie5b5b7b4bdb9205594ed7fcc38630a6268cc3acf Reviewed-on: https://code.wireshark.org/review/12711 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-18Qt UI: there's no need to capitalize kilobytes, megabytes, and megabytes inJeff Morriss1-6/+6
the ring buffer and autostop configuration sections. Change-Id: I2a260e4f9e52444ee9d6c072bce34067dd74cc19 Reviewed-on: https://code.wireshark.org/review/12712 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-31Use an ellipsis character instead of three dots.Gerald Combs1-4/+4
The OS X Human Interface Guidelines at https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/20000957-CH15-SW3 says: "Be sure to create the ellipsis character using the key combination Option-; (Option-semicolon). This ensures that an assistive app can provide the correct interpretation of the character to a disabled user. If you use three period characters to simulate an ellipsis, many assistive apps will be unable to make sense of them. Also, three period characters and an ellipsis don't look the same because the periods are spaced differently than the points of an ellipsis." The Windows desktop applications guidelines has a section on ellipses: https://msdn.microsoft.com/en-us/library/windows/desktop/dn742478.aspx but doesn't specify the a single glyph vs three dots. The GNOME HIG at https://developer.gnome.org/hig/stable/typography.html.en says "Take Advantage of Unicode" then specifically says to use U+2026 HORIZONTAL ELLIPSIS. Remove the ellipsis from "Find Next" and "Find Previous". Neither requires user interaction. Change-Id: I0e6c28bb8b3a84b242731e2ca96f1a6f6f42c303 Reviewed-on: https://code.wireshark.org/review/9833 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-06-26Qt: tweaks to Capture Interfaces dialogPascal Quantin1-14/+53
- Add option to stop capture after X files are created - Increase the max value for number of packets / files / bytes / seconds from 1000 to INT_MAX - Fix capture name file selection Change-Id: I9fb8eeaa925e5bd5380bb654686575f41126546a Reviewed-on: https://code.wireshark.org/review/9162 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-05-10qt: minor string change in capture optionsEvan Huus1-1/+1
Replace "Capture in" with "Enable" for promiscuous mode; the checkbox doesn't actually affect which interfaces get captured on, which is the way I wanted to read the old text. Change-Id: I35dd2c8f9523311cb267515804b1421e50e60e06 Reviewed-on: https://code.wireshark.org/review/8374 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-31Qt: Convert more dialog titles.Gerald Combs1-3/+1
Change-Id: I9c3e3471a92b7af9347a541bece3d9405d37dce0 Reviewed-on: https://code.wireshark.org/review/6193 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-17Remove some ununused/unmatched <resources/> tags.Jeff Morriss1-1/+0
Change-Id: I0f8e4381b27d1defeb5980692823d297d2f48bab Reviewed-on: https://code.wireshark.org/review/5349 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-11-14Qt: Fix typoMichal Labedzki1-1/+1
Change-Id: Idc2b945ac3bd5de961cc9c581398dc12f6831070 Reviewed-on: https://code.wireshark.org/review/5292 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2014-11-12Qt: Flatten group boxes.Gerald Combs1-18/+6
As discussed in change 5185, the "big 3" HIGs discourage the use of traditional group boxes. Flatten our existing ones. Change-Id: I68ef4aa9fd0f69a42750bf735df2250a468bfb2d Reviewed-on: https://code.wireshark.org/review/5263 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-08Qt capture interfaces dialogue string tweaksEvan Huus1-2/+2
To clarify that capturing always uses a file, the checkbox only controls whether that file is temporary or persisted. Change-Id: I939e1fdf488f53245166612193c60a366f63a18b Reviewed-on: https://code.wireshark.org/review/4537 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-23Qt: Re-enable menu icons.Gerald Combs1-5/+1
The GNOME HIG says "Where a corresponding toolbar icon exists, a menu icon should mirror its design." The Windows and OS X HIGs say that you should use them for common or familiar actions but otherwise avoid clutter. I think icons in the "File" menu look like crap. Try to strike a balance. Use the 16x16 application icon for both the main web site and the wiki since that's the favicon used on both sites. Assume that "Reload" isn't used very often and remove it from the toolbar. Don't use a menu icon for the about box. Other minor fixups. Change-Id: I855211c218d266c2e9ed5acbe05a08750ab6d157 Reviewed-on: https://code.wireshark.org/review/4246 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-08-29Qt: Rework the "Manage Interfaces" dialog.Gerald Combs1-2/+2
Convert QTableWidget to QTreeWidget. It looks like the GTK+ version has a separate set of apply/save buttons for each tab which *only* operates on that tab. This can result unexpected behavior which throws away changes if the user updates more than one tab. Use a single "OK" button that applies all of our changes instead. Reorder the tabs. Put Local Interfaces first and select it by default. Always show Remote Interfaces. Disable it on platforms that don't have PCAP_REMOTE. Automatically start editing when we add a new pipe. Don't immediately update pipe interface settings. Wait until we hit "OK" instead. Rename NewFileDelegate to PathChooserDelegate. Note that we might want to move it use it elsewhere in the application. Try switching the user-facing terminology from "Hide" to the more positive "Show". Tell the user that we don't save pipe or remote interface settings. Add a help URL for the "Manage Interfaces" dialog box. Use the GLib and Qt string functions and classes to split and join comma-separated preferences. This makes sure capture_dev_user_descr_find doesn't skip over the first interface. It also keeps the Qt code from adding a leading comma to our capture preferences. Add a note about strings to README.qt. Summary: Use QStrings. For another day: - If we *do* save remote settings we need to store credentials securely, e.g. with CryptProtectData. - Get rid of the remote settings dialogs. Their controls should fit in the remote settings tab. - Add an extcap tab. - We need getter/setter functions for global_capture_opts.all_ifaces. We iterate over it *way* too much. Change-Id: Ib7b61972f3ece4325e0230f725e7f2678acbb24b Reviewed-on: https://code.wireshark.org/review/3873 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-08-18Capture Options: Add functionality to options and output tabIrene Ruengeler1-82/+274
Change-Id: I4a2116fe5b7ae3997dd7b0f2693aa511f9d52061 Reviewed-on: https://code.wireshark.org/review/3688 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-08Use a QTreeWidget instead of QTableWidget.Gerald Combs1-93/+83
Even though Qt's widget naming suggests otherwise, a QTreeWidget is usually a better choice for tables than QTableWidget. The former gives you a nice, clean Plain Old Table while the latter gives you something that looks and acts like a spreadsheet. In this particular instance using QTreeWidget also gives us the option of adding sub-items with detailed information. Do so for attached addresses. Allow sorting by traffic while we're here. Simplify the column hiding logic. Make sure the sparkline delegate isn't editable. Change-Id: Ia36ba2e12c1c0cb86ae5b2154e6afcf6549ae049 Reviewed-on: https://code.wireshark.org/review/3466 Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-02Manage InterfacesIrene Ruengeler1-4/+16
- Add dialog to manage interfaces - Add and delete pipes - Hide local interfaces Change-Id: I08323c306c2ea736f99e57c28e2fe3170a0c2216 Reviewed-on: https://code.wireshark.org/review/2613 Tested-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2014-06-17Get QtShark building on Win7 with Qt 5.3.0 using Qt Creator.Tim Furlong1-1/+1
Several header file references in .ui files needed to be changed to not be global, and the path to stats_tree_dialog.ui needed a "../qt" path prepended to be found from the build...-Release directory. Change-Id: I51c0bb15eed706f483085020ce2b3cea3c1cdc95 Reviewed-on: https://code.wireshark.org/review/2281 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-12Capture Interfaces Dialog:Irene Ruengeler1-38/+45
- allow to change the interface options in the table - save the options to preferences when the dialog is left - add a field for setting a capture filter for all selected interfaces - add a "Compile BPF" button and a window to show the compiled filter output - try to address Alexis' and Evan's comments Change-Id: Ic1272e29183ec80e2d2f4b3e494c79dabe2c3b6f Reviewed-on: https://code.wireshark.org/review/1946 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-14Fix typo (Direcly => Directly)Alexis La Goutte1-2/+2
svn path=/trunk/; revision=54804
2013-12-13Capture Interfaces dialog cleanup.Gerald Combs1-641/+589
Apply layouts as needed to allow resizing. Select the interface list by row. We might want to switch the interface list to a QTreeWidget. Today I learned that you can make QGroupBox titles checkable. Do that where we enable and disable groups of items. Flatten all of the group boxes. Change the output format combo to radio buttons. There are only two choices and we have lots of real estate available. Use a QDialogButtonBox so Qt can size and order the buttons appropriately. svn path=/trunk/; revision=54052
2013-12-06Fix ui/qt/capture_interfaces_dialog.ui: Warning: The name 'layoutWidget' ↵Alexis La Goutte1-10/+10
(QWidget) is already in use svn path=/trunk/; revision=53807
2013-11-25From Thomas ERSFELD (GSoC13) : Add Capture interface dialog windowAlexis La Goutte1-0/+686
* Reuse sparkline from welcome * Split settings in tab (!= GTK) * No all feature work (Work In Progress...) * ... Comments (and review) are welcome ! svn path=/trunk/; revision=53563
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-19 14:50:27 +0000