aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/rtp_player.c
AgeCommit message (Collapse)AuthorFilesLines
2014-04-19Some routine name changes.Guy Harris1-8/+8
"get_addr_name()" -> "ep_address_to_display()", to 1) indicate that it returns a string with ephemeral scope and 2) indicate that it maps an address to a "displayable" form - a name if possible, an address string if not. "se_get_addr_name()" -> "get_addr_name()", to indicate that its strings have the same scope as "get_ether_name()", "get_hostname()", and "get_hostname6()". Change-Id: If2ab776395c7a4a163fef031d92b7757b5d23838 Reviewed-on: https://code.wireshark.org/review/1216 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-11Migrate GTK icon handling to GTK 3.10 APIBalint Reczey1-5/+5
GtkStockItem usage is deprecated with all the GTK_STOCK_.* stock ids. We keep a stock id based approach but without relying on GTK's GtkStockItem system. We create our own internal stock ids for {icon, label} tuples and keep the original GTK stock id #define-s and values to preserve backward compatibility. Change-Id: Ia0b35a5903f079e92c8026e3df21bbf0be2d06b0 Reviewed-on: https://code.wireshark.org/review/302 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-12RTP: Add support for SBC codec in RTP PlayerMichal Labedzki1-98/+82
Add optional dependancy to libsbc to play Bluetooth SBC in A2DP payload. Also simplify RTP Player and extent codec interface. Change-Id: I52e1fce9c82e2885736354fe73c6c37168a4fda3 Reviewed-on: https://code.wireshark.org/review/19 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2013-12-23From Ville Skyttä: Spelling FixesBill Meier1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9591 svn path=/trunk/; revision=54387
2013-12-02Move most of the plugin code from epan to wsutil and remove allGuy Harris1-1/+2
knowledge of particular types of plugins. Instead, let particular types of plugins register with the common plugin code, giving a name and a routine to recognize that type of plugin. In particular applications, only process the relevant plugin types. Add a Makefile.common to the codecs directory. svn path=/trunk/; revision=53710
2013-12-01Move codecs.[ch] out of epan and into codecs directory.Michael Mann1-1/+1
This may break easy_codec plugins, but it appears a better/more consistent way is needed to register codecs. See Guy's comments in bug 7893 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893) svn path=/trunk/; revision=53686
2013-10-24Initial and woefully incomplete flow graph support.Gerald Combs1-2/+2
Copy common code from ui/gtk/flow_graph.c and ui/gtk/graph_analysis.[ch] to ui/tap-sequence-analysis.[ch]. Start using the name "sequence" in places. svn path=/trunk/; revision=52824
2013-07-21Update rtp_player for rel_ts move.Evan Huus1-2/+2
svn path=/trunk/; revision=50776
2013-05-15Remove an unused variable.Gerald Combs1-1/+0
svn path=/trunk/; revision=49318
2013-05-15Merge some of the changes to rtp player from ↵Anders Broman1-44/+43
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893 by hand. svn path=/trunk/; revision=49316
2013-05-13Eliminate some includes of ui/simple_dialog.h by files that don't useGuy Harris1-1/+0
anything from it. svn path=/trunk/; revision=49277
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-1/+1
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-21[-Wmissing-prototypes]Anders Broman1-25/+25
Use explicit casts. svn path=/trunk/; revision=48457
2013-03-04Fix a minor typo in SVN #48065Bill Meier1-1/+1
svn path=/trunk/; revision=48067
2013-03-04Fir Gtk 3.8 & newer: gtk_scrolled_window_add_with_viewport() ==> ↵Bill Meier1-1/+5
gtk_container_add(). svn path=/trunk/; revision=48065
2013-02-26Fix spelling/typos found using a list of commonly misspelled words.Bill Meier1-5/+5
The misspellings were mostly in comments but some were in text strings visible to the user. svn path=/trunk/; revision=47899
2013-02-15Fix Voice RTP player crash if player is closed while playingMichael Mann1-11/+15
Bug 8065 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8065) svn path=/trunk/; revision=47674
2013-01-06Use GdkRGBA colors directly in the arrayAnders Broman1-46/+57
svn path=/trunk/; revision=46974
2013-01-04Use gdk_cairo_set_source_rgbaAnders Broman1-18/+24
svn path=/trunk/; revision=46940
2013-01-02Fix a GTK3 issue:Bill Meier1-1/+1
Use gtk_box_pack_start() instead of gtk_container_add(). svn path=/trunk/; revision=46904
2012-12-23Use the types that PortAudio specifies for values passed to or returnedGuy Harris1-14/+11
from PortAudio; that squelches some implicit 64-bit-to-32-bit conversion warnings. Mark unused arguments with _U_ rather than adding fake usages for them. svn path=/trunk/; revision=46717
2012-12-22Remove unneeded initializations, and one redundant if condition.Evan Huus1-1/+1
svn path=/trunk/; revision=46702
2012-12-05Fix numerous instances of a variable/parameter name "shadowing" a library ↵Bill Meier1-7/+7
function name; (At least some (gcc ?) compilers give a "shadow" warning for these). svn path=/trunk/; revision=46402
2012-09-29More unused variables caught by cppcheck.Evan Huus1-2/+0
svn path=/trunk/; revision=45211
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45016
2012-08-01Get rid of some GTK_CHECK_VERSION instances by using compabillity macros.Anders Broman1-8/+0
svn path=/trunk/; revision=44186
2012-07-22Two little cleanups from cppcheck:Evan Huus1-1/+1
- unused variable = don't trust GTK_IS_PROGRESS_BAR to provide the necessary parentheses svn path=/trunk/; revision=43915
2012-07-18Fix some system header files that were #included with "" instead of <>.Evan Huus1-1/+1
They made cppcheck unhappy. svn path=/trunk/; revision=43779
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-03g_filename_display_basename() returns a g_mallocated string, so itsGuy Harris1-1/+2
callers either need to free it or their callers need to free it or.... This means that cf_get_display_name() must always return a g_mallocated string and its callers or... must free it. For some of those callers, create a new set_window_title() routine to do the work - they're all using the same pattern. svn path=/trunk/; revision=43047
2012-04-21More GTK3 adaptationsAnders Broman1-3/+3
svn path=/trunk/; revision=42187
2012-04-21Replace gtk_vbox_new() and gtk_hbox_new() with ws_gtk_box_new().Anders Broman1-5/+5
svn path=/trunk/; revision=42176
2012-04-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-13/+2
svn path=/trunk/; revision=42086
2012-02-10Sean Bright <sean.bright@gmail.com>:Jörg Mayer1-1/+1
In r37159, the following change was made to ui/gtk/rtp_player.c: @@ -1654,9 +1636,7 @@ GtkWidget *dialog; /* we should never be here if we are in PLAY and !PAUSE */ - if(!rtp_channels->stop&& !rtp_channels->pause){ - exit(10); - } + g_assert(!rtp_channels->stop&& !rtp_channels->pause); The logic, however, was not negated properly. The correct assertion should be: g_assert(rtp_channels->stop || rtp_channels->pause); With the current code, the RTP player causes a crash for me when pressing the 'Play' button. svn path=/trunk/; revision=40951
2012-01-16Move some headers for UI stuff, and the alert_box.c UI-specific file, toGuy Harris1-1/+1
the ui directory. (Perhaps some other files that would be used by all flavors of Wireshark, for any GUI toolkit or for someting such as ncurses, and not for any command-line tool such as TShark, should be moved there as well.) Shuffle some #includes to put the "ui/XXX.h" includes together. svn path=/trunk/; revision=40529
2012-01-15Move gtk to ui/gtk.Jörg Mayer1-0/+2530
This looses the last checkin to gtk, will add this manually back. svn path=/trunk/; revision=40518