aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/rlc_lte_graph.c
AgeCommit message (Collapse)AuthorFilesLines
2017-07-12GTK: fix compilation with GCC 7Pascal Quantin1-1/+1
Change-Id: Ifde706f4705af406fd4eee61a312d8eb0976d972 Reviewed-on: https://code.wireshark.org/review/22598 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-05A bunch of "{Mac} OS X" -> "macOS" changes.Guy Harris1-1/+1
Avoid anachronisms, however; there was no "macOS 10.0" or even "OS X 10.0", for example. It was "Mac OS X" until 10.8 (although 10.7 was sometimes called "OS X" and sometimes called "Mac OS X"), and it was "OS X" from 10.8 to 10.11. Change-Id: Ie4a848997dcc6c45c2245c1fb84ec526032375c3 Reviewed-on: https://code.wireshark.org/review/20933 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-26Gtk: remove atoi calls and use ws_strtoi functions.Dario Lombardo1-2/+5
Change-Id: Ie38bdd27d9e3810e3a64b985dfd5621a3aa6d073 Reviewed-on: https://code.wireshark.org/review/18445 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-24Pacify GTK checkAPIs.pl warnings.Michael Mann1-3/+3
Add "Wireshark" macros to old-gtk-compat.h for GTK APIs that have been deprecated. The macros are setup by version number to limit their proliferation (not that I suspect much development will really be done there since GTK is deprecated). Just want to make buildbots happy for the time being. Change-Id: I095f850065166a0bc2e2456fb2e886ab64fdd97d Reviewed-on: https://code.wireshark.org/review/16635 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Balint Reczey <balint@balintreczey.hu> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-18Don't add the wiretap directory to the list of include directories.Guy Harris1-2/+2
If you include something from the wiretap directory, always precede it with wiretap/. Fix some includes of files in the top-level directory to use a path relative to the current directory, not relative to the wiretap directory. This makes it a bit clearer what's being included. Change-Id: Ib99655a13c6006cf6c3112e9d4db6f47df9aff54 Reviewed-on: https://code.wireshark.org/review/13990 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-07GTK: Check if lrint() is usable, fix warnings [-Wbad-function-cast]João Valverde1-30/+34
Change-Id: I4714ba6cfbd18847d99650f5c5cdc60dd2e7af26 Reviewed-on: https://code.wireshark.org/review/13808 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2015-12-29Always supply a g_mallocated error message from select_rlc_lte_session().Guy Harris1-8/+12
That way, we don't have to pass a "free this" indication separately. While we're at it, don't just free the error message, *display* it in all cases where rlc_graph_segment_list_get() fails. (I wish more programming languages had a proper string type, including some whose names consist solely of the third letter of the alphabet, but I digress....) Change-Id: I99f8b088aa19bc8fbb178bdb36d85ba5b89c06e0 Reviewed-on: https://code.wireshark.org/review/12902 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-10-11LTE RLC graphs - initial versionMartin Mathieson1-450/+145
Change-Id: Ic5f2c353ae1f787ac19cb575a938cb093ff5f6dc Reviewed-on: https://code.wireshark.org/review/10930 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-09-27ui/gtk: fix weird check for axis orientationPeter Wu1-7/+4
There is only one meaning for the flags parameter, namely axis orientation (x or y). Replace the bitmap by a bool instead. Clang 3.7.0 reported this warning: ui/gtk/tcp_graph.c:1652:29: warning: shifting a negative signed value is undefined [-Wshift-negative-value] g->y_axis->flags &= ~AXIS_ORIENTATION; ~^~~~~~~~~~~~~~~~ ui/gtk/tcp_graph.c:140:28: note: expanded from macro 'AXIS_ORIENTATION' #define AXIS_ORIENTATION 1 << 0 ^ 1 warning generated. This (~1 << 0) happened to work because nothing is actually shifted. Change-Id: I406235148b7826649d35647f5d0702cd72a925a5 Reviewed-on: https://code.wireshark.org/review/10658 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-02-09(Trivial) Fix printf-related 'Mismatch on sign' warningsBill Meier1-1/+1
Found by MSVC2013 Code Analysis Change-Id: I58063946dd558e98308c87b36eeac0ddbe1a6e79 Reviewed-on: https://code.wireshark.org/review/7045 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-18Clean up ftype-conversion and dfilter error message string handling.Guy Harris1-2/+4
Have dfilter_compile() take an additional gchar ** argument, pointing to a gchar * item that, on error, gets set to point to a g_malloc()ed error string. That removes one bit of global state from the display filter parser, and doesn't impose a fixed limit on the error message strings. Have fvalue_from_string() and fvalue_from_unparsed() take a gchar ** argument, pointer to a gchar * item, rather than an error-reporting function, and set the gchar * item to point to a g_malloc()ed error string on an error. Allow either gchar ** argument to be null; if the argument is null, no error message is allocated or provided. Change-Id: Ibd36b8aaa9bf4234aa6efa1e7fb95f7037493b4c Reviewed-on: https://code.wireshark.org/review/6608 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-03Rename and move ui/stat_menu.h to epan/stat_groups.h.Guy Harris1-1/+1
The groups are, technically, independent of the notion of a menu, and, if we have mechanisms by which taps that are not only GUI toolkit-independent but independent of the *existence* of a GUI can be registered, they might want to register themselves in a group just in case they're running in a program that has a GUI. Also, this might fix the Debian package build. Change-Id: I29435681e79748fd4f2e0c5ac872cd11f831d172 Reviewed-on: https://code.wireshark.org/review/2830 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-30Move stat_menu.h to libui.Guy Harris1-1/+1
Change-Id: I7bed7f7931845bc41035535cc62e1fe17c71047d Reviewed-on: https://code.wireshark.org/review/2726 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-10rlc lte graph: Assigned value is garbage or undefined (clang analyzer)Alexis La Goutte1-0/+6
Change-Id: Ia371c26299aa62566a63bc1a4d4f6df827fdf5b9 Reviewed-on: https://code.wireshark.org/review/2085 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-09Add Modelines infoAlexis La Goutte1-0/+13
Change-Id: I2364104145518d484c2e5fb0ae5d5d80cce0982d Reviewed-on: https://code.wireshark.org/review/2064 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-05-25Add support for dissecting non-packet records.Guy Harris1-1/+1
Add a dissector table indexed by the file type, and, for the file-type-specific records, have the frame dissector skip the usual pseudo-header processing, as the pseudo-header has a file-type-specific record subtype in it, and call the dissector for that file type's records. Change-Id: Ibe97cf6340ffb0dabc08f355891bc346391b91f9 Reviewed-on: https://code.wireshark.org/review/1782 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-24Allow wtap_read() and wtap_seek_read() to return records other than packets.Guy Harris1-3/+3
Add a "record type" field to "struct wtap_pkthdr"; currently, it can be REC_TYPE_PACKET, for a record containing a packet, or REC_TYPE_FILE_TYPE_SPECIFIC, for records containing file-type-specific data. Modify code that reads packets to be able to handle non-packet records, even if that just means ignoring them. Rename some routines to indicate that they handle more than just packets. We don't yet have any libwiretap code that supplies records other than REC_TYPE_PACKET or that supporting writing records other than REC_TYPE_PACKET, or any code to support plugins for handling REC_TYPE_FILE_TYPE_SPECIFIC records; this is just the first step for bug 8590. Change-Id: Idb40b78f17c2c3aea72031bcd252abf9bc11c813 Reviewed-on: https://code.wireshark.org/review/1773 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-23Revert "Allow wtap_read() and wtap_seek_read() to return non-packet records."Guy Harris1-1/+1
This reverts commit c0c480d08c175eed4524ea9e73ec86298f468cf4. A better way to do this is to have the record type be part of struct wtap_pkthdr; that keeps the metadata for the record together and requires fewer API changes. That is in-progress. Change-Id: Ic558f163a48e2c6d0df7f55e81a35a5e24b53bc6 Reviewed-on: https://code.wireshark.org/review/1741 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-23Allow wtap_read() and wtap_seek_read() to return non-packet records.Guy Harris1-1/+1
This is the first step towards implementing the mechanisms requestd in bug 8590; currently, we don't return any records other than packet records from libwiretap, and just ignore non-packet records in the rest of Wireshark, but this at least gets the ball rolling. Change-Id: I34a45b54dd361f69fdad1a758d8ca4f42d67d574 Reviewed-on: https://code.wireshark.org/review/1736 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-09Revert "Refactor Wiretap"Guy Harris1-1/+1
This reverts commit 1abeb277f5e6bd27fbaebfecc8184e37ba9d008a. This isn't building, and looks as if it requires significant work to fix. Change-Id: I622b1bb243e353e874883a302ab419532b7601f2 Reviewed-on: https://code.wireshark.org/review/1568 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-09Refactor WiretapMichael Mann1-1/+1
Start of refactoring Wiretap and breaking structures down into "generally useful fields for dissection" and "capture specific". Since this in intended as a "base" for Wiretap and Filetap, the "wft" prefix is used for "common" functionality. The "architectural" changes can be found in cfile.h, wtap.h, wtap-int.h and (new file) wftap-int.h. Most of the other (painstaking) changes were really just the result of compiling those new architecture changes. bug:9607 Change-Id: Ife858a61760d7a8a03be073546c0e7e582cab2ae Reviewed-on: https://code.wireshark.org/review/1485 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-10-26From robionekenobi via ↵Pascal Quantin1-4/+4
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9328 : Suppress some VS2013 warnings when compiling gtk ui svn path=/trunk/; revision=52880
2013-07-21Replace relative timestamp with reference frame number. Saves 16B per frame.Jakub Zawadzki1-4/+6
svn path=/trunk/; revision=50772
2013-07-21Some work on multi file dissectionJakub Zawadzki1-1/+1
- make init_dissection/cleanup_dissection private for libwireshark - implement epan_new(), epan_free() - pass epan_t to epan_dissect* svn path=/trunk/; revision=50761
2013-07-11packet dissection now takes pointer to tvb instead of guint8 dataJakub Zawadzki1-1/+2
implement frame_tvbuff, right now almost a copy of 'real' tvb. svn path=/trunk/; revision=50497
2013-06-16Have the seek-read routines take a Buffer rather than a guint8 pointerGuy Harris1-1/+1
as the "where to put the packet data" argument. This lets more of the libwiretap code be common between the read and seek-read code paths, and also allows for more flexibility in the "fill in the data" path - we can expand the buffer as needed in both cases. svn path=/trunk/; revision=49949
2013-04-16Fix another dozen or so files with bad FSF addresses as caught by licensecheck.Evan Huus1-1/+1
svn path=/trunk/; revision=48869
2013-04-13Allow zooming in on a rectangular region using left mouse.Martin Mathieson1-6/+224
Slightly simplified version of what tcp_graph.c does. svn path=/trunk/; revision=48835
2013-03-21From beroset:Bill Meier1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10408 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c svn path=/trunk/; revision=48448
2013-03-06Use explicit casts.Anders Broman1-11/+11
svn path=/trunk/; revision=48144
2013-03-06Get rid of xor_gc altogether, I think it's a remnant from the "old" ↵Anders Broman1-26/+0
cross-hair code. svn path=/trunk/; revision=48141
2013-02-26Fix spelling/typos found using a list of commonly misspelled words.Bill Meier1-2/+2
The misspellings were mostly in comments but some were in text strings visible to the user. svn path=/trunk/; revision=47899
2013-02-25it's ==> its & its ==> it's as needed.Bill Meier1-1/+1
In a few cases: Fix spelling; Clean up whitespace and formatting style. svn path=/trunk/; revision=47889
2013-02-16Show resegmented data as grey.Martin Mathieson1-21/+41
svn path=/trunk/; revision=47687
2013-01-16General cleanup: whitespace, parens & etc.Bill Meier1-150/+149
svn path=/trunk/; revision=47126
2013-01-16Use gdk_cairo_set_source_rgba() and GdkRGBA.Bill Meier1-27/+27
svn path=/trunk/; revision=47124
2012-12-16Don't cast away constness of passed-in tap structs.Martin Mathieson1-2/+2
svn path=/trunk/; revision=46552
2012-12-05Choose direction properly if launching graph based upon channel ofMartin Mathieson1-1/+2
selected frame. svn path=/trunk/; revision=46411
2012-11-28- Allocate the correct number of elements to drawMartin Mathieson1-95/+94
- Draw data list then control list, so can spot blue of ACKs when zoomed right out - Made the red crosses for NACKs smaller svn path=/trunk/; revision=46243
2012-10-20Introduce epan_dissect_run_with_taps() which run dissection with taps.Jakub Zawadzki1-3/+1
unexport tap_queue_init, tap_push_tapped_queue svn path=/trunk/; revision=45670
2012-10-16Add wtap_pseudo_header union to wtap_pkthdr structure.Jakub Zawadzki1-1/+1
Use pkthdr instead of pseudo_header as argument for dissecting. svn path=/trunk/; revision=45601
2012-10-15Allow the RLC sequence graph to be called from the statistics window.Martin Mathieson1-18/+57
svn path=/trunk/; revision=45562
2012-10-10Take a deep copy of the tap struct in the tap function, as it is notMartin Mathieson1-1/+4
safe to access it after the packet has been fully dissected (the struct will have been allocated with ep_alloc()). svn path=/trunk/; revision=45449
2012-10-06Use ellipses rather than crosses made from lines to show data points,Martin Mathieson1-84/+105
and no longer connect the data points with lines. Because this is slower than before, increase the zoom multipler. The (very) slow part is filling in the circles - using cairo_set_tolerance() with 1.0 doesn't do anti-aliasing but looks good enough (halfing the time for this operation). svn path=/trunk/; revision=45336
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45016
2012-08-23Rationalise the way lists/elements are allocated.Martin Mathieson1-4/+6
svn path=/trunk/; revision=44623
2012-08-19Both lists of elements are always allocated together, so save a scanMartin Mathieson1-5/+4
through the segments by only getting the counts once. svn path=/trunk/; revision=44577
2012-08-19Speed up drawing of axes by taking cairo_stroke() andMartin Mathieson1-12/+4
cairo_set_line_width() out of the loops they are in. svn path=/trunk/; revision=44575