aboutsummaryrefslogtreecommitdiffstats
path: root/tools
AgeCommit message (Collapse)AuthorFilesLines
2016-08-17pre-commit: Make version check work with git-worktreeJoão Valverde1-3/+5
By disabling it outside the main working tree this time. Change-Id: I2075b07370e3cc1395c6de9695e40b0a952e3eab Reviewed-on: https://code.wireshark.org/review/17122 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: João Valverde <j@v6e.pt>
2016-08-17Fix a comparison in win-setup.ps1Gerald Combs1-2/+2
"if ($SomeVariable > 0)" is valid PowerShell syntax, but it writes the value of $SomeVariable to a file named "0". Use the "-gt" operator instead. Change-Id: I17e0f7033008ead3b24fed8c0c91869747ff81f1 Reviewed-on: https://code.wireshark.org/review/17093 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-08-17Add licensecheck.pl to the tarballJoão Valverde1-0/+1
checklicenses.py now needs it. Change-Id: I1a8c6e21fb35386dcaa44c72f9c196445a378a04 Reviewed-on: https://code.wireshark.org/review/17088 Reviewed-by: João Valverde <j@v6e.pt>
2016-08-15pre-commit: Fix version check to work with git-worktreeJoão Valverde1-1/+1
Change-Id: Ie895ca194738a022cc211ae50afbff0a561156a3 Reviewed-on: https://code.wireshark.org/review/17047 Reviewed-by: João Valverde <j@v6e.pt>
2016-08-15checklicenses: Fix a FIXMEJoão Valverde1-12/+37
We do not whitelist GPLv2 only code because of the incompatibility with GPLv3. Move the path exception to its proper place. These files are dual-licensed in the sense of "choose one or the other", not "both licenses are in use". If the exception becomes unnecessary later it can be removed, but let's get rid of the FIXME until then. Change-Id: Ia040284b72c2ff6588b0544896cc37ae19a61613 Reviewed-on: https://code.wireshark.org/review/16957 Reviewed-by: João Valverde <j@v6e.pt>
2016-08-09Windows: upgrade Lua library to 5.2.4Pascal Quantin1-4/+4
Change-Id: Ib0a4afc9b6143cf5ff78f72f0808f9f804549dd9 Reviewed-on: https://code.wireshark.org/review/16979 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-08-09checklicenses: Remove whitelisted licenses not being usedJoão Valverde2-61/+8
Removed a few licenses we shouldn't use (Apache v2, BSD 4-clause) and removed many others not currently being used. (Add on a need-to basis). Added GPLv3+ with Bison exception to licensecheck.pl. Also removed some crud to work around bugs for older licensecheck.pl versions. The original list came from the chromium project, which has a BSD-like license, and many more licenses in use, not all of them vetted for GPLv2+ compatibility. Change-Id: I67f334f21cd94904cf8a0e5d9beb659c82437df4 Reviewed-on: https://code.wireshark.org/review/16966 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-08-08debian-setup: add customized profiles.Dario Lombardo1-15/+33
libcap-dev has also been added to optional list. Change-Id: I52e034603922b694391a30c20316e1a2011fc3b6 Reviewed-on: https://code.wireshark.org/review/16872 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-08-06checklicenses.py: Remove some boilerplate from upstreamJoão Valverde1-6/+0
Change-Id: If8a1537fe5ad0c5decaf2facf6fd0c43b32ffe70 Reviewed-on: https://code.wireshark.org/review/16930 Reviewed-by: João Valverde <j@v6e.pt>
2016-08-06Add licensecheck.pl to our /tools directory and use itJoão Valverde2-20/+876
Source: https://anonscm.debian.org/cgit/collab-maint/devscripts.git/plain/scripts/licensecheck.pl?h=v2.16.2 Removed regex to check files without an extension. Change-Id: Icf98d0da2d201731da7134799ead0d2dc5c3fc39 Reviewed-on: https://code.wireshark.org/review/16913 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-08-06tools/pidl: support HRESULT as return code in wireshark autogenerated ↵Günther Deschner1-1/+8
dissectors. Guenther Change-Id: I68b7c579c5a519e429d2f4c2b3f63247e02f24e3 Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16718 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-06tools/pidl: Keep case from fieldnames.Günther Deschner1-1/+1
Change-Id: I5626cfa0487cc88eb65cc349c05ae1762bc953f4 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16720 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-05Update FSF address.Guy Harris1-1/+1
Change-Id: I2a36a833f00f4acda253e5741c96c519588aa046 Reviewed-on: https://code.wireshark.org/review/16919 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-05Fix FSF address.Guy Harris1-1/+1
Change-Id: Icf473af9487e60003813435f18551225224c6d58 Reviewed-on: https://code.wireshark.org/review/16915 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-05checklicenses.py: Whitelist some plaintext files without license requirementsJoão Valverde1-0/+15
Change-Id: I029ef1d52ac6edd44c0bac41adb86361ddd94272 Reviewed-on: https://code.wireshark.org/review/16898 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-04asn2wrs: put back parsetab.py file in ASN.1 source folderPascal Quantin1-1/+1
Otherwise it breaks multi threaded compilation. Follow-up of gd04be01 Bug: 12621 Change-Id: I2f6b7d6ca85a1cf5a6713c2b36c823a520d3bf3d Reviewed-on: https://code.wireshark.org/review/16886 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-08-04Ply parser updated to 3.8 from http://www.dabeaz.com/ply/Balint Reczey3-1347/+1522
The Ubuntu packaged Ply 3.7 with Ubuntu 16.04's Python makes ASN.1 based dissector generation fail. Ply's API changed after 3.5 and the small change to asn2wrs.py adapts to that. The commit breaking the API in Ply's repository is the following: commit af651673ba6117a0a5405055a92170fffd028106 Author: David Beazley <dave@dabeaz.com> Date: Tue Apr 21 16:31:32 2015 -0500 Added optional support for defaulted states Change-Id: I1db33fdcccf7c39ecdb0e435a5ea9183362471ad Bug: 12621 Reviewed-on: https://code.wireshark.org/review/16864 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Petri-Dish: Balint Reczey <balint@balintreczey.hu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Tested-by: João Valverde <j@v6e.pt>
2016-08-03Update USBPcap installer packaged in our Windows installerPascal Quantin1-4/+4
This new version contains kernel drivers with an EV certificate that is cross-signed by Microsoft as it will become mandatory. See https://blogs.msdn.microsoft.com/windows_hardware_certification/2016/07/26/driver-signing-changes-in-windows-10-version-1607/ for details. Change-Id: I76bb1005ea540f39dca8874abb88d71a3ad53625 Reviewed-on: https://code.wireshark.org/review/16862 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-27Copy over change from Samba repository:Guy Harris1-0/+8
commit ed11ce8f12d567a3e0edc1d24aab1784a171ac33 Author: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Date: Wed May 4 16:51:37 2016 +1200 Python pidl: avoid segfault with "del obj->attr" Deleting an attribute in Python (using the "del" statement) is (at some stages along a winding path, for C objects) converted into setting the attribute to NULL. Not None, actual NULL. The way we handled this NULL was to dereference it. This changes the behaviour to raising an AttributeError, which is more or less what Python does in similar situations with builtin objects. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Shouldn't affect us, but it makes diffing cleaner. Change-Id: I8e681dc79c8f4e62b74e2aa5ac2b4924134735c4 Reviewed-on: https://code.wireshark.org/review/16741 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-27Copy over change from Samba repository:Guy Harris1-42/+61
commit f6c79072ca50e05a68b73a80a0ebd635a9bac068 Author: Andrew Bartlett <abartlet@samba.org> Date: Thu Apr 21 21:44:56 2016 +1200 pidl: Correct string handling to use talloc and be in common The previous string handling assumed the python variables referenced by PyString_AS_STRING had infinite life. When they were re-used the C structure started to point at unexpected things. We now check correctly for Unicode in every case, and we always duplicate the string with talloc_strdup() Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Shouldn't affect us, but it makes diffing cleaner. Change-Id: Ib54b62f5630df46cff6fb0582acd109b263142d2 Reviewed-on: https://code.wireshark.org/review/16740 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-27Copy over change from Samba repository:Guy Harris1-2/+13
commit 90bf114f6370ee837d97e36eb25f38f8234dcd39 Author: Andrew Bartlett <abartlet@samba.org> Date: Thu Feb 25 13:57:37 2016 +1300 pidl: Use a tmp_ctx helper variable This is so we free the ndr_push_struct_blob() return value after we make it into a string Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Shouldn't affect us, but it makes diffing cleaner. Change-Id: I52ee911f89813e6f5a90445be4eb52494e3f69d3 Reviewed-on: https://code.wireshark.org/review/16739 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-27Copy change from Samba repository:Guy Harris1-1/+1
commit dffa2dbfabca14f07af12663fc93c8dc3bc837cf Author: Andrew Bartlett <abartlet@samba.org> Date: Thu Feb 25 13:57:00 2016 +1300 pidl: Use the $mem_ctx helper variable This is already set to pytalloc_get_mem_ctx(py_obj) Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Shouldn't affect us, but it makes diffing cleaner. Change-Id: I60fddc0a1055095ecad51180c9e1fc2223d2c017 Reviewed-on: https://code.wireshark.org/review/16738 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-27Copy over change from Samba repository:Guy Harris1-5/+7
commit 9e07f3a13b41be1f019887581b2a2bd049039a3d Author: Andrew Bartlett <abartlet@samba.org> Date: Tue Feb 16 14:06:28 2016 +1300 pidl: Fix our python reference handling The new talloc.BaseObject allow us to hold a talloc context per python object (there may be many referring to the same C object) and the talloc context that the actual object pointer is under. Another advantage is that talloc.BaseObject(), has less of an ABI surface. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Shouldn't affect us, but it makes diffing cleaner. Change-Id: If4a7d9d3f5eb0acf9f94b10af870a0e01fa52b5c Reviewed-on: https://code.wireshark.org/review/16737 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-27Pick up changes from the Samba repository:Guy Harris1-15/+42
commit 59d530c0b692dae41ea271bfdb473f212615041b Author: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Date: Tue Mar 1 14:18:52 2016 +1300 ndr: Use ndr_steal to avoid long lists When pulling complex structures like nt-acls, a long list of tokens may be produced. By removing tokens along the way with ndr_token_steal, future calls to retrieve from the token list are not as expensive. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> commit 9af628a488d2b628e6c33917be7030602eeb5fde Author: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Date: Fri Feb 26 17:01:37 2016 +1300 ndr: avoid unnecessary searches of token list When pulling complex structures like nt-acls, a long list of tokens may be produced. This change means the token list won't be walked in the buffers case if the switch value is not needed. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Change-Id: I0e0ce345e5184e0cd180b0079dd693a7ed3f31ef Reviewed-on: https://code.wireshark.org/review/16736 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-27Fix from the Samba repository:Guy Harris2-4/+3
Author: Aurelien Aptel <aaptel@suse.com> Date: Wed May 18 14:23:56 2016 +0200 pidl/ws: fix failing tests This commit fixes 2 test failures in Pidl test suite. - commit 02cd7808 changed the error the test was expecting => update expected output in the test - commit c76b65e changed whitespaces in the output => revert to the old output in the generator Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Change-Id: I142d4ae405edfff760c00b95e0475502a1eac2f0 Reviewed-on: https://code.wireshark.org/review/16734 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-21Add proto_tree_add_checksum.Michael Mann1-1/+1
This is an attempt to standardize display/handling of checksum fields for all dissectors. The main target is for dissectors that do validation, but dissectors that just report the checksum were also included just to make them easier to find in the future. Bug: 10620 Bug: 12058 Ping-Bug: 8859 Change-Id: Ia8abd86e42eaf8ed50de6b173409e914b17993bf Reviewed-on: https://code.wireshark.org/review/16380 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-10Cleanup and extend the regex for matching expert info entries.Jeff Morriss1-19/+17
Match each entity in the structure explicitly rather than skipping a bunch at the end. This makes it possible to easily (and clearly) specify where we allow white space. Don't capture the event group and severity: we don't use them anyway. Don't put single character matches in []: that makes it hard to read (for me anyway). There's no need for both the "m"(ultiline) and "s"(ingle line) options. Nor the "o"optimize (make buggy) option. These same changes should/will be applied to the hf regex later. Change-Id: I3bf307dcd6432eb1a0c2b9aceea201f8403e08c0 Reviewed-on: https://code.wireshark.org/review/16313 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-05Remove remnants of g_spawn_helper supportPascal Quantin1-2/+0
Change-Id: I88121a280ff01a889daeda438b308380b6ea0703 Reviewed-on: https://code.wireshark.org/review/16303 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-05extcap: Remove g_spawn_helper supportRoland Knall1-3/+1
Move g_spawn to separate file and implement functions to use Windows based method of spawning, instead of the glib based version Change-Id: Ibae03d834ec86531eba37dc8768fbf17ddadf57f Reviewed-on: https://code.wireshark.org/review/16049 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-07-03checkhf: Use colon as field separator for better readabilityJoão Valverde1-4/+4
Comma looks like a list when skimming quickly. Change-Id: Ic0ac1bc8746c70724d2279e3d725c5c9449b79d8 Reviewed-on: https://code.wireshark.org/review/16260 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-30Recompress PNGs.Gerald Combs1-7/+29
Recompress PNGs using the current versions of various compressors: optipng 0.7.6 advpng 1.20 advdef 1.20 pngcrush 1.8.1 Parallelize PNG compression. Note why we're not using a couple of other compression utilities. Change-Id: I52757d0bc2d424013e7f00b693a0f5378427cc31 Reviewed-on: https://code.wireshark.org/review/16209 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-30remove Wireshark.pro, modify update-tx accordinglyMartin Kaiser1-2/+3
Wireshark.pro is the qt project file used by qmake which in turn was used by nmake now that nmake is gone, the only reason to keep Wireshark.pro was the update-tx script that syncs our translation files with Transifex update-tx calls lupdate to create a list of texts to translate and lrelease to convert such a list into a binary file lupdate and lrelase can read file names from a project file or get them on the command line modify update-tx to pass the required file names on the command line we can use wildcards so there's no need to change update-tx when a new source file is added remove Wireshark.pro from the release tarball as well Change-Id: I7ff4ebc96f13b4ffc6fb1b2f4e045999fbfbed5e Reviewed-on: https://code.wireshark.org/review/16151 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-06-21debian-setup: add additional params to apt-get.Dario Lombardo1-18/+19
Can be used to pass params like -qq and -y for automated installations, like in travis-ci. Change-Id: Iddf18829f09ce6b16c1c71264adab38d0a893fe6 Reviewed-on: https://code.wireshark.org/review/15999 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-06-20[pre-commit-ignore] Dont check the asn1 files they are imported verbatimeAndersBroman1-0/+1
from standards documents in most cases. Change-Id: Ie9db1a1431a201dc374f800b5118a199dcb51b9c Reviewed-on: https://code.wireshark.org/review/16035 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-18DCE/RPC: fix array of pointers with NULLBinh Trinh1-0/+1
Change-Id: Ie89f8fd4ec744d427d41866206d5a6784c5b224f Reviewed-on: https://code.wireshark.org/review/16004 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16lemon: use a define for fseek()'s whence parameterMartin Kaiser1-1/+1
for people who don't immediately understand what fseek(fp, 0, 2) does Change-Id: I297ba6fd718ef0f09c4d0b29bf433262c3c38435 Reviewed-on: https://code.wireshark.org/review/15976 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_with_flagsMichael Mann1-25/+44
Change-Id: I8891ec90244ffd9609d8443df631a7c8e6453b7e Reviewed-on: https://code.wireshark.org/review/15942 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16X11: Fix last indent issue on X11 generatorAlexis La Goutte1-23/+23
and regenerate X11 dissector Change-Id: If2c781d346713f5a2a2e97de84c0fedcfd1958af Reviewed-on: https://code.wireshark.org/review/15944 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-15Remove Nmake build systemPascal Quantin10-329/+2
Change-Id: I3bd474f3cda9667dec66426b5729449953df3e61 Reviewed-on: https://code.wireshark.org/review/15777 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de> Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2016-06-15Win: convert atkversion.h to UTF-8Pascal Quantin1-4/+4
Change-Id: I7bfa9be11596cc9a3e1b0226c6865edf47e96782 Reviewed-on: https://code.wireshark.org/review/15931 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-15win-setup.ps1: stop downloading user-guide; with CMake it is generated from ↵Pascal Quantin1-2/+0
source code Change-Id: I3b015594bd6a6b0c41938ba17d5690c08e04f490 Reviewed-on: https://code.wireshark.org/review/15917 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-13Indent register.c and other cosmetic changesJoão Valverde1-13/+31
Change-Id: I06e863e0b87118047f4c3b7618df02b9c7384a34 Reviewed-on: https://code.wireshark.org/review/15836 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-12Have MemoryCheck() directly incorporate the error message and exit.Guy Harris1-13/+3
Manually inline memory_error() in MemoryCheck(), so that static analyzers know that, if MemoryCheck() sees a null pointer, it exists, and the null pointer isn't subsequently used. Use MemoryCheck() instead of the one place where we manually checked for a null pointer and called memory_error(). Change-Id: Id6b0328cfd17cb14ec9d1e461420896a31573c71 Reviewed-on: https://code.wireshark.org/review/15851 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-12Add more memory checks, and use MemoryCheck() for some existing checks.Guy Harris1-31/+14
Always check for malloc() and realloc() failing. Use MemoryCheck() for most of the checks - it's a bit cleaner and makes the error message the same for those checks. Change-Id: I533153c697b37b85adfa0259c1352efece0b0486 Reviewed-on: https://code.wireshark.org/review/15849 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-06Add support in checkhf.pl for expert info.Michael Mann1-5/+158
Basically a copy/paste of the existing hf_ functionality, but looking for ei_ variables instead. Change-Id: Ic9a34f6bd5dee895fc858bb9631c00271a86486b Reviewed-on: https://code.wireshark.org/review/15717 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-03Remove an ellipsis UTF-8 character in gsignal.hPascal Quantin1-2/+2
Change-Id: Ic31dab513fc2ff5f2f182ae98c1b665ea4b8916b Reviewed-on: https://code.wireshark.org/review/15713 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-05-30Add nghttp2 folder to ignore pre-commit checkAlexis La Goutte1-0/+1
Change-Id: I6b76b55325db494f16488decfe94ff4129d0ac40 Reviewed-on: https://code.wireshark.org/review/15616 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-21[skinny] Fix StartMediaTransmissionMessage and OpenReceiveChannelMessage ↵Diederik de Groot1-3/+3
protocol version 20 - StartMediaTransmissionMessage is variable length - latentCapsInfo moved to protocol version 21-22 Change-Id: I4136c7007a8f9d6a8a3370d45faab62bbe983524 Reviewed-on: https://code.wireshark.org/review/15512 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-05-17[skinny] Update message definitionsDiederik de Groot1-6/+16
- Deal with short EnblocCallMessage coming from 7936 - SubscriptionStatReqMessage is shorter than previously known - Use buttonType enum in FeatureStatV2Message and FeatureStatMessage Change-Id: I0c4db5a0199ebb95bf807c858971d763faeef016 Reviewed-on: https://code.wireshark.org/review/15427 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-13Move the Valgrind size check after the capinfos check of the file.Jeff Morriss1-5/+5
That way if we pass a file that doesn't exist to the fuzz-test script we won't get errors from 'ls' complaining that the file doesn't exist. Change-Id: I33f4bd692775e6d3f990adaaa37b7530d343fe52 Reviewed-on: https://code.wireshark.org/review/15410 Reviewed-by: Anders Broman <a.broman58@gmail.com>