aboutsummaryrefslogtreecommitdiffstats
path: root/tools
AgeCommit message (Collapse)AuthorFilesLines
2016-01-31plugins: do not import symbols globallyPeter Wu1-1/+1
Clang's ASAN reported an ODR violation when plugins were loaded. Sure enough, symbols did actually get loaded twice: ==5898==ERROR: AddressSanitizer: odr-violation (0x7fffd95a35e0): [1] size=7 'version' plugins/mate/plugin.c:19:31 [2] size=6 'version' plugins/opcua/plugin.c:19:31 After this change, plugins cannot insert new symbols in the global namespace. Change-Id: Ib11f7263e9c586f8e7c1f8f5fb239b20d46ddd2f Reviewed-on: https://code.wireshark.org/review/13260 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31lemon: fix leak.Dario Lombardo1-2/+6
Found by clang's ccc-analyzer. Change-Id: I04eaad73486a43a77c4f08cf519bbfe7d2d8c838 Reviewed-on: https://code.wireshark.org/review/13581 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-29tools: improve debian-setup with optional packages.Dario Lombardo1-2/+20
Change-Id: Ie7480b0c5297039aadfa253fce84c66b0e217814 Reviewed-on: https://code.wireshark.org/review/13596 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2016-01-29lemon: Have Makefile.am handle warnings as errors correctlyJoão Valverde1-1/+1
Change-Id: If0d59eb109802a799c33e439e607178102678f7d Reviewed-on: https://code.wireshark.org/review/13580 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28Add fnmatch support to git pre-commit hookJoão Valverde4-37/+125
Allows for wildcard pathname matching in ignore list. Change-Id: I52e47c72c69e16ff9aefadfde22d1bd682df9654 Reviewed-on: https://code.wireshark.org/review/13166 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris1-0/+1
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-22lemon (tools): Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-22/+25
Change-Id: Ica08d9372fbe3809eb078e0285cba2a49cee6b8d Reviewed-on: https://code.wireshark.org/review/13331 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-12Fix another warning on 64-bit platforms.Guy Harris1-1/+1
Change-Id: I5cdf55cdaef048d9d564a5fca39027dae3b78bab Reviewed-on: https://code.wireshark.org/review/13242 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-12Add the comment about the Wireshark changes github repo from the commitJoerg Mayer1-1/+2
messages to the README. Change-Id: Ia73807ca4c04ca0e9019ed22e5733bf378cdf327 Reviewed-on: https://code.wireshark.org/review/13241 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-01-12Lemon: resync with upstreamAlexis La Goutte3-286/+492
lemon: Thu Oct 29 13:48:15 2015 lempar: Tue Nov 10 14:51:22 2015 a copy of all Wireshark changes are available https://github.com/alagoutte/sqlite/tree/wireshark Change-Id: I51f8b40a7087362502f6ce2156820a9f107ddf15 Reviewed-on: https://code.wireshark.org/review/13033 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-10checkfiltername.pl: Don't print empty line on successful runJoão Valverde1-43/+43
Change-Id: I3915a5771786bc763747ed74fadede15353fdf40 Reviewed-on: https://code.wireshark.org/review/13165 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-09checkAPIs: remove false positive in shadow checkPeter Wu1-1/+1
" strlen (" would match the shadow regex due to backtracking. Disable backtracking with the "possessive quantifier". Change-Id: If5d307fd61f252c41ad6d9b6104d2add1dfa63ae Reviewed-on: https://code.wireshark.org/review/13157 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-09Add lempar to pre-commit ignore listAlexis La Goutte1-0/+1
Change-Id: I4ad9b1dadfdb51ad750cc61782eca69125989b55 Reviewed-on: https://code.wireshark.org/review/13144 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: João Valverde <j@v6e.pt>
2016-01-07lemon: Fix warnings [-Wpedantic]João Valverde1-26/+31
Change-Id: I7b350b2c4de5f86de24c8f2309016f3de7af8516 Reviewed-on: https://code.wireshark.org/review/12959 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-06checkAPIs: Add "system" to possible shadow variable (on OS X)Alexis La Goutte1-0/+1
See I651e76c6d53b0 Change-Id: I8082f22da0d16655104ad8699f08abdaf916a941 Reviewed-on: https://code.wireshark.org/review/13078 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-05Add basic exclude facility to pre-commit hook checksJoão Valverde2-0/+19
Change-Id: If08fd1481e58f785fed90a7d8c24aa2a1e0f3df7 Reviewed-on: https://code.wireshark.org/review/12958 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-31lemon: Fix warnings [-Wcast-qual]João Valverde1-8/+8
Change-Id: I2b9efa50cf6385622601d2a80f4cc51691d080a1 Reviewed-on: https://code.wireshark.org/review/12960 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-20Add %ProgramW6432% to the list of search paths when looking for 7-Zip.Christian Tellefsen1-0/+1
This allows a 64bit 7-Zip installation to be located even though win-setup.ps1 is run by a 32-bit process. This applies to 64bit Windows (7, 10, Server 2008 R2, Server 2012). Tested on 2012. Ref: https://msdn.microsoft.com/en-us/library/windows/desktop/aa384274%28v=vs.85%29.aspx Change-Id: I6f4f3226b25c890cd674bf4c4d9ea73ddfc8ece0 Reviewed-on: https://code.wireshark.org/review/12740 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-12-13Create a way to register "capture" dissectors.Michael Mann1-12/+0
Capture dissectors could be architected like dissection dissectors, with tables and subtables and possibly using tvbs to pass there data instead of raw byte arrays. This is a first step towards that by refactoring capture_info_packet() to work off of a "capture dissector table" Registering the capture dissection functions instead of calling them directly also clears up a bunch of dissector header files who sole purpose was providing the capture dissection function definition. Change-Id: I10e9b79e061f32d2572f009823601d4f048d37aa Reviewed-on: https://code.wireshark.org/review/12581 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-12Update USBPcap installer packagedPascal Quantin1-4/+4
NSIS script modified to: - check for KB 3033929 presence on Windows 7 / 2008R2 (as we sign drivers with a SHA2 certificate) - do not delete the installation folder if not empty Bug: 11766 Change-Id: I5c7b6378b0775bb75c1b9e58e503997176c12213 Reviewed-on: https://code.wireshark.org/review/12546 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-11new_create_dissector_handle -> create_dissector_handle for plugins.Michael Mann1-1/+1
Change-Id: I0d485b1337c669291ad58b6c096657ce2db353c8 Reviewed-on: https://code.wireshark.org/review/12516 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-10Convert ASN.1 dissectors to remove "new" from "new-style" dissector function ↵Michael Mann1-40/+19
names that were generated from asn2wrs.py This includes: 1. new_create_dissector_handle -> create_dissector_handle 2. new_register_dissector -> register_dissector 3. new_register_ber_oid_dissector -> register_ber_oid_dissector 4. new_register_ber_syntax_dissector -> register_ber_syntax_dissector Also remove PDU_NEW, SYNTAX_NEW and REGISTER_NEW as there is no need for the distinction anymore. Change-Id: I82c7de7c8ffeeab3259d1b55bb4afc5f6a1e0329 Reviewed-on: https://code.wireshark.org/review/12491 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09Skinny: packet-skinnyDiederik de Groot1-3/+5
Fix messages generated by 894X phones, which do not always include all fields Revert accidental change by using of an older packet-skinny.c.in file Change-Id: I4c6f0ef053579cbbd0c15e90b44dda6a6b173d0d Reviewed-on: https://code.wireshark.org/review/12478 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-07Spelling fixes for errors found by lintianBalint Reczey2-2/+2
Change-Id: I889283902875193f4d3f3fd59788f59f8d9bcc20 Reviewed-on: https://code.wireshark.org/review/11945 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-05Use noyywrap rather than defining our own yywrap functions.Guy Harris1-0/+2
Tweak lemonflex-tail.inc to fix an issue this reveals. It appears that, at least on the buildbots, the Visual Studio compiler no longer issues warnings for the code generated with %option noyywrap. Change-Id: Id64d56f1ae8a79d0336488a4a50518da1f511497 Reviewed-on: https://code.wireshark.org/review/12433 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-02eCMP Dissector - Extensible Control & Management ProtocolJames Lynch1-0/+1
Developed by Emerson Industrial Automation (Control Techniques Division) eCMP is a protocol for setting up and controlling the devices in a factory automation system. eCMP has about 30 commands; most are embedded into TCP/IP messages, but cyclic data messages use the UDP protocol. Bug: 10562 Change-Id: I9a421f39dfbdbc9e28d8f7cba72c22e270064641 Reviewed-on: https://code.wireshark.org/review/3157 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-29Support building the X11 dissector outside the source tree.Jeff Morriss2-40/+54
Use relative path names for the script names and mesa/xcbproto directories so different paths (from different users) don't cause deltas. Also, with help from Peter Wu and Graham, get generation of the X11 dissector working from cmake. Change-Id: I95cd2a0f973dcbc67f457ff94c28e46a666afb74 Reviewed-on: https://code.wireshark.org/review/12213 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-11-27Officially remove tvb_get_string and tvb_get_stringz.Michael Mann1-2/+0
Almost all replacements were done awhile ago, just put the final nail in the coffin. Change-Id: I0a708d886da5a500c2a1e2c9ee2736794bdb9411 Reviewed-on: https://code.wireshark.org/review/12206 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-25asn2wrs.py: always use relative pathsPeter Wu1-6/+10
Avoids absolute paths when using cmake and doing an in-tree build. Before (source directory is /tmp/wireshark): /*--- Included file: /tmp/wireshark/asn1/t38/packet-t38-exp.h ---*/ After: /*--- Included file: packet-t38-exp.h ---*/ Change-Id: Id5c98bff7b97447479e1a09751701f2f52132b20 Reviewed-on: https://code.wireshark.org/review/12118 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-11-23lemon (tools): Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-23/+33
Change-Id: I6be51833b4268dbfde5c78820004a4714779b0c5 Reviewed-on: https://code.wireshark.org/review/9515 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-11-22asn2wrs.py: fix path substitution when generating ASN.1 dissectors with ↵Pascal Quantin1-2/+2
CMake on Windows Change-Id: I48e7d48544274f27d276e7128f8d2a2727c0b9cd Reviewed-on: https://code.wireshark.org/review/12031 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-21Fix Windows hardening check (x64)Graham Bloice1-0/+9
Fix the x64 ones missed on commit f1efeb1eba8329 Change-Id: Iec432c81511c64145711052bb29f6484c6c1c5b1 Reviewed-on: https://code.wireshark.org/review/12020 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Graham Bloice <graham.bloice@trihedral.com>
2015-11-21Fix Windows hardening checkGraham Bloice1-2/+56
The hardening check runs on all binaries and quite a few third party binaries are not hardened, thus leading to a warning on the buildslave. The change reduces the noise by not counting the binaries that are known to be "soft". They are still printed in the output though, for reference. Also fixed the search directory passed to the script. Change-Id: I1619066c687c9ba934ab38fccbbf2011108328e4 Reviewed-on: https://code.wireshark.org/review/12016 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Graham Bloice <graham.bloice@trihedral.com>
2015-11-21autotools: Fix extra-compiler-warnings for system headersJoão Valverde3-16/+0
Use -isystem instead of -I for external headers with GCC/clang to squash all the noise. cmake already uses -isystem by default for supported platforms/compilers. Change-Id: Ia6c9d1eb9b894fda6f48c531094d792e16fd39fc Reviewed-on: https://code.wireshark.org/review/11947 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-11-20More spelling fixes found by lintianBalint Reczey2-3/+3
Change-Id: Id218dec9e5a721d6c63fd34962ffe50b6ab8dd56 Reviewed-on: https://code.wireshark.org/review/11946 Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Diederik de Groot <dkgroot@talon.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-12[GTK] Replace deprecated gdk_pixbuf_new_from_inline()João Valverde2-1/+78
Use GResource instead, if available. Add autotools and cmake compile time checks for build requirements (GIO >= 2.32 and GDK-Pixbuf >= 2.26). Merge all the various static pixbuf csource header files into a single pixbuf-csource.h header with external linkage through use of the tools/make-pixbuf-csource.pl script. Fix inline pixbuf build target for some image paths (broken for GTK in gb4a4de7). Add missing 'expert_ok.png' file to distribution (GTK only). Minor improvements to style/structure of ui/gtk/Makefile.am. Bug: 10750 Change-Id: I031296b666ee8b92730400dfa6f71f9ee4304863 Reviewed-on: https://code.wireshark.org/review/10992 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-11Update user guide for upcoming 2.0 releasePascal Quantin1-4/+4
Change-Id: Id27365d6bd7085f498edd78111d85de0fbd0abd3 Reviewed-on: https://code.wireshark.org/review/11738 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-10Initial Sysdig syscall (event) support.Gerald Combs2-0/+346
Add a dissector for reading Sysdig event blocks. It only handles plain events but it's usable for reading trace files on hand here. Use a script to generate various parts of the dissector. As an experiment, update parts in-place instead of using a template. Ultimately there should probably be a top-level "Syscall" or "Event" dissector alongside the "Frame" dissector, which could then call this. You could then directly compare an executable's system calls alongside its network traffic. For now leverage the pcapng_block dissector and keep everything under "Frame". Next steps: - Items listed at the top of packet-sysdig-event.c. Change-Id: I17077e8d7f40d10a946d61189ebc077d81c4da37 Reviewed-on: https://code.wireshark.org/review/11103 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-11-10Make the dfilter time tests work regardless of what time zone the tests areJeff Morriss1-18/+23
being run in. Do this by forcing the time zone to be UTC (by modifying the environment). Change-Id: I13c47deada82b55a464006f9c3cc60115b2e4f20 Reviewed-on: https://code.wireshark.org/review/11378 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-01tools/pidl: avoid trailing tabsStefan Metzmacher1-1/+4
Change-Id: I293dd6f2d7ff3b0e27bc3cc49e69977604f12260 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/11433 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-30Remove build-qt-sdk.bat.Gerald Combs2-95/+0
The buildbots have been using pre-built packages from The Qt Company for a while now and it's unlikely we'll have to compile our own in the future. Change-Id: Iee93ab05af46f40585256f991b176392f018727a Reviewed-on: https://code.wireshark.org/review/11449 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-10-30Explain why Get-HardenFlags currently fails.Gerald Combs1-0/+15
Change-Id: I4a956b2479a482a9262e6e67f6c7611fad9dde84 Reviewed-on: https://code.wireshark.org/review/11448 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-10-30Add a few new negative dfilter tests.Jeff Morriss1-2/+17
For example, to ensure that "field = value" is not a valid dfilter (as was recently a problem). As suggested by Alexis. Change-Id: Ibf498c30325579e3d5474bb2d397f1bbb9ffc07f Reviewed-on: https://code.wireshark.org/review/11339 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-29tools/checkAPIs.pl: improve the hf_ error messagesStefan Metzmacher1-6/+6
Change-Id: Ie8132f317f2d1c27af83218c48874941bd3cc5d0 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/11390 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-25Bail out immediately if we can't allocate a buffer for carving up $PATH.Guy Harris1-11/+10
Quit immediately, don't even bother allocating a buffer for the pathname of the file we found. Revert some other cosmetic changes, to reduce the differences between us and upstream. Change-Id: I217fecee64c7e6bac9272486d0cc334e192b501e Reviewed-on: https://code.wireshark.org/review/11253 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-10-25lemon: move free() to avoid mem leak (CID 718529)Dario Lombardo1-8/+11
Change-Id: I3b0740f5ccc3b9b87ed351e26f198152bbb1e599 Reviewed-on: https://code.wireshark.org/review/10801 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-24lemon: add free() to avoid mem leak (CID 1309088)Dario Lombardo1-1/+2
Change-Id: Id32864d324f72ffee9c1033f0f36a79eb2651334 Reviewed-on: https://code.wireshark.org/review/10797 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-21x11 generator: Fix indent (use always 4 spaces) and add modelinesAlexis La Goutte2-608/+634
Change-Id: I91739bb6f4acc4da060cf389ec288ee910965b2a Reviewed-on: https://code.wireshark.org/review/11113 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-20X11 generator: avoid extraneous parens in conditionals.Jeff Morriss1-3/+16
This is to avoid complaints from clang of the form: wireshark/epan/dissectors/x11-extension-implementation.h:17021:18: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if ((f_class_id == 0)) { ~~~~~~~~~~~^~~~ Change-Id: I91d629ad47677b71909d7da517c4a6198c276186 Reviewed-on: https://code.wireshark.org/review/11186 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-10-19x11 generator: Support new XCB paramrefPeter Harris1-5/+39
Change-Id: I8ae38785bd0f2f81fa2164b5bc29274bd7e940f5 Reviewed-on: https://code.wireshark.org/review/11105 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-30 18:50:22 +0000