aboutsummaryrefslogtreecommitdiffstats
path: root/tools
AgeCommit message (Collapse)AuthorFilesLines
2014-10-08[tools] Add missing GPL license to generate-bacnet-vendors.pyAnish Bhatt1-0/+18
Change-Id: I15336a5f759fea6b1fb4f6c5a05807d797a7f5aa Reviewed-on: https://code.wireshark.org/review/4544 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-08Remove #pragma warning (MSVC) for PIDL generate dissectorAlexis La Goutte1-7/+0
Change-Id: I1e4c7944a2cd877f5c707703dcff44fe9f955a2c Reviewed-on: https://code.wireshark.org/review/4479 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-07[tools] add script to automatically generate bacnet vendorsAnish Bhatt1-0/+36
Requires beautifulsoup4 for parsing, translitcodec for converting accents/diaeresis etc to regular text Change-Id: I4d400f15916ee3ab07fa14b09fca12beac2010f3 Reviewed-on: https://code.wireshark.org/review/4518 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-07asn2wrs: Added support for #.SYNTAX_NEWStig Bjørlykke1-4/+12
This allows syntaxes to be registered as "new" dissectors. Change-Id: Ibb76688d9d3cbf47222610956aa627fa374bcbce Reviewed-on: https://code.wireshark.org/review/4524 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-10-07PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang ↵Alexis La Goutte1-1/+1
Analyzer packet-dcerpc-dnsserver.c:1002:12: warning: Assigned value is garbage or undefined packet-dcerpc-frstrans.c:1137:12: warning: Assigned value is garbage or undefined packet-dcerpc-lsa.c:6345:12: warning: Assigned value is garbage or undefined packet-dcerpc-nspi.c:7805:12: warning: Assigned value is garbage or undefined packet-dcerpc-dfs.c:3245:11: warning: Function call argument is an uninitialized value packet-dcerpc-dfs.c:3245:9: warning: 'level' may be used uninitialized in this function [-Wmaybe-uninitialized] Change-Id: Ife6a2f565ae215535d0e3d72ef50800114240e3f Reviewed-on: https://code.wireshark.org/review/4478 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-09-29PIDL: fix indent (use 4 tabs) and remove trailing whitespaceAlexis La Goutte4-80/+80
Change-Id: I0ee63a040867b44ac9915704f5e581483ed6f7e2 Reviewed-on: https://code.wireshark.org/review/4310 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-28PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-2/+6
Change-Id: Ibae478771b30d6e9ae07315985f1e71bc6b65423 Reviewed-on: https://code.wireshark.org/review/4350 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL (DCERPC winreg): enhance dissectorAlexis La Goutte1-0/+1
* Fix PIDL generator for NOEMIT Element (fix -Wunused-function for DCERPC winreg dissector) * Fix indent (use tabs) * Remove DCERPC winreg dissector from DIRTY list Change-Id: I5d16cbfe8481a5e5f7e5df9b51735c93ae4375a7 Reviewed-on: https://code.wireshark.org/review/4322 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL: fix -Wmissing-prototypeAlexis La Goutte1-1/+5
Change-Id: I4cae47450e8026b10bd373828f235184560e0a99 Reviewed-on: https://code.wireshark.org/review/4308 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-27PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8 Reviewed-on: https://code.wireshark.org/review/4319 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-26White space and typo cleanups.Guy Harris3-104/+103
Change-Id: If064178a383ce805ed6f440a1a9d3642a706496c Reviewed-on: https://code.wireshark.org/review/4320 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Update to latest version from Samba Git repository.Guy Harris1-6/+27
Comments from Samba Git log: commit ee2148754e2e2604ac918343fa8769a25523eb49 Author: Stefan Metzmacher <metze@samba.org> Date: Tue Aug 26 21:33:05 2014 +0200 pidl/wscript: remove --with-perl-* options These are not needed anymore as we have useful defaults now. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> commit b537c5a340bae2accbf35a4ec5eab7074b90f0b1 Author: Michael Adam <obnox@samba.org> Date: Mon Aug 25 23:57:23 2014 +0200 pidl: fix the perl module search path (use lib ...) when installing pidl. This way, pidl can also run with modules installed under the $prefix. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Michael Adam <obnox@samba.org> commit 191fc0e541e7c9d0a1095dc287402df9947ce779 Author: Michael Adam <obnox@samba.org> Date: Thu Sep 4 01:38:14 2014 +0200 pidl/wscript: don't check for perl again. This is done at the toplevel now. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Michael Adam <obnox@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> commit 9e591e3d619d127c5ec5f6ac86326c84f59878fa Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:59:45 2014 +0100 pidl-waf: Check for system perl(Parse::Yapp::Driver). Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit 410ada45b7041be6976fcfefadccbb99212a15a3 Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:59:41 2014 +0100 pidl-waf: Add a function to check for a system perl module. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit 17244ef750f699b30ff7ff3a71264f4c76adad6d Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:53:10 2014 +0100 pidl-waf: Install pidl modules to the perl vendorlib directory. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit 0bb6b0102f6fa21e6c9f8010421386a660c5a5e0 Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:54:09 2014 +0100 pidl-waf: Remove unused variable pidl_src. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit 87976b4e45bd71b086e9201f0d0a563b9071ca4a Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:46:01 2014 +0100 Revert "pidl: Install pidl files corrently." This reverts commit cee11cfa4544425099268cd32393169afb4bb107. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit c2d58c3c2059ef3d43f876df547cbc7256235563 Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:45:51 2014 +0100 Revert "waf: Add option to specify perl vendor dir." This reverts commit 9b200555fec2e33da9521db388d1839375aa8d83. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit c46aaf1102da5e8ba53e9f89f2f756fe8dce83c5 Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:45:35 2014 +0100 Revert "pidl: Make perl(Parse:Yapp:Driver) installation optional." This reverts commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838 Author: Andreas Schneider <asn@samba.org> Date: Thu Feb 27 13:14:56 2014 +0100 pidl: Make perl(Parse:Yapp:Driver) installation optional. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Feb 27 18:47:03 CET 2014 on sn-devel-104 commit 9b200555fec2e33da9521db388d1839375aa8d83 Author: Andreas Schneider <asn@samba.org> Date: Tue Feb 25 17:16:37 2014 +0100 waf: Add option to specify perl vendor dir. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Kai Blin <kai@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Feb 27 11:48:54 CET 2014 on sn-devel-104 commit cee11cfa4544425099268cd32393169afb4bb107 Author: Andreas Schneider <asn@samba.org> Date: Tue Feb 25 16:04:24 2014 +0100 pidl: Install pidl files corrently. Globbing is a really bad idea in installtion system. One of them is if you use patch -b to create a backup, you will end up installing the backup file too! BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Kai Blin <kai@samba.org> Change-Id: I9c4491f0d74c24d7c45a59e98825c789097a0c7b Reviewed-on: https://code.wireshark.org/review/4318 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Update to current version from Samba Git repository.Guy Harris1-1/+0
Changes from Samba Git log: commit fac24e11655c554cd3113dfb6fc918a0fd3c880c Author: Michael Adam <obnox@samba.org> Date: Mon Aug 25 23:58:48 2014 +0200 pidl: remove superfluous "use lib ...". BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Michael Adam <obnox@samba.org> Change-Id: I8a2460a9168ef5989e9f5e95b51cca73987b80a4 Reviewed-on: https://code.wireshark.org/review/4317 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Update to latest version from Samba Git repository.Guy Harris1-1/+34
Changes from Samba Git log: commit cf75ef9f73f2cdbf2a039bbc9468f5da6a14834e Author: Stefan Metzmacher <metze@samba.org> Date: Fri May 9 11:49:10 2014 +0200 pidl/lib/wscript_build: make use of PERL_LIB_INSTALL_DIR Bug: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sat May 10 01:37:33 CEST 2014 on sn-devel-104 commit ee8f98f26a3d6f02a0d10ceeac1194675d505246 Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 16:00:54 2014 +0100 pidl-waf: Only install Yapp::Driver if it is not available. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Mar 6 23:30:47 CET 2014 on sn-devel-104 commit b7b0ca1ba9067362bb8a4b901f3a7f2f3bcbd6a1 Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:55:46 2014 +0100 pidl-waf: Do not glob to install pidl modules. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit 17244ef750f699b30ff7ff3a71264f4c76adad6d Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:53:10 2014 +0100 pidl-waf: Install pidl modules to the perl vendorlib directory. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit 87976b4e45bd71b086e9201f0d0a563b9071ca4a Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:46:01 2014 +0100 Revert "pidl: Install pidl files corrently." This reverts commit cee11cfa4544425099268cd32393169afb4bb107. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit c2d58c3c2059ef3d43f876df547cbc7256235563 Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:45:51 2014 +0100 Revert "waf: Add option to specify perl vendor dir." This reverts commit 9b200555fec2e33da9521db388d1839375aa8d83. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit c46aaf1102da5e8ba53e9f89f2f756fe8dce83c5 Author: Andreas Schneider <asn@samba.org> Date: Fri Feb 28 15:45:35 2014 +0100 Revert "pidl: Make perl(Parse:Yapp:Driver) installation optional." This reverts commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838 Author: Andreas Schneider <asn@samba.org> Date: Thu Feb 27 13:14:56 2014 +0100 pidl: Make perl(Parse:Yapp:Driver) installation optional. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Feb 27 18:47:03 CET 2014 on sn-devel-104 commit 9b200555fec2e33da9521db388d1839375aa8d83 Author: Andreas Schneider <asn@samba.org> Date: Tue Feb 25 17:16:37 2014 +0100 waf: Add option to specify perl vendor dir. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Kai Blin <kai@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Feb 27 11:48:54 CET 2014 on sn-devel-104 commit cee11cfa4544425099268cd32393169afb4bb107 Author: Andreas Schneider <asn@samba.org> Date: Tue Feb 25 16:04:24 2014 +0100 pidl: Install pidl files corrently. Globbing is a really bad idea in installtion system. One of them is if you use patch -b to create a backup, you will end up installing the backup file too! BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Kai Blin <kai@samba.org> Change-Id: I4372f2c0854743a0339c7d85ace9e67ce9f8bd02 Reviewed-on: https://code.wireshark.org/review/4316 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Update to current version from Samba Git repository.Guy Harris1-0/+39
Changes from Samba Git log: commit d29c143fae4b67c9680a0b9773db3461f2d0d2b7 Author: Stefan Metzmacher <metze@samba.org> Date: Thu Mar 27 14:56:23 2014 +0100 pidl:Samba4/Python: add interface.abstract_syntax() to each interface Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Change-Id: I9f4650c603ea8b2eff05e7b79d7f44452e1337ab Reviewed-on: https://code.wireshark.org/review/4315 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Update to the latest version from the Samba Git repository.Guy Harris1-7/+25
Changes from the Samba Git log: commit 2ba9453e9ff5d911a146e786ff8878ef67717366 Author: Stefan Metzmacher <metze@samba.org> Date: Thu Sep 26 20:38:12 2013 +0200 pidl:NDR/Client: avoid useless memcpy() If the src and dest pointer of memcpy would be the same we should avoid it in order to avoid valgrind warnings. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> commit f50b561336c7b6c08300e6e477859d1f9fab62c2 Author: Stefan Metzmacher <metze@samba.org> Date: Thu Sep 26 01:20:10 2013 +0200 pidl:NDR/Client: fix dcerpc_function() with [out,ref] pointers Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> commit 662fc2de8c2896503026a2a4052ed1ea8ce78af5 Author: Stefan Metzmacher <metze@samba.org> Date: Fri Aug 30 08:54:10 2013 +0200 pidl:NDR/Client: simplify tevent_req_nterror() usage Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> commit 02c34fe4e51b5e62157eaf2de1d0aaf9fc6b8d72 Author: Stefan Metzmacher <metze@samba.org> Date: Fri Aug 30 08:53:18 2013 +0200 pidl:NDR/Client: add missing TALLOC_FREE(subreq) after dcerpc_binding_handle_call_recv() Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: I19017fd216df8d8d202b995305f4eb7b7a8b9a35 Reviewed-on: https://code.wireshark.org/review/4314 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Update to the latest version from the Samba Git repository.Guy Harris1-1/+2
Changes from the Samba log: commit 3a0fa3605b8eb995a8cc4696256129893e1f6f7e Author: Stefan Metzmacher <metze@samba.org> Date: Sat Sep 21 23:46:01 2013 +0200 pidl:Samba3/ServerNDR: skip DCERPC pipe elements and leave NULL pointers. We don't support them anyway, but this lets us adding them to the idl file and only ignore it on the server. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: Idbe742fa13e5d3892343fde2b3943f38a6e90a8c Reviewed-on: https://code.wireshark.org/review/4313 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Update to the latest version from the Samba Git repository.Guy Harris1-17/+18
From the Samba log: commit bfdc874e8b98c8ea147dbcc986f96ad4f73d800f Author: Jelmer Vernooij <jelmer@samba.org> Date: Sat Aug 30 01:59:26 2014 +0200 Various updates to the pidl README file. Remove samba3/samba4-specific comments, add comments about backends and files. Change-Id: Id2253ce85eab7a684b2c50d25f6f2604dc146a8e Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Sun Aug 31 23:47:49 CEST 2014 on sn-devel-104 commit 6824f1aa67f0a75df5c94921e334c2b7c7771611 Author: Jelmer Vernooij <jelmer@samba.org> Date: Sat Aug 30 01:59:25 2014 +0200 Remove trailing whitespace. Change-Id: I1e0948da34bac278edc62cd63dedd08112426e7a Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Change-Id: Ifd445bf32aca2d30a6e501fc8c8dd030471ad284 Reviewed-on: https://code.wireshark.org/review/4312 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-22fix-encoding-args.pl: Don't use a feature available only starting with perl 5.14Bill Meier1-6/+3
Specifically: Window msys git uses an earlier version of Perl (5.8) and thus invoking fix-encoding-args.pl in the pre-commit hook script gives a Perl syntax error. See https://code.wireshark.org/review/4172 for details (Also see following for Perl info: http://www.perl.com/pub/2011/05/new-features-of-perl-514-non-destructive-substitution.html) Change-Id: I95a222eaa31942cc6e873ffbde57c5fa5bd2a625 Reviewed-on: https://code.wireshark.org/review/4245 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-20PIDL: fix trailing tabspaceAlexis La Goutte1-9/+9
Change-Id: If3b623d82d6bbbf9943a35c8885620881eedb091 Reviewed-on: https://code.wireshark.org/review/4204 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-20proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors.Michael Mann1-2/+1
Change-Id: I84755d059ef70ca98b0e7626b6425360daf0529d Reviewed-on: https://code.wireshark.org/review/4199 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-19Update generated DCE/RPC dissectors.Michael Mann1-101/+127
Now all generated dissectors can successfully compile. Change-Id: I74728926915d5a9f1694cc49c753b80f213df767 Reviewed-on: https://code.wireshark.org/review/2598 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-19fix-encoding-args.pl: Add a few additional fixups;Bill Meier1-17/+29
Specifically: A number of cases of the use of the encoding arg "ENC_ASCII | ENC_NA" for FT_BYTES FIELDTYPEs seem to have crept into Wireshark source. Also: Add a ToDo comment as to code rework needed to be able to better *validate* encoding args. Change-Id: I9d4b10b869fe2aef3f20bcd2d7ad6531375aba87 Reviewed-on: https://code.wireshark.org/review/4183 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-18fix-encoding-args.pl: Add a few fixups for FT_UINT_STRINGBill Meier1-0/+3
Change-Id: Ic22e154859877c48a85b808d0029e10e07876b73 Reviewed-on: https://code.wireshark.org/review/4174 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-18fix-encoding-args.pl: Fix bug: certain patterns found only in 1st,3rd,... ↵Bill Meier1-6/+9
file checked Another perl "You can't DO that" ... Change-Id: I56e11bec19515f883f15286c6aa45018a255ab53 Reviewed-on: https://code.wireshark.org/review/4172 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-04Bump the time limit for valgrind fuzzingEvan Huus1-2/+2
Some captures are still hitting the limit as a false positive. Bug: 10122 Change-Id: I12dd26ba0f96f44799f5ae642b1f9b0487f86a8a Reviewed-on: https://code.wireshark.org/review/3982 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-08-31Remove make-tapreg-dotc and its uses, since Python is now mandatoryРоман Донченко2-46/+0
Change-Id: I13fd57a288be68d18819826bf566ed7b5688ebaa Reviewed-on: https://code.wireshark.org/review/3926 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2014-08-29Skinny:Diederik de Groot1-0/+6
Fix: ensure that string created in dissect_skinny_displayLabel is always NULL terminated (Fixing Bug: 10429 (Pascal)) Fix: MiscCommandType should use videoFastUpdateGOB Union when command enum is videoFastUpdatePicture Manual Merge PatchSet 4 (Me) and Patchset 7 (Pascal) Fix Merged PatchSet 8 (Pascal) Bug: 10429 Change-Id: I87bc7c6eaff976d7a70856f5fbe8c0ded6257064 Reviewed-on: https://code.wireshark.org/review/3893 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-27checkhf.pl: (Trivial) remove trailing whitespace.Bill Meier1-38/+38
Change-Id: I37ece54d936541b5d92e8c323ffeb429d9cc5f33 Reviewed-on: https://code.wireshark.org/review/3879 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-26Skinny:Diederik de Groot1-3/+3
Do not try to create a wmem_strbuf whose size is bigger than the max size allowed -> using wmem_strbuf_new instead of wmem_strbuf_sized_new (Evan Huus) While we are at it, fix errors spotted by the pre-commit tools/SkinnyProtocolOptimized -> Did not get any, can you specify which errors ? (Pascal Quantin) FT_IPv6: 'ENC_BIG_ENDIAN | ENC_NA' -> 'ENC_NA' only (2) (Pascal Quantin) Revert back to wmem_strbuf_sized_new instead of wmem_strbuf_new (Pascal Quantin) Use wmem_strbuf_sized_new maxlength = 0 (Pascal Quantin) Bug: 10409 Bug: 10410 Change-Id: Iebfcb53bc0a6289e02d10c38ecb717aa5c89389e Reviewed-on: https://code.wireshark.org/review/3862 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-08-26Add custom_layer_chm.xsl to UNKNOWN (fix checklicence)Alexis La Goutte1-0/+3
Change-Id: I4c336f21f721443e83eca7b9bf8d7a6138b367f4 Reviewed-on: https://code.wireshark.org/review/3827 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-08-26Skinny: do not try to create a wmem_strbuf whose size is bigger than the max ↵Pascal Quantin2-2/+2
size allowed While we are at it, fix errors spotted by the pre-commit tools/SkinnyProtocolOptimized Bug: 10409 Change-Id: Ic84632e0563f801239603534121e3487cf0d6d24 Reviewed-on: https://code.wireshark.org/review/3861 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-25Skinny Dissector:Diederik de Groot1-3/+25
Source Fix: Trailing Whitespace (Reported by Graham Bloice). Dissection Fix: ProtocolVer needed to be split up into two fields to display the protocol version correct during device registration Segfault Fix: Null Pointer Check required after returning from tvb_memdup, before calling strlen (Reported by Evan Huus) Fix: Whitespace (again) Bug: 10409 Change-Id: Ib253ea843363792f678f2e724359f83f12ebfadc Reviewed-on: https://code.wireshark.org/review/3844 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-25checkhf.pl: (Trivial) fix two typosBill Meier1-2/+2
Change-Id: I2a63127dcf819d671a4c814dcbd82b2dca5022d3 Reviewed-on: https://code.wireshark.org/review/3838 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-25Skinny: packet-skinnyDiederik de Groot1-0/+14
Add tools path to the python search path, fixing cog.py generation of package-skinny.c from packet-skinny.c.in Add GPLv2 License to parse_xml2skinny_dissector.py Change-Id: I91b76867b02d8cebc40bba35151db48bc2fcaeca Reviewed-on: https://code.wireshark.org/review/3819 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-24[RFC] Skinny: Rewrite using automatic code generationDiederik de Groot2-0/+4950
Support: Protocolversion 0 - 22 Includes: Callmanager to/from Cisco Phones, Inter CallManager Messages and CallManager to/from Cisco ASA Code Generator not included, because protocol does not evolve anymore / No newer versions to be expected Fixed: Added more readable information for SoftKeyTemplateRes and SoftKeySetRes, Added Bitfield processing, Added Longer Field Descriptions Fixed: message_handle array overrun, message_ids, hf_skinny fields format Fixed: dialedNumber Message, Setting data on si->fields (tap.h) Fixed: Comments made by Peter Wu Added: Code Generator Sources Fixed: hf_skinny blurp, XML Truncation, Updated ButtonTemplate, SoftKeyTemplate and SoftKeyRes presentation Fixed: EnblocMessage, DialedNumberMessage Added: DisplayLabels Added: dissect_skinny_DisplayLabel function to Lookup and Translate in the phone embedded strings to human readable form Fixed: CallInfoV2, OpenReceiveChannelAck, KeypadButton when generated by a 7912 running old firmware. Fixed: Made changes requested by Peter Wu, in last 2 reviews Fixed: ConfigStatV2, ServerRes Fixed: Comment made by Michael Mann Fixed: CheckAPI.pl / Petri Dish Fixed: Included packet-skinny.h and epan/dissectors/packet-skinny.h.in -> Petri Dish Change-Id: Ic2d2ead8ff0ce80668c9b2e249ce69f53e25a383 Bug: 10262 Reviewed-on: https://code.wireshark.org/review/2921 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-08-22X11: Support xcb's new <case>Peter Harris1-15/+22
Change-Id: I32c6ab15d6dc7a67cdb50c4187e2752730315588 Reviewed-on: https://code.wireshark.org/review/3751 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-08-20Modified script to not use PS 3.0 constructsGraham Bloice1-2/+2
Change-Id: I0a4a738a410f0aece9459852a51d6c96f11aae76 Reviewed-on: https://code.wireshark.org/review/3739 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-19"Highly discourage" use of proto_tree_add_text.Michael Mann1-1/+3
Change-Id: I2e8d18df71688c654f7acaff51fae7823c08aa6a Reviewed-on: https://code.wireshark.org/review/3677 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-15Windows: Fix PowerShell 2.0 compatibility.Gerald Combs1-1/+1
PowerShell 2.0's Get-ChildItem doesn't support "-File" even though http://technet.microsoft.com/en-us/library/hh847897.aspx says otherwise. Add a config.nmake option to test PS 2.0 compatibility. Change-Id: I8de83cd0841d4ab0b01351c2d39084578a2c84ee Reviewed-on: https://code.wireshark.org/review/3625 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-08-14Remove errant #! from powershell scriptGraham Bloice1-1/+0
Change-Id: I6c94ce5983654eba20aa8c852efe300e06c957a5 Reviewed-on: https://code.wireshark.org/review/3599 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2014-08-14fix one last reference to textify.shEvan Huus1-1/+1
Change-Id: I2f8bd5a69fd80d6d34a4079cd05a4f4b278274fd Reviewed-on: https://code.wireshark.org/review/3594 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-14Windows: Clean up text file packaging.Gerald Combs2-68/+93
Convert textify.sh to PowerShell. Use PowerShell's built-in line ending conversion so that we don't depend on unix2dos. Only copy the help toc and text files to the staging directory. Add PowerShell to the Developer's Guide. Fixup some other content. (asn1/Makefile.inc.nmake contains a call to u2d. Hopefully that's not a problem.) Change-Id: I61a92aa54820d01015abb9ffa65815558ae31c71 Reviewed-on: https://code.wireshark.org/review/3487 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
2014-08-12Remove make-dissector-reg and require python for autotool builds as wellJoerg Mayer2-147/+0
Change-Id: I6239063a08ba37199a4e95302a3650a80544c750 Reviewed-on: https://code.wireshark.org/review/3562 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-08-04Don't try and run checkAPIs.pl on deleted filesEvan Huus1-1/+1
It fails, for obvious reasons, and makes it impossible to commit the removal of c/h files. Change-Id: Ifcd067f8959684e2e0191983fd60fb94ae86bca3 Reviewed-on: https://code.wireshark.org/review/3401 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-07-31Add more files to the release tarball.Guy Harris1-2/+55
Change-Id: I02ce275154979ff56f8f8929e5909f3035f62c47 Reviewed-on: https://code.wireshark.org/review/3286 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-28Fix download of 3rd party packages when WIRESHARK_TARGET_PLATFORM ↵Pascal Quantin1-2/+3
environment variable is not explicitly set Bug: 10317 Change-Id: Ic7b4ffe2bbe4f69928b91a5151d8cef1ae59f723 Reviewed-on: https://code.wireshark.org/review/3203 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-25Replace lseek/fstat by ws_lseek64/ws_fstat64Peter Wu1-0/+2
lseek returns an off_t type which is system-dependent. Use ws_lseek64 in favor of lseek as that supports 64-bit quanities. Use ws_fstat64 instead of stat to support 64-bit file sizes on Windows. For the majority of the changes, this makes no difference as they do not apply to Windows ("ifndef _WIN32"; availability of st_blksize). There are no other users of "struct stat" besides the portability code in wsutil. Forbid the use of fstat and lseek in checkAPIs. Change-Id: I17b930ab9543f21a9d3100f3795d250c9b9ae459 Reviewed-on: https://code.wireshark.org/review/3198 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-25Remove valgrind suppression for old zlib versionEvan Huus1-9/+0
The fuzzbot has been upgraded, so hopefully this is no longer necessary. Change-Id: Ia2d8ae03180c6e0b81a4f7b69b72610d047307ff Reviewed-on: https://code.wireshark.org/review/3194 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-07-22Add back a 'dummy' comment I removed with commit e91121e1435d97c92Joerg Mayer1-1/+1
Change-Id: Ia21dc80c8b942fbc1a85a8990354bdaaf9dc8210 Reviewed-on: https://code.wireshark.org/review/3161 Reviewed-by: Jörg Mayer <jmayer@loplof.de>