aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2016-03-20Create call_data_dissector() to call data dissector.Michael Mann7-37/+18
This saves many dissectors the need to find the data dissector and store a handle to it. There were also some that were finding it, but not using it. For others this was the only reason for their handoff function, so it could be eliminated. Change-Id: I5d3f951ee1daa3d30c060d21bd12bbc881a8027b Reviewed-on: https://code.wireshark.org/review/14530 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann5-6/+6
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-17Associate dissector tables and heuristic subdissector lists with a protocol.Michael Mann7-17/+16
This will make it easier to determine protocol dependencies. Some LLC OUI dissector tables didn't have an associated protocol, so they were left without one (-1 used) Change-Id: I6339f16476510ef3f393d6fb5d8946419bfb4b7d Reviewed-on: https://code.wireshark.org/review/14446 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-12[docsis->mdd] Add support for TLV 1.6Adrian1-0/+20
Change-Id: I5c7529bc630ad7312011b04ce101ba3608041d35 Reviewed-on: https://code.wireshark.org/review/14435 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-03Revert "autotools: Use -Werror with clean plugin code"João Valverde2-38/+24
This reverts commit 31654e5e5c0c44609584140a10eb7d9aa1572673. Change-Id: I27f3465c680daa599b96a7259ca93f96f2a622a5 Reviewed-on: https://code.wireshark.org/review/14324 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-03autotools: Use -Werror with clean plugin codeJoão Valverde2-24/+38
Change-Id: I0bc94702eaf87924467e6129ac22f4755308f8d3 Reviewed-on: https://code.wireshark.org/review/14319 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-01IrDA: Register a link-layer IrLAP address type".Michael Mann1-8/+38
Was using AT_NONE as "unknown address type" instead of "no address". Ping-Bug: 12205 Change-Id: Ic1d7022f8eaa3dfab9bb7b607eed264cc527c87c Reviewed-on: https://code.wireshark.org/review/14242 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-28gryphon: fix 'gryphon.reserved' exists multiple times with NOT compatible ↵Alexis La Goutte1-44/+28
types: FT_BYTES and FT_UINT32 Change-Id: Ia2ef8c4211ca717d6e99f596cd7f2de92d5aa7ca Reviewed-on: https://code.wireshark.org/review/14202 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-27irda: fix 'irlmp.xid.name' exists multiple times with NOT compatible types: ↵Alexis La Goutte1-1/+1
FT_BYTES and FT_STRING Change-Id: I93215bd126dab1e7b6207f8510c7ce9b116637a3 Reviewed-on: https://code.wireshark.org/review/14203 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-26Add free_address_wmem(), fix warnings [-Wcast-qual]João Valverde4-35/+18
Try to improve address API and also fix some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Second try, now passing test suite. Change-Id: Idc101cd866b6d4f13500c9d59da5c7a38847fb7f Reviewed-on: https://code.wireshark.org/review/13946 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-21autotools: Use pkg-config autoconf macros for GLib/GTKJoão Valverde15-2/+58
Remove mostly obsolete aclocal macros. Make GTK build flags a strict superset of GLib flags. Use GTK build variables for GTK GUI and GLib elsewhere. Add dependency flags explicitly instead of using WS_CPPFLAGS. Some minor improvements and fixes for missing/unnecessary variables (no impact on our test builds). Change-Id: I3e1f067a875f79d6516c1fa7af986f17a7a6b671 Reviewed-on: https://code.wireshark.org/review/14005 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-20autotools: Move common automake code for plugins to an include fileJoão Valverde16-804/+109
Change-Id: Icac1eb17ff78ae5ae54b61820618bf3c5733bd96 Reviewed-on: https://code.wireshark.org/review/14003 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-14Fix format string warnings [-Wformat=]João Valverde2-4/+4
Change-Id: I266c7d422f6ade965b42a4e2e8dc01966f8eb5f8 Reviewed-on: https://code.wireshark.org/review/13932 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-12unistim: fix broadcast_phone_msgs’ defined but not used ↵Alexis La Goutte1-0/+2
[-Werror=unused-const-variable] found by gcc6 Change-Id: Icdf648e820c7a81546249c0e5060d8537278ffa4 Reviewed-on: https://code.wireshark.org/review/13904 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-12Profinet (pn-mrp): fix statement is indented as if it were guarded by... ↵Alexis La Goutte1-16/+16
[-Werror=misleading-indentation] found by gcc6 Change-Id: I1d8709857cf3e1e65bca0c0c94629c47fc1a3c06 Reviewed-on: https://code.wireshark.org/review/13903 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-08Revert "Add free_address_wmem() and other extensions to address API"João Valverde4-18/+35
This reverts commit 13ec77a9fc3af3b0b502820d0b55796c89997896. This commit introduces a segmentation fault for Lua code (uncovered by the test suite). Change-Id: Ibc273d1915cda9632697b9f138f0ae104d3fb65e Reviewed-on: https://code.wireshark.org/review/13813 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-07Add free_address_wmem() and other extensions to address APIJoão Valverde4-35/+18
Try to improve 'address' API (to be easier/safer) and also avoid some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Change-Id: I7456516b12c67620ceadac447907c12f5905bd49 Reviewed-on: https://code.wireshark.org/review/13463 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-03Get rid of an unused variable.Guy Harris1-5/+0
Change-Id: I2f99327feafe95524c24718b320a8490779ad6c5 Reviewed-on: https://code.wireshark.org/review/13698 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-03Fixed bug when the actual remaining command data is less than the sizerichardk2-115/+131
specified in the EtherCAT mailbox header. Change-Id: I661c62af915b9455da1df49f5746953d41dc527a Reviewed-on: https://code.wireshark.org/review/13595 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-29Try to fix 'make distcheck'João Valverde1-2/+3
Change-Id: I1656ca8e86e506f39ef7f7600bd9d5a21670ad1e Reviewed-on: https://code.wireshark.org/review/13589 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28Another fix for g265a41eJoão Valverde1-2/+1
Disable -Werror as before. Change-Id: Iec27be6eba742555bce28bb1c81c2e15153db566 Reviewed-on: https://code.wireshark.org/review/13588 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28MATE: Disable Werror as before g265a41eJoão Valverde1-2/+1
Change-Id: Ia89f40245e5b7eab2dc23ce7b37d5107863bbfdd Reviewed-on: https://code.wireshark.org/review/13583 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28autotools: Don't use "user variables" to set build flagsJoão Valverde14-109/+21
GNU coding standards recommend against it and automake is designed around it. This allows overriding the global build flags using AM_CFLAGS, etc., or per object flags, something that is difficult or impossible currently because of automake precedence rules. Change-Id: I3f1ea12e560af5a46b2f04b342b1882bbf123f12 Reviewed-on: https://code.wireshark.org/review/13455 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris2-0/+2
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris8-56/+56
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-23More pinfo->fd->abs_ts to pinfo->abs_ts.Guy Harris1-3/+3
Change-Id: I70db0a345cc4c5c57c454371deb4f92f9ac4b9ac Reviewed-on: https://code.wireshark.org/review/13501 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-13Swapped align error and crc error bit in EtherCAT Switch Link dissector.richardk1-4/+5
Change-Id: I218b1c412c5b8e41025c6a9434caef38653a36df Reviewed-on: https://code.wireshark.org/review/13262 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-13Use result of register_dissectorPeter Wu1-11/+2
Assign result of `register_dissector(..., func, proto)` to FOO_handle and remove `FOO_handle = create_dissector_handle(func, proto)`. Found by looking for files named packet-FOO.c having the above create_dissector_handle pattern. Some files (with different dissect routines for the two functions) remain unchanged. Change-Id: Ifbed8202c6dbc63a1dae9acc03313980ffbbbb90 Reviewed-on: https://code.wireshark.org/review/13247 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-12WS_DLL_PUBLIC_DEF is for definitions; WS_DLL_PUBLIC is for declarations.Guy Harris1-1/+1
Change-Id: I16d5981c8c76d59d19be0600e218495f1f6552b2 Reviewed-on: https://code.wireshark.org/review/13215 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-1/+1
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-07[docsis->INIT-RNG-REQ] Correction for INFO fieldAdrianSimionov1-1/+1
Most probably this issue was introduced as a copy paste from RNG-REQ packet when INIT-RNG-REQ packet was first created. Change-Id: I5eb0ac666c76b48d70b3383312f0598b6110cc03 Reviewed-on: https://code.wireshark.org/review/13085 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-28[docsis->bpkmattrib] Correction for TLV 15 text from 14->15AdrianSimionov1-1/+1
Change-Id: Ic1122e36c8099c1f891d3d5f81bd7fb4977d2ffd Reviewed-on: https://code.wireshark.org/review/12880 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-28[docsis->sync] Remove colon from INFO fieldAdrianSimionov1-1/+1
SYNC is a simple message, there is no info to follow the colon. Most probably was introduced as a copy paste from more complex packets. Change-Id: I552aad68f9484f347266838e9c319de680825dde Reviewed-on: https://code.wireshark.org/review/12879 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-12Remove -Wwrite-strings compiler flagJoão Valverde1-1/+1
The "-Wwrite-strings" flag produces nuisance warnings. These warnings are not useful, they're impossible to fix in a sane way and therefore are being handled with casts of static strings to (char *). This just moves the warning to [-Wcast-qual] and a compiler pragma is in turn required (and used) to squelch that warning. Remove the Wwrite-strings warning. Let that responsibility fall on the programmer (as is done by casting). Change-Id: I5a44dfd9decd6d80797a521a3373593074962fb5 Reviewed-on: https://code.wireshark.org/review/12162 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-11new_create_dissector_handle -> create_dissector_handle for plugins.Michael Mann37-51/+51
Change-Id: I0d485b1337c669291ad58b6c096657ce2db353c8 Reviewed-on: https://code.wireshark.org/review/12516 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-11new_register_dissector -> register_dissector for remaining uses.Michael Mann71-74/+74
Mostly plugins, but also LUA and generated skinny dissector. Change-Id: Ifeb4205442f9a60875266b4e82841ff38b4fdb63 Reviewed-on: https://code.wireshark.org/review/12515 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-08opcua: expand ReturnDiagnostics field of RequestHeaderHannes Mezger3-60/+121
The ReturnDiagnostics field of RequestHeader is a bitmask. It cannot be generated, as the information needed is not contained in our models used to generate the generated files. This is why I made a manual change to opcua_complextypeparser.c. In the future, this change has to be merged if the file gets regenerated. Change-Id: Ic7db499566e3f3d3006feaff6e25e7b37a427dca Reviewed-on: https://code.wireshark.org/review/12470 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-08opcua: fix order of ExpandedNodeId bitsHannes Mezger1-1/+1
Make fields appear from right to left bit instead of mixed Change-Id: I78152eab6901440f483b0af7d2395edebaa7ab3d Reviewed-on: https://code.wireshark.org/review/12469 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05Use noyywrap rather than defining our own yywrap functions.Guy Harris2-22/+10
Tweak lemonflex-tail.inc to fix an issue this reveals. It appears that, at least on the buildbots, the Visual Studio compiler no longer issues warnings for the code generated with %option noyywrap. Change-Id: Id64d56f1ae8a79d0336488a4a50518da1f511497 Reviewed-on: https://code.wireshark.org/review/12433 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-01Removed some remaining svn Id tagsStig Bjørlykke2-4/+0
Change-Id: I7ffbf59099132cde55995bde991d1c6a5dd224b0 Reviewed-on: https://code.wireshark.org/review/12330 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-11-27Officially remove tvb_get_string and tvb_get_stringz.Michael Mann3-10/+6
Almost all replacements were done awhile ago, just put the final nail in the coffin. Change-Id: I0a708d886da5a500c2a1e2c9ee2736794bdb9411 Reviewed-on: https://code.wireshark.org/review/12206 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-27Remove manual setting of pinfo->current_proto.Michael Mann1-3/+0
Calling a protocol dissection function will properly set/restore pinfo->current_proto, so there's no need to duplicate it. Change-Id: Ic2ec0b35fa4d46a98f3410bf238056425076e4a9 Reviewed-on: https://code.wireshark.org/review/12205 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-25Profinet: All SubframeData elements are not decodedBirol Capa1-4/+7
In PDevData/PDirSubframeData/SubframeBlock, not all SubframeData elements are decoded/shown. However, all bytes of the SubframeBlock are highlighted in the binary stream correctly. Change-Id: Ic69999dff524e2e0c48a619def111c4bf9cca5e1 Reviewed-on: https://code.wireshark.org/review/12100 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-25Profinet: ARProperties that contains Combined Object Container BitBirol Capa1-6/+45
New ARProperties has a bit that contains if usage of Combined Object Container is required or not. Change-Id: Ia4420cdf161d79933fcc0d8ffb411c02bfe26f3b Reviewed-on: https://code.wireshark.org/review/12098 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-24Developers Guide updates for plugins with CMakeGraham Bloice14-14/+14
Remove references to nmake, add references to CMake. Change-Id: Iea2d2b2fbdbab131bae823d5d6a5306630a70347 Reviewed-on: https://code.wireshark.org/review/12079 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-24[docsis->type35ucd] Add support for type 35 UCD message.AdrianSimionov3-0/+1186
* Added support for TLV 20 * Added support for TLV 21 * Added support for TLV 22 * exceptions.h not needed compared to packet-ucd.c and packet-type29ucd.c * value_string iuc_vals3 became static const compared to packet-ucd.c and packet-type29ucd.c * if(tree) was removed to allow usage of expert on TLV length * HEX crafted packet capture in Bug 11745 Bug: 11745 Change-Id: If21a44cf26941468747772cefffe29bafacb1c7c Reviewed-on: https://code.wireshark.org/review/11956 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-23register_dissector -> new_register_dissectorMichael Mann6-26/+31
Change-Id: Ifc8208e1b96e2a3bf297912500a5f252bfa8eed9 Reviewed-on: https://code.wireshark.org/review/12073 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-22[docsis] Remove unused exceptions.hAdrianSimionov3-10/+23
* Add static const to IUC vals * I defined the IUC values local to packet-map.c packet because it needs to be revised, not all IUC apply to all packets. It works for now but some of the IUC might be gone. Change-Id: Ib4da9ae8e29afca065153c3934336565371da9a9 Reviewed-on: https://code.wireshark.org/review/11993 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-20[docsis->ucd] Dissect TYPE and LENGTH values for burst TLVs also.AdrianSimionov1-60/+108
* Fixed filter for TLV Length Wrong. Change-Id: Ic2fa2a6e1faa7bad604468fbcbc431fd38a5a113 Reviewed-on: https://code.wireshark.org/review/11922 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-19Profinet: use pinfo pool to build conversation filterPascal Quantin1-9/+7
Packet pool cannot be used from GUI. Bug: 11730 Change-Id: I4f5764a38a10809373c365ecf1ea50404a15b89a Reviewed-on: https://code.wireshark.org/review/11966 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-24 11:05:30 +0000