aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2017-09-19Disable flex-generated [-Wsign-compare] warningsJoão Valverde2-0/+8
Change-Id: Iace0462e6bb50573f3e4603f7a19e4b7ee1f9733 Reviewed-on: https://code.wireshark.org/review/23541 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-16_U_ is wrong in c++, as is Q_UNUSED (in most cases).Joerg Mayer1-2/+1
The correct way is to not name the variable. Change-Id: Ic016f1b9161db6b4cc3f6534c853a1f50e31aa2b Reviewed-on: https://code.wireshark.org/review/23569 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-09-15epan: Fix misuse of comma operatorStig Bjørlykke1-1/+1
Change-Id: I349dc9896db0bd306bc92f92eb9d4a65d98d309c Reviewed-on: https://code.wireshark.org/review/23558 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-15Qt: Use Q_UNUSED macro for unused argumentsStig Bjørlykke1-1/+2
Change-Id: I4bf7fe4ba3e3e6575e6537a8ec2b6024c253e776 Reviewed-on: https://code.wireshark.org/review/23559 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-09packet-dcerpc-pn-io.c: Fix potential resource leakshqking1-0/+6
Bug: 13826 Change-Id: I01674d5a31281508686bc06e222d6a87926d1c83 Reviewed-on: https://code.wireshark.org/review/23436 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-08DOCSIS: Fix compiler warning on macOS.Michael Mann1-1/+1
Previous functionality presumed cat = 0, so initialize cat to it. Change-Id: Ic0fdccc8222dfb435178416911d35bac105c6c03 Reviewed-on: https://code.wireshark.org/review/23434 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-08DOCSIS: Ensure docsis_ucd has a registered dissection functionMichael Mann1-1/+3
Bug: 14038 Change-Id: I36fbaa591a7ebf5da7d2e7be837e8fcca30c7f98 Reviewed-on: https://code.wireshark.org/review/23432 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-07DOCSIS: Added support for version 5 MAPs (dissect_map_v5)Bruno Verstuyft1-27/+188
Change-Id: Icc43fdc341a8f263af5d7b9e1bc14e13b5361dd0 Reviewed-on: https://code.wireshark.org/review/23392 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-06CMake: Make plugin installation path use PLUGIN_INSTALL_LIBDIRJoão Valverde16-48/+48
Change-Id: I47f248f6ef56aba400054fa3ade2bf4d29eeb895 Reviewed-on: https://code.wireshark.org/review/23411 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-05Fix memory leak in wimaxasncpAhmad Fatoum1-2/+2
Remove unnecessary null-check before free as well. Change-Id: Ic54459149b40fd8c8f58c643bbd6cfc81ee8b923 Reviewed-on: https://code.wireshark.org/review/23398 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-04Extra decodings for DOCSIS MDD messageBruno Verstuyft1-0/+189
Change-Id: I8765c96717d80f2b340428eb025e0a1e52a6e495 Reviewed-on: https://code.wireshark.org/review/23353 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-03Extra decodings for DOCSIS RNGRSPBruno Verstuyft1-5/+217
Change-Id: I27ad1143dc5c568a3c7cced4f61c11e45485c7f4 Reviewed-on: https://code.wireshark.org/review/23354 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-08-28transum: clear the list of wanted hfids in file cleanup routinePeter Wu1-6/+9
Be sure to disable the wanted hfids list when the transum dissector is cleaned up, otherwise it will leak memory when reloading a file while the transum dissector is enabled. Change-Id: I2af8edab89da8b3cfb65e19726e1d2546a1dc8d4 Reviewed-on: https://code.wireshark.org/review/23261 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-28PNIO: Fix another potential OOB write.Gerald Combs1-2/+3
Bug: 13847 Change-Id: I62bb519b8e37112a59a7d209b39780f034dbcd0c Reviewed-on: https://code.wireshark.org/review/23267 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-23Fix potential oob write crashesUlf1-6/+6
Bug: 13847 Change-Id: I3a706db25204fe4c1fd1b7be3b17b8c55365dccf Reviewed-on: https://code.wireshark.org/review/23169 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-18TRANSUM fails with DCE-RPC request Packet Type 0Paul Offord2-4/+4
TRANSUM fails to calculate RTE figures for DCE-RPC where request Packet Type is zero Bug: 13988 Change-Id: I1dd7aee0283042703530a6d72fff063279e6147e Reviewed-on: https://code.wireshark.org/review/23115 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-31IrCOMM: check string length before appending it to itemPascal Quantin1-2/+8
Bug: 13929 Change-Id: I33f3fec77014949fcc15df72c42ffcb25158562f Reviewed-on: https://code.wireshark.org/review/22887 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-19dcerpc-pn-io (profinet): fix typo for pn_io.iops display filterAlexis La Goutte1-1/+1
Change-Id: I8422005703c9e0a04d067dfe5ba501fe7417ff8a Reviewed-on: https://code.wireshark.org/review/22718 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-09Don't use uint_to_str_back when you need guint32_to_str_buf.Michael Mann1-4/+2
It will end up eventually crashing column buffers because memory behind the address is trounced. Change-Id: Id6b5a42effc503e4b8bf5e1deb2135241e2893f3 Reviewed-on: https://code.wireshark.org/review/22563 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-03mate_grammar(lemon): fix this statement may fall through ↵Alexis La Goutte1-1/+2
[-Werror=implicit-fallthrough] found by gcc7 Change-Id: Id26c1c0d1678613a90ff7707265ec062cd30cf83 Reviewed-on: https://code.wireshark.org/review/22501 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-26Parse enterprise-numbers at run timeJoão Valverde1-1/+1
"enterprise-numbers" is converted to tab-separated values and renamed "enterprises". Unused fields are stripped. PENs are stored in a hash table loaded at run-time. User "enterprises" file is loaded from the personal config dir. Misc make-sminmpec.pl improvements and fixes. Note: names of type "Entity (formerly ...)" have the formerly part commented out for a cleaner output. Change-Id: I60c533afbe3e399077fbf432088064471ad3e1e2 Reviewed-on: https://code.wireshark.org/review/22246 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: João Valverde <j@v6e.pt>
2017-06-19PROFINET IO: define an arbitrary recursion depth limitPascal Quantin1-3/+12
Bug: 13811 Change-Id: I52bffd4a79dcdad9da23f33e1fc6a868472390bf Reviewed-on: https://code.wireshark.org/review/22232 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-14DOCSIS: Prevent infinite loop from unknown FCParm.Michael Mann1-0/+4
concatlen was not updated if FCParm was unknown, leading to an infinite loop. Bug: 13797 Change-Id: I1b64d757a369183a711f01b0b5cd1ba7aa0787bc Reviewed-on: https://code.wireshark.org/review/22120 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-07profinet: use proto_tree_add_item_ret_(u)int directlyMartin Kaiser5-43/+26
Profinet defined functions to add 32bit integers to the tree and get their value. This is equivalent to proto_tree_add_item_ret_(u)int. Call those functions directly and remove the now obsolete Profinet functions. In some cases, the returned 32bit value is discarded. Use proto_tree_add_item then. Change-Id: I7744fab2f27b8ae8e681a36e4e96eb2f8be87bd6 Reviewed-on: https://code.wireshark.org/review/21989 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-06profinet: use proto_tree_add_item_ret_(u)intMartin Kaiser1-12/+4
profinet has a number of internal functions that add an item to the tree and read its value. For 32bit integers, this is exactly what proto_tree_add_item_ret_(u)int do. Just call those functions. (We could do the same for 8 and 16bit values. We'd need a temporary value then and the code wouldn't be much easier than it is now.) Change-Id: I98fc70ced2dc5a552235a476d40a4275f3b3bd38 Reviewed-on: https://code.wireshark.org/review/21965 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2017-06-04profinet dcp: simplify dissect_PNDCP_Suboption_Manuf()Martin Kaiser1-9/+4
There's not much point in having a switch-case block with only a default statement ;-) Change-Id: Iaacd87bb2995783b98e5395b3654a1c8f32c473a Reviewed-on: https://code.wireshark.org/review/21938 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-04profinet dcp: don't THROW() an exception from a dissectorMartin Kaiser1-1/+5
In this case, we can simply replace the exception with an expert info and exit the loop. Change-Id: I232e554af299140d7123b5e21d78372a35a7923b Reviewed-on: https://code.wireshark.org/review/21936 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-04profinet: remove unnecessary if(tree) checksMartin Kaiser1-32/+15
Change-Id: I0c4346386846c03a67b83bebfce6da6323379180 Reviewed-on: https://code.wireshark.org/review/21937 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-31opcua: fix no previous prototype for ↵Alexis La Goutte2-2/+2
‘parseNodeClassMask/parseResultMask’ [-Wmissing-prototypes] Change-Id: If57183bcea978b766fc53f691a35c4ddf98ca2dd Reviewed-on: https://code.wireshark.org/review/21849 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-20If we don't have an ARUUID, don't use it as if we do.Guy Harris1-8/+14
Don't use random on-the-stack data as a UUID. Change-Id: I77961e1404ad73a484a7fc865bc54219dc239b4d Reviewed-on: https://code.wireshark.org/review/21721 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-12DOCSIS: Simplify all MAC Management into a single file.Michael Mann49-14305/+7781
Removes a bunch of duplication set up because commands were all in different files. Change-Id: I950bc70da0edcdef7aaf21a43328cf69267f79af Reviewed-on: https://code.wireshark.org/review/21613 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-12OPC UA: Added details for BrowseDescription NodeClassMask and ResultMaskCamille Guérin7-33/+133
Display the details for the NodeClassMask and ResultMask values in a BrowseRequest's BrowseDescription. As described in OPC UA 1.03 Specification, the value 0 for the NodeClassMask and the value 63 (0x003F) for ResultMask should results in returning all the fields in the BrowseResponse. Display 'All' when those fields have those values Display a detailled bit tree mask when values are different Code Change: Added parseNodeClass and parseResultMask Use them in parseBrowseDescription instead of parseUInt32 Removed not needed anymore hf_opcua_NodeClassMask, hf_opcua_ResultMask and their related entries in registerFieldTypes Change-Id: Ic3ed8630825b5456f91156f06b2203ebfa422155 Reviewed-on: https://code.wireshark.org/review/21446 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-10Define YYMALLOCARGTYPE appropriately.Guy Harris1-2/+3
Define it, so the generated parser knows what argument type the function passed to MateParserAlloc() takes. Use it when declaring MateParserAlloc(). Change-Id: Ice18fd6b5fdbdb31f527e5d6eb06e78594d4565b Reviewed-on: https://code.wireshark.org/review/21588 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-10Clean up MateParser routine declarations.Guy Harris2-9/+6
Remove the declarations from mate_parser.l, and have mate_parser.h include mate.h at the beginning of the file, instead. Move the #if'ed version of the declaration of MateParserAlloc() to mate.h. Change-Id: I03ffdd5f093b179ffc0cb0e43eac093f7e4af65c Reviewed-on: https://code.wireshark.org/review/21587 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-09mate (grammar): fix no previous prototype for function ↵Alexis La Goutte1-0/+6
'MateParser/Alloc/Free' [-Wmissing-prototypes] Change-Id: I87ff11b7c04cb3b6963d4c8c16df2c3d60a0aec8 Reviewed-on: https://code.wireshark.org/review/21574 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-09docsis: DCC-REQ TLV 2.7 supportAdrian Simionov1-0/+23
Change-Id: I40724306d5facd0f4a5a9ca2354330577857d27f Reviewed-on: https://code.wireshark.org/review/21563 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-09Bring DOCSIS Mac Management "dissectors" into modernity.Michael Mann42-4129/+4256
1. Use proto_tree_add_item_ret_uint to remove separate "gets" 2. Remove if (tree)s that prevented expert_info 3. Apply consistent whitespace 4. Apply consistent TLV behavior, making T and L always filterable 5. Remove T name (of TLV) from field name itself (where applicable) 6. Use BASE_UNIT_STRING and BASE_NO_DISPLAY_VALUE Tested with capture generated from https://github.com/AdrianSimionov/docsis-generator Change-Id: I9987397ccb3248b2a26d850af468740f94b28a63 Reviewed-on: https://code.wireshark.org/review/21561 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-05dcerpc pn io (profinet) fix conflicting entry in its value_stringAlexis La Goutte1-1/+1
Field 'Index' (pn_io.index) has a conflicting entry in its value_string: 45057 is at indices 82 (Sync-Log / RTA SyncID 1 (GSY)) and 114 (reserved for profiles)) Change-Id: Ic3e6f6db0631a9337861cd697b4d7bf17fba0c36 Reviewed-on: https://code.wireshark.org/review/21513 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-05pn dcp (profinet): fix conflicting entry in its value_stringAlexis La Goutte1-1/+1
Field 'BlockQualifier: ResettoFactory' (pn_dcp.block_qualifier_reset) has a conflicting entry in its value_string: 9 is at indices 7 (Resets all stored data) and 12 (Reserved)) Change-Id: I9d43fc44899d47eaafb50a76511dda69560a75da Reviewed-on: https://code.wireshark.org/review/21512 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-05[docsis->dccrsp] Resolve confirmation codeAdrian Simionov1-1/+4
Change-Id: I1f863eea427529537df004e9782311d5c69ed4bd Reviewed-on: https://code.wireshark.org/review/21505 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-03[DOCSIS] Use expert info instead of THROWing bounds errors for bad lengthsMichael Mann9-717/+833
Also adjust whitespace for a few places where if (tree) would mess up expert_info use. Change-Id: I79b8f7105515fb9ce220a46f3e875be466ee1044 Reviewed-on: https://code.wireshark.org/review/21474 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-02[docsis->dccrsp] Update TLV numbers and names to MULPIv3.1-I10Adrian Simionov1-5/+5
Change-Id: I72bec5bcbe7e2139ae36bf704e7ebda9207331fd Reviewed-on: https://code.wireshark.org/review/21424 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-27[docsis->Annex C] Fix TLV 45 decodingAdrian Simionov1-1/+2
Change-Id: I23830283c1a3323cfb3b72da1e329c72817119ab Reviewed-on: https://code.wireshark.org/review/21362 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-24[docsis->bpkm-attr] Updated Attribute 16 Error CodesAdrian Simionov1-3/+5
Change-Id: If9156b4a73e7db006daf4ab4e278379f0e39905f Reviewed-on: https://code.wireshark.org/review/21313 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-18Rename BASE_VALS_NO_UNKNOWN to BASE_SPECIAL_VALS.Guy Harris3-4/+4
It makes it a bit clearer what its purpose is - to allow a value_string to be used for numeric rather than enumerated fields, giving certain values of the field a special meaning. Change the explanation in the documentation to match as well. Change-Id: Id07b22eee996b79ea5f3473928d29adcabe09bf3 Reviewed-on: https://code.wireshark.org/review/21209 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-18mate: avoid redefining NDEBUGPascal Quantin1-0/+2
When building RelWithDebInfo target with MSVC, NDEBUG is automatically defined. Avoid redefining the macro by checking if it already exists. Change-Id: I1720f47cce0df210c2b2dff3b20c218dc2ae7b02 Reviewed-on: https://code.wireshark.org/review/21200 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-17Qt: Provide both file save and open preferencesAhmad Fatoum1-1/+1
This is a breaking change. prefs_register_filename_preference hasn't been differentiating between files to be saved and ones to be opened. On GTK, a neutral dialog is used, so no problems there. On Qt, a save dialog has been always used, even in dissectors that were reading configuration files without modification. prefs_register_filename_preference now takes an argument to indicate whether UI could be a save dialog with a warning on overwriting a file, or whether it's a general purpose open file dialog. Qt now does this. Previously no warning was shown on overwriting a file, so it may be used for opening files too without irritating the user. This has been changed, as non-destructive reads should now use the open dialog. Dissectors were changed accordingly. Change-Id: I9087fefa5ee7ca58de0775d4fe2c0fdcfa3a3018 Reviewed-on: https://code.wireshark.org/review/21086 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-04-17Get rid of unnecesary #includes.Guy Harris1-3/+0
Change-Id: I379a2a1007be1b844873d9c5e8ea53bd689f0f4d Reviewed-on: https://code.wireshark.org/review/21158 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-17Remove unnecessary tap.Guy Harris1-38/+0
The tap was just a trick to get fields and protocols registered as being of interest. Now that we have mechanisms by which postdissectors can explicitly register fields and protocols as being of interest, and are using that, the trick is no longer needed. Change-Id: I0bccc88a1e4ee4c9fc84b90d968820375594c5c1 Reviewed-on: https://code.wireshark.org/review/21157 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-17Remove unnecessary tap.Guy Harris4-57/+7
The tap was just a trick to get fields and protocols registered as being of interest. Now that we have mechanisms by which postdissectors can explicitly register fields and protocols as being of interest, and are using that, the trick is no longer needed. Change-Id: Ib2620ff32c41ffa050203c1d4481c63535fb3f4b Reviewed-on: https://code.wireshark.org/review/21156 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-15 13:57:52 +0000